* Re: [PATCH] mailbox: Fix NULL vs IS_ERR() check in zynqmp_ipi_mbox_probe()
@ 2020-04-29 9:13 ` Markus Elfring
0 siblings, 0 replies; 2+ messages in thread
From: Markus Elfring @ 2020-04-29 9:13 UTC (permalink / raw)
To: Wei Yongjun, linux-arm-kernel
Cc: kernel-janitors, linux-kernel, Jassi Brar, Michal Simek, Wendy Liang
> In case of error, the function devm_ioremap() returns NULL pointer
> not ERR_PTR().
Such information is helpful.
> The IS_ERR() test in the return value check should be replaced with NULL test.
Would you like to convert this description into an imperative wording?
Regards,
Markus
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] mailbox: Fix NULL vs IS_ERR() check in zynqmp_ipi_mbox_probe()
@ 2020-04-29 9:13 ` Markus Elfring
0 siblings, 0 replies; 2+ messages in thread
From: Markus Elfring @ 2020-04-29 9:13 UTC (permalink / raw)
To: Wei Yongjun, linux-arm-kernel
Cc: kernel-janitors, linux-kernel, Jassi Brar, Michal Simek, Wendy Liang
> In case of error, the function devm_ioremap() returns NULL pointer
> not ERR_PTR().
Such information is helpful.
> The IS_ERR() test in the return value check should be replaced with NULL test.
Would you like to convert this description into an imperative wording?
Regards,
Markus
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-04-29 9:13 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-29 9:13 [PATCH] mailbox: Fix NULL vs IS_ERR() check in zynqmp_ipi_mbox_probe() Markus Elfring
2020-04-29 9:13 ` Markus Elfring
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.