From: 함명주 <myungjoo.ham@samsung.com> To: Saravana Kannan <skannan@codeaurora.org> Cc: 박경민 <kyungmin.park@samsung.com>, "linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, "linux-arm-msm@vger.kernel.org" <linux-arm-msm@vger.kernel.org>, "linux-arm-kernel@lists.infradead.org" <linux-arm-kernel@lists.infradead.org> Subject: Re: Re: [PATCH] PM / devfreq: Fix out of bounds access of transition table array Date: Wed, 26 Feb 2014 05:12:03 +0000 (GMT) [thread overview] Message-ID: <19338058.266151393391521988.JavaMail.weblogic@epml02> (raw) > On 02/23/2014 11:15 PM, Saravana Kannan wrote: > > The previous_freq value for a device could be an invalid frequency that > > results in a error value being returned from devfreq_get_freq_level(). > > Check for an error value before using that to index into the transition > > table. > > > > Not doing this check will result in memory corruption when previous_freq is > > not a valid frequency. > > > > Signed-off-by: Saravana Kannan <skannan@codeaurora.org> > > MyungJoo/Kyungmin, > > Would either of you have some time to respond to this? > > Thanks, > Saravana Dear Saravana, > > + prev_lev = devfreq_get_freq_level(devfreq, devfreq->previous_freq); > > + if (prev_lev < 0) > > + return 0; If devfreq_get_freq_level returned error, please return that error to the caller. You are retuning 0 in that case. Plus, do you think we are going to change profile->freq_table in run-time? (by accidently? or intentionally?) Cheers, MyungJoo. > > > -- > The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, > hosted by The Linux Foundation > > > > > > >
WARNING: multiple messages have this Message-ID (diff)
From: 함명주 <myungjoo.ham@samsung.com> To: Saravana Kannan <skannan@codeaurora.org> Cc: 박경민 <kyungmin.park@samsung.com>, "linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, "linux-arm-msm@vger.kernel.org" <linux-arm-msm@vger.kernel.org>, "linux-arm-kernel@lists.infradead.org" <linux-arm-kernel@lists.infradead.org> Subject: Re: Re: [PATCH] PM / devfreq: Fix out of bounds access of transition table array Date: Wed, 26 Feb 2014 05:12:03 +0000 (GMT) [thread overview] Message-ID: <19338058.266151393391521988.JavaMail.weblogic@epml02> (raw) [-- Warning: decoded text below may be mangled, UTF-8 assumed --] [-- Attachment #1: Type: text/plain; charset=euc-kr, Size: 1270 bytes --] > On 02/23/2014 11:15 PM, Saravana Kannan wrote: > > The previous_freq value for a device could be an invalid frequency that > > results in a error value being returned from devfreq_get_freq_level(). > > Check for an error value before using that to index into the transition > > table. > > > > Not doing this check will result in memory corruption when previous_freq is > > not a valid frequency. > > > > Signed-off-by: Saravana Kannan <skannan@codeaurora.org> > > MyungJoo/Kyungmin, > > Would either of you have some time to respond to this? > > Thanks, > Saravana Dear Saravana, > > + prev_lev = devfreq_get_freq_level(devfreq, devfreq->previous_freq); > > + if (prev_lev < 0) > > + return 0; If devfreq_get_freq_level returned error, please return that error to the caller. You are retuning 0 in that case. Plus, do you think we are going to change profile->freq_table in run-time? (by accidently? or intentionally?) Cheers, MyungJoo. > > > -- > The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, > hosted by The Linux Foundation > > > > > > > ÿôèº{.nÇ+·®+%Ëÿ±éݶ\x17¥wÿº{.nÇ+·¥{±þG«éÿ{ayº\x1dÊÚë,j\a¢f£¢·hïêÿêçz_è®\x03(éÝ¢j"ú\x1a¶^[m§ÿÿ¾\a«þG«éÿ¢¸?¨èÚ&£ø§~á¶iOæ¬z·vØ^\x14\x04\x1a¶^[m§ÿÿÃ\fÿ¶ìÿ¢¸?I¥
next reply other threads:[~2014-02-26 5:12 UTC|newest] Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top 2014-02-26 5:12 함명주 [this message] 2014-02-26 5:12 ` Re: [PATCH] PM / devfreq: Fix out of bounds access of transition table array 함명주 2014-02-27 0:45 ` Saravana Kannan 2014-02-27 0:45 ` Saravana Kannan
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=19338058.266151393391521988.JavaMail.weblogic@epml02 \ --to=myungjoo.ham@samsung.com \ --cc=kyungmin.park@samsung.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-arm-msm@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-pm@vger.kernel.org \ --cc=skannan@codeaurora.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.