From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C41B0EB64DA for ; Sat, 8 Jul 2023 13:16:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230122AbjGHNQE (ORCPT ); Sat, 8 Jul 2023 09:16:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39264 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229462AbjGHNQC (ORCPT ); Sat, 8 Jul 2023 09:16:02 -0400 Received: from smtp.smtpout.orange.fr (smtp-19.smtpout.orange.fr [80.12.242.19]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 456FFE55 for ; Sat, 8 Jul 2023 06:16:01 -0700 (PDT) Received: from [192.168.1.18] ([86.243.2.178]) by smtp.orange.fr with ESMTPA id I7mwqrPmVn02aI7mwqEG5C; Sat, 08 Jul 2023 15:15:58 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=wanadoo.fr; s=t20230301; t=1688822158; bh=MtFS4H/mvjYBQ6kD2sk3yhpdjTWzlyIwy/D4XqevP4Y=; h=Date:Subject:To:Cc:References:From:In-Reply-To; b=HeBBJKpw7QjGeqAKXjtW9K+A/j1qxIyP4Z1zGSbXu9RowIPmKLtfnvwiQ4OA7fYT+ ynZxJA4onQ2YKhyb2xx+aT2meliqLoHnzUUHi5QZy3USNLU9R9p0vcxkFUeAdvycj7 NvZqTPJS+7tvbnFvywGvWqICUwGihsuOJc5m2FeqkJQdL5mdY1hW20VbH5uiZlYlyV 0Alv1EguSOV8CKnXcxwzuD8C3uFNV5vXWtKm8l93lwbM2U3FJQEQxrWiR3syveFvca 2+5Jt9+YuYoMUgm9iQ6y8Kol3EeLVXZzA1UVQz36sGSJeraBfjmFBNYGehCksSPzlB jCdWdxt20YoTg== X-ME-Helo: [192.168.1.18] X-ME-Auth: Y2hyaXN0b3BoZS5qYWlsbGV0QHdhbmFkb28uZnI= X-ME-Date: Sat, 08 Jul 2023 15:15:58 +0200 X-ME-IP: 86.243.2.178 Message-ID: <19369234-8785-575b-ff24-9a21a9e82f0e@wanadoo.fr> Date: Sat, 8 Jul 2023 15:15:50 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: RE: [PATCH net v2 1/2] net: ll_temac: Fix DMA resources leak To: "Katakam, Harini" , Jakub Kicinski , Jonas Suhr Christensen Cc: Paolo Abeni , "netdev@vger.kernel.org" , "David S. Miller" , Eric Dumazet , Michal Simek , Haoyue Xu , huangjunxian , Wang Qing , Yang Yingliang , Esben Haabendal , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "Neeli, Srinivas" References: <20230205201130.11303-1-jsc@umbraculum.org> <20230205201130.11303-2-jsc@umbraculum.org> <5314e0ba3a728787299ca46a60b0a2da5e8ab23a.camel@redhat.com> <135b671b1b76978fb147d5fee1e1b922e2c61f26.camel@redhat.com> <20230207104204.200da48a@kernel.org> <20230313114858.54828dda@kernel.org> Content-Language: fr, en-GB From: Christophe JAILLET In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Le 14/03/2023 à 06:15, Katakam, Harini a écrit : > Hi Jakub, Jonas, > >> -----Original Message----- >> From: Jakub Kicinski >> Sent: Tuesday, March 14, 2023 12:19 AM >> To: Jonas Suhr Christensen ; Katakam, Harini >> >> Cc: Paolo Abeni ; netdev@vger.kernel.org; David S. >> Miller ; Eric Dumazet ; >> Michal Simek ; Haoyue Xu >> ; huangjunxian ; >> Wang Qing ; Yang Yingliang >> ; Esben Haabendal ; >> linux-arm-kernel@lists.infradead.org; linux-kernel@vger.kernel.org >> Subject: Re: [PATCH net v2 1/2] net: ll_temac: Fix DMA resources leak >> >> On Mon, 13 Mar 2023 19:37:00 +0100 Jonas Suhr Christensen wrote: >>> On Tue, Feb 7, 2023, at 19:42, Jakub Kicinski wrote: >>>> On Tue, 07 Feb 2023 12:36:11 +0100 Paolo Abeni wrote: >>>>> You can either try change to phys type to __be32 (likely not >>>>> suitable for -net and possibly can introduce even more warnings >>>>> elsewhere) >>>> >>>> FWIW that seems like the best option to me as well. Let's ignore the >>>> sparse warning for v3 and try to switch phys to __be32 in a separate >>>> patch for net-next. No point adding force casts just to have to >>>> remove them a week later, given how prevalent the problem is. >>>> >>>>> or explicitly cast the argument. >>> >>> I no longer have access to the hardware, so I'm not rewriting the >>> batch. Feel free to take ownership of it and fix what's needed. >> >> Ack. >> >> Harini, are you the designated maintainer for this driver? Could you add a >> MAINTAINERS entry for it? I don't see one right now. >> And possibly pick up these patches / fix the problem, if you have the cycles? > > Sure, Srinivas (cced) will pick up this series and send a v3. > I'll get back on the state of this IP/driver for the maintainers list. Will include > that patch in the beginning of the series as well. > > Regards, > Harini > Hi, this patch, or an updated version, has not reached -next yet. Does someone still working on it, or did it got lost? CJ From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 259D0EB64DA for ; Sat, 8 Jul 2023 13:16:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Y22Z0eb60YbIDycF31PMK4RNjBL7fiCKwnxbu0xbKEw=; b=GC1HjXHfUNZqZc OnuLR/VXDDEiWqPgookOCqljyL3er3Zjmy642MccpDWWmPiasAzVSNWXTVtqb4nR5/dqPxGR9hPcb JJ840DBmOEyBWoFE2G2DAPO1DW4m8s2r/LsUUUxSa0UJi5Sgmk2lJixN+WshQvAmXgldv7r13mVJm WC8Ir2RzA86BpS8u6z8+YvY9P/3shjUw6MlclrVM8/9uCb2oCwWysHTFEvcQcQDjjYc7oeh+ZlwhO zkA+/vT2or1TG/iMnLQlyZRt8r7jtEABr5R4Hn28SYuU6DtAJ4bRep1lbtm2ghSnByLvoMv+xlbqR x78IZMWz5vjroH7SdJMA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qI7nE-007J6y-2w; Sat, 08 Jul 2023 13:16:08 +0000 Received: from smtp-20.smtpout.orange.fr ([80.12.242.20] helo=smtp.smtpout.orange.fr) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qI7nA-007J5x-1j for linux-arm-kernel@lists.infradead.org; Sat, 08 Jul 2023 13:16:06 +0000 Received: from [192.168.1.18] ([86.243.2.178]) by smtp.orange.fr with ESMTPA id I7mwqrPmVn02aI7mwqEG5C; Sat, 08 Jul 2023 15:15:58 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=wanadoo.fr; s=t20230301; t=1688822158; bh=MtFS4H/mvjYBQ6kD2sk3yhpdjTWzlyIwy/D4XqevP4Y=; h=Date:Subject:To:Cc:References:From:In-Reply-To; b=HeBBJKpw7QjGeqAKXjtW9K+A/j1qxIyP4Z1zGSbXu9RowIPmKLtfnvwiQ4OA7fYT+ ynZxJA4onQ2YKhyb2xx+aT2meliqLoHnzUUHi5QZy3USNLU9R9p0vcxkFUeAdvycj7 NvZqTPJS+7tvbnFvywGvWqICUwGihsuOJc5m2FeqkJQdL5mdY1hW20VbH5uiZlYlyV 0Alv1EguSOV8CKnXcxwzuD8C3uFNV5vXWtKm8l93lwbM2U3FJQEQxrWiR3syveFvca 2+5Jt9+YuYoMUgm9iQ6y8Kol3EeLVXZzA1UVQz36sGSJeraBfjmFBNYGehCksSPzlB jCdWdxt20YoTg== X-ME-Helo: [192.168.1.18] X-ME-Auth: Y2hyaXN0b3BoZS5qYWlsbGV0QHdhbmFkb28uZnI= X-ME-Date: Sat, 08 Jul 2023 15:15:58 +0200 X-ME-IP: 86.243.2.178 Message-ID: <19369234-8785-575b-ff24-9a21a9e82f0e@wanadoo.fr> Date: Sat, 8 Jul 2023 15:15:50 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: RE: [PATCH net v2 1/2] net: ll_temac: Fix DMA resources leak To: "Katakam, Harini" , Jakub Kicinski , Jonas Suhr Christensen Cc: Paolo Abeni , "netdev@vger.kernel.org" , "David S. Miller" , Eric Dumazet , Michal Simek , Haoyue Xu , huangjunxian , Wang Qing , Yang Yingliang , Esben Haabendal , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "Neeli, Srinivas" References: <20230205201130.11303-1-jsc@umbraculum.org> <20230205201130.11303-2-jsc@umbraculum.org> <5314e0ba3a728787299ca46a60b0a2da5e8ab23a.camel@redhat.com> <135b671b1b76978fb147d5fee1e1b922e2c61f26.camel@redhat.com> <20230207104204.200da48a@kernel.org> <20230313114858.54828dda@kernel.org> Content-Language: fr, en-GB From: Christophe JAILLET In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230708_061605_009492_55970769 X-CRM114-Status: GOOD ( 18.66 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org TGUgMTQvMDMvMjAyMyDDoCAwNjoxNSwgS2F0YWthbSwgSGFyaW5pIGEgw6ljcml0wqA6Cj4gSGkg SmFrdWIsIEpvbmFzLAo+IAo+PiAtLS0tLU9yaWdpbmFsIE1lc3NhZ2UtLS0tLQo+PiBGcm9tOiBK YWt1YiBLaWNpbnNraSA8a3ViYUBrZXJuZWwub3JnPgo+PiBTZW50OiBUdWVzZGF5LCBNYXJjaCAx NCwgMjAyMyAxMjoxOSBBTQo+PiBUbzogSm9uYXMgU3VociBDaHJpc3RlbnNlbiA8anNjQHVtYnJh Y3VsdW0ub3JnPjsgS2F0YWthbSwgSGFyaW5pCj4+IDxoYXJpbmkua2F0YWthbUBhbWQuY29tPgo+ PiBDYzogUGFvbG8gQWJlbmkgPHBhYmVuaUByZWRoYXQuY29tPjsgbmV0ZGV2QHZnZXIua2VybmVs Lm9yZzsgRGF2aWQgUy4KPj4gTWlsbGVyIDxkYXZlbUBkYXZlbWxvZnQubmV0PjsgRXJpYyBEdW1h emV0IDxlZHVtYXpldEBnb29nbGUuY29tPjsKPj4gTWljaGFsIFNpbWVrIDxtaWNoYWwuc2ltZWtA eGlsaW54LmNvbT47IEhhb3l1ZSBYdQo+PiA8eHVoYW95dWUxQGhpc2lsaWNvbi5jb20+OyBodWFu Z2p1bnhpYW4gPGh1YW5nanVueGlhbjZAaGlzaWxpY29uLmNvbT47Cj4+IFdhbmcgUWluZyA8d2Fu Z3FpbmdAdml2by5jb20+OyBZYW5nIFlpbmdsaWFuZwo+PiA8eWFuZ3lpbmdsaWFuZ0BodWF3ZWku Y29tPjsgRXNiZW4gSGFhYmVuZGFsIDxlc2JlbkBnZWFuaXguY29tPjsKPj4gbGludXgtYXJtLWtl cm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnOyBsaW51eC1rZXJuZWxAdmdlci5rZXJuZWwub3JnCj4+ IFN1YmplY3Q6IFJlOiBbUEFUQ0ggbmV0IHYyIDEvMl0gbmV0OiBsbF90ZW1hYzogRml4IERNQSBy ZXNvdXJjZXMgbGVhawo+Pgo+PiBPbiBNb24sIDEzIE1hciAyMDIzIDE5OjM3OjAwICswMTAwIEpv bmFzIFN1aHIgQ2hyaXN0ZW5zZW4gd3JvdGU6Cj4+PiBPbiBUdWUsIEZlYiA3LCAyMDIzLCBhdCAx OTo0MiwgSmFrdWIgS2ljaW5za2kgd3JvdGU6Cj4+Pj4gT24gVHVlLCAwNyBGZWIgMjAyMyAxMjoz NjoxMSArMDEwMCBQYW9sbyBBYmVuaSB3cm90ZToKPj4+Pj4gWW91IGNhbiBlaXRoZXIgdHJ5IGNo YW5nZSB0byBwaHlzIHR5cGUgdG8gX19iZTMyIChsaWtlbHkgbm90Cj4+Pj4+IHN1aXRhYmxlIGZv ciAtbmV0IGFuZCBwb3NzaWJseSBjYW4gaW50cm9kdWNlIGV2ZW4gbW9yZSB3YXJuaW5ncwo+Pj4+ PiBlbHNld2hlcmUpCj4+Pj4KPj4+PiBGV0lXIHRoYXQgc2VlbXMgbGlrZSB0aGUgYmVzdCBvcHRp b24gdG8gbWUgYXMgd2VsbC4gTGV0J3MgaWdub3JlIHRoZQo+Pj4+IHNwYXJzZSB3YXJuaW5nIGZv ciB2MyBhbmQgdHJ5IHRvIHN3aXRjaCBwaHlzIHRvIF9fYmUzMiBpbiBhIHNlcGFyYXRlCj4+Pj4g cGF0Y2ggZm9yIG5ldC1uZXh0LiBObyBwb2ludCBhZGRpbmcgZm9yY2UgY2FzdHMganVzdCB0byBo YXZlIHRvCj4+Pj4gcmVtb3ZlIHRoZW0gYSB3ZWVrIGxhdGVyLCBnaXZlbiBob3cgcHJldmFsZW50 IHRoZSBwcm9ibGVtIGlzLgo+Pj4+Cj4+Pj4+IG9yIGV4cGxpY2l0bHkgY2FzdCB0aGUgYXJndW1l bnQuCj4+Pgo+Pj4gSSBubyBsb25nZXIgaGF2ZSBhY2Nlc3MgdG8gdGhlIGhhcmR3YXJlLCBzbyBJ J20gbm90IHJld3JpdGluZyB0aGUKPj4+IGJhdGNoLiBGZWVsIGZyZWUgdG8gdGFrZSBvd25lcnNo aXAgb2YgaXQgYW5kIGZpeCB3aGF0J3MgbmVlZGVkLgo+Pgo+PiBBY2suCj4+Cj4+IEhhcmluaSwg YXJlIHlvdSB0aGUgZGVzaWduYXRlZCBtYWludGFpbmVyIGZvciB0aGlzIGRyaXZlcj8gQ291bGQg eW91IGFkZCBhCj4+IE1BSU5UQUlORVJTIGVudHJ5IGZvciBpdD8gSSBkb24ndCBzZWUgb25lIHJp Z2h0IG5vdy4KPj4gQW5kIHBvc3NpYmx5IHBpY2sgdXAgdGhlc2UgcGF0Y2hlcyAvIGZpeCB0aGUg cHJvYmxlbSwgaWYgeW91IGhhdmUgdGhlIGN5Y2xlcz8KPiAKPiBTdXJlLCBTcmluaXZhcyAoY2Nl ZCkgd2lsbCBwaWNrIHVwIHRoaXMgc2VyaWVzIGFuZCBzZW5kIGEgdjMuCj4gSSdsbCBnZXQgYmFj ayBvbiB0aGUgc3RhdGUgb2YgdGhpcyBJUC9kcml2ZXIgZm9yIHRoZSBtYWludGFpbmVycyBsaXN0 LiBXaWxsIGluY2x1ZGUKPiB0aGF0IHBhdGNoIGluIHRoZSBiZWdpbm5pbmcgb2YgdGhlIHNlcmll cyBhcyB3ZWxsLgo+IAo+IFJlZ2FyZHMsCj4gSGFyaW5pCj4gCgpIaSwKCnRoaXMgcGF0Y2gsIG9y IGFuIHVwZGF0ZWQgdmVyc2lvbiwgaGFzIG5vdCByZWFjaGVkIC1uZXh0IHlldC4KCkRvZXMgc29t ZW9uZSBzdGlsbCB3b3JraW5nIG9uIGl0LCBvciBkaWQgaXQgZ290IGxvc3Q/CgpDSgoKX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGludXgtYXJtLWtlcm5l bCBtYWlsaW5nIGxpc3QKbGludXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6 Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtYXJtLWtlcm5lbAo=