All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas@monjalon.net>
To: Bruce Richardson <bruce.richardson@intel.com>
Cc: David Marchand <david.marchand@redhat.com>, dev@dpdk.org
Subject: Re: [PATCH v4] mailmap: add file to DPDK
Date: Thu, 24 Nov 2022 18:21:56 +0100	[thread overview]
Message-ID: <1944587.8hb0ThOEGa@thomas> (raw)
In-Reply-To: <Y3+I09SqYtlfF+NR@bricha3-MOBL.ger.corp.intel.com>

24/11/2022 16:08, Bruce Richardson:
> On Thu, Nov 24, 2022 at 02:57:17PM +0100, Thomas Monjalon wrote:
> > 24/11/2022 14:49, David Marchand:
> > > On Thu, Nov 24, 2022 at 2:43 PM Bruce Richardson
> > > <bruce.richardson@intel.com> wrote:
> > > >
> > > > On Thu, Nov 24, 2022 at 01:13:20PM +0100, David Marchand wrote:
> > > > > From: Bruce Richardson <bruce.richardson@intel.com>
> > > > >
> > > > > Since a number of contributors to DPDK have submitted patches to DPDK
> > > > > under more than one email address, we should maintain a mailmap file to
> > > > > properly track their commits using "shortlog".
> > > > >
> > > > > It also helps fix up any mangled names, for example, with
> > > > > surname/firstname reversed, or with incorrect capitalization.
> > > > > By keeping this file in the DPDK repository, rather than committers
> > > > > maintaining their own copies, it allows individual contributors to edit
> > > > > it to update their own email address preferences if so desired.
> > > > >
> > > > > While at it, update our checkpatches.sh script and add some
> > > > > documentation to help new contributors.
> > > > >
> > > > > Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
> > > > > Signed-off-by: David Marchand <david.marchand@redhat.com>
> > > > > ---
> > > > > Changes since v3:
> > > > > - fixed some issues with non iso characters in names,
> > > > > - added .mailmap to MAINTAINERS,
> > > > > - populated .mailmap with the contributors file Thomas and I maintain,
> > > > > - added a check so that people will stop mangling their own names,
> > > > > - added a note in the contributing guide,
> > > > >
> > > > Do we really want to require all contributors to add their names to the
> > > > mailmap file, it seems excessive to me and onerous on new contributors? I
> > > > would expect the mailmap to be only necessary for tracking mail updates, or
> > > > fixing already-mangled names.
> > > 
> > > As someone who checks those names and fixes some regularly, I prefer
> > > developers check this themselves.
> > 
> > If a new contributor does not edit this file, it can be done while merging.
> > 
> That would be ok, I think. I just don't want to have extra hurdles for new
> contributors to jump through. Thanks for this.

I won't be mandatory and it's very easy.
We'll run the check and will fix it as maintainers.



  reply	other threads:[~2022-11-24 17:22 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-20 13:07 [dpdk-dev] [PATCH] mailmap: add a mailmap file to DPDK Bruce Richardson
2020-10-20 13:22 ` David Marchand
2020-10-20 14:29 ` Thomas Monjalon
2020-10-20 15:03   ` Bruce Richardson
2020-10-20 15:17     ` Thomas Monjalon
2020-10-20 15:32       ` Bruce Richardson
2020-10-20 15:38         ` Thomas Monjalon
2020-10-20 15:44           ` Bruce Richardson
2020-10-21 16:55 ` [dpdk-dev] [PATCH v2] " Bruce Richardson
2022-11-04 12:13 ` [PATCH v3] mailmap: add " Bruce Richardson
2022-11-04 12:16   ` Bruce Richardson
2022-11-24 12:13 ` [PATCH v4] " David Marchand
2022-11-24 13:43   ` Bruce Richardson
2022-11-24 13:49     ` David Marchand
2022-11-24 13:57       ` Thomas Monjalon
2022-11-24 15:08         ` Bruce Richardson
2022-11-24 17:21           ` Thomas Monjalon [this message]
2022-11-24 16:51     ` Stephen Hemminger
2022-11-24 17:19       ` Thomas Monjalon
2022-11-28 17:18         ` Tyler Retzlaff
2022-11-24 15:44 ` [PATCH v5] " David Marchand
2022-11-24 17:21   ` Ferruh Yigit
2022-11-24 17:26     ` Thomas Monjalon
2022-11-24 17:34       ` Ferruh Yigit
2022-11-24 19:42         ` Thomas Monjalon
2022-11-25 14:54 ` [PATCH v6] " David Marchand
2022-11-25 16:08   ` Dumitrescu, Cristian
2022-11-27 10:27     ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1944587.8hb0ThOEGa@thomas \
    --to=thomas@monjalon.net \
    --cc=bruce.richardson@intel.com \
    --cc=david.marchand@redhat.com \
    --cc=dev@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.