From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 32580C47404 for ; Fri, 4 Oct 2019 15:49:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 0363620830 for ; Fri, 4 Oct 2019 15:49:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390139AbfJDPtP (ORCPT ); Fri, 4 Oct 2019 11:49:15 -0400 Received: from mx1.redhat.com ([209.132.183.28]:39612 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2389773AbfJDPtP (ORCPT ); Fri, 4 Oct 2019 11:49:15 -0400 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id C1412306085E; Fri, 4 Oct 2019 15:49:14 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id B611460BF7; Fri, 4 Oct 2019 15:49:14 +0000 (UTC) Received: from zmail21.collab.prod.int.phx2.redhat.com (zmail21.collab.prod.int.phx2.redhat.com [10.5.83.24]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id A99C84E58A; Fri, 4 Oct 2019 15:49:14 +0000 (UTC) Date: Fri, 4 Oct 2019 11:49:14 -0400 (EDT) From: Bob Peterson To: aliasgar surti500 Cc: agruenba@redhat.com, cluster-devel@redhat.com, linux-kernel@vger.kernel.org Message-ID: <1944905967.4863703.1570204154537.JavaMail.zimbra@redhat.com> In-Reply-To: <20191002174631.15919-1-aliasgar.surti500@gmail.com> References: <20191002174631.15919-1-aliasgar.surti500@gmail.com> Subject: Re: [PATCH] gfs2: removed unnecessary semicolon MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Originating-IP: [10.3.116.219, 10.4.195.28] Thread-Topic: gfs2: removed unnecessary semicolon Thread-Index: 5pT+PabUEhpG6HUEs4rjxCBeLgtPVw== X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.40]); Fri, 04 Oct 2019 15:49:14 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org ----- Original Message ----- > From: Aliasgar Surti > > There is use of unnecessary semicolon after switch case. > Removed the semicolon. > > Signed-off-by: Aliasgar Surti > --- > fs/gfs2/recovery.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fs/gfs2/recovery.c b/fs/gfs2/recovery.c > index c529f8749a89..f4aa8551277b 100644 > --- a/fs/gfs2/recovery.c > +++ b/fs/gfs2/recovery.c > @@ -326,7 +326,7 @@ void gfs2_recover_func(struct work_struct *work) > > default: > goto fail; > - }; > + } > > error = gfs2_glock_nq_init(ip->i_gl, LM_ST_SHARED, > LM_FLAG_NOEXP | GL_NOCACHE, &ji_gh); > -- > 2.17.1 Hi, Thanks for the patch. I did a quick search and found two more: glops.c- break; glops.c: }; inode.c- goto out_gunlock; inode.c: }; Do you want to include those in your patch and re-submit it or should I cook up a second patch? Regards, Bob Peterson Red Hat File Systems From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bob Peterson Date: Fri, 4 Oct 2019 11:49:14 -0400 (EDT) Subject: [Cluster-devel] [PATCH] gfs2: removed unnecessary semicolon In-Reply-To: <20191002174631.15919-1-aliasgar.surti500@gmail.com> References: <20191002174631.15919-1-aliasgar.surti500@gmail.com> Message-ID: <1944905967.4863703.1570204154537.JavaMail.zimbra@redhat.com> List-Id: To: cluster-devel.redhat.com MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit ----- Original Message ----- > From: Aliasgar Surti > > There is use of unnecessary semicolon after switch case. > Removed the semicolon. > > Signed-off-by: Aliasgar Surti > --- > fs/gfs2/recovery.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fs/gfs2/recovery.c b/fs/gfs2/recovery.c > index c529f8749a89..f4aa8551277b 100644 > --- a/fs/gfs2/recovery.c > +++ b/fs/gfs2/recovery.c > @@ -326,7 +326,7 @@ void gfs2_recover_func(struct work_struct *work) > > default: > goto fail; > - }; > + } > > error = gfs2_glock_nq_init(ip->i_gl, LM_ST_SHARED, > LM_FLAG_NOEXP | GL_NOCACHE, &ji_gh); > -- > 2.17.1 Hi, Thanks for the patch. I did a quick search and found two more: glops.c- break; glops.c: }; inode.c- goto out_gunlock; inode.c: }; Do you want to include those in your patch and re-submit it or should I cook up a second patch? Regards, Bob Peterson Red Hat File Systems