From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757119AbdAJQQ2 convert rfc822-to-8bit (ORCPT ); Tue, 10 Jan 2017 11:16:28 -0500 Received: from mout.kundenserver.de ([217.72.192.73]:61173 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750726AbdAJQQ0 (ORCPT ); Tue, 10 Jan 2017 11:16:26 -0500 From: Arnd Bergmann To: Ross Zwisler Cc: "Theodore Ts'o" , Alexander Viro , Matthew Wilcox , Jan Kara , Andrew Morton , Dave Chinner , Dan Williams , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] dax: try to avoid unused function warnings Date: Tue, 10 Jan 2017 17:15:57 +0100 Message-ID: <1946137.McqY686LOu@wuerfel> User-Agent: KMail/5.1.3 (Linux/4.4.0-34-generic; KDE/5.18.0; x86_64; ; ) In-Reply-To: <20161128212400.GA16225@linux.intel.com> References: <20161128211233.2446605-1-arnd@arndb.de> <20161128212400.GA16225@linux.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8BIT Content-Type: text/plain; charset="UTF-8" X-Provags-ID: V03:K0:xO9eZMrzxMUgc61bIGHN/GxEAshAMTCjFtrVPASLd9V5wN1Es0f RqF1iWg49L/aN18AeOn4aMIAqxiuT3h7gGUXcVQzUn40Mk91zXG7WvaAaBj5jX/9EG/t47t WI9K0wEjVIP5qcm9IL4O8cHMNY6LuIqv+ppwa5tPpzXX76ivO7AD1dOxDUfamJ/lhlW/kRa m6hdA/NveTTfjcC9KpOcA== X-UI-Out-Filterresults: notjunk:1;V01:K0:FzlBkMSUZv8=:jePnqyA5PLSirRY9I5mw9R BT3rTZ/hZq09KuxKB5eqdpJhxBL3vHSWC1ofO93GLSbc/7t1qOm2rIhbPOuNYrhaNG4JotgIn NwFUInF6vLDN3z7lVaEOp5h+mPKZBGuAhWAgJt6JRfzhdoS22cl0Hvud5AeC8/G68yFrINPPt wBGwYTrhTfIkpb5xTfRLCyPLWxnELkAfCMoIVx9Xs5M0Q/qy5bKfBz46wPkrmchB9EI4TvVfs UhU18H1MB58bhIetA1+EyY9T2THenK29UKq/tDeEK1nunCAeUs92otEHoUqRuhUgcxB/6es1q 519xUlRcB9lydRNcydFt3sMuTMKs9E1EgnJ2czfV/duhSoOAC+TVDz7XVBFzKBeFlirchynPM radtQ5OmKI+ZjX1xh3OH2aRlLFSwDjiT/S4ImY838NWu02vX2K0BoOkt7MLwxcmrB3ZYQ/ot9 W7ZKeXxt1UV/rGjFQpXVJxsK0xcq/XaQYe1QW2jIpxLrYfyYx0T1jWaHKtBM32hXr3MYJg8Lc OV+bDHxOyXHWoPv6LznAQqu9GpcyPKK6pjgF8muJl7bRcp2xtWXB9/cliQtcUitQd8rqcNJLt wxBDv/66g6KZUclsGmwfkL56WkTd8xbNSuYPdkURG3qMjbIy/3GmcxykCy7fGq7qSw4i56mks g0kDBFBMUJ9t64o23RC+Nzsj00MpxbLh34uHdGL0NcKMFiRtUU3ZMFI9tzoKg5rE/fkRAlV8V 2aQtvfYl4JX6kDLz Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Monday, November 28, 2016 2:24:00 PM CET Ross Zwisler wrote: > On Mon, Nov 28, 2016 at 10:12:17PM +0100, Arnd Bergmann wrote: > > Without the get_block based I/O, we get warnings when CONFIG_FS_IOMAP > > is disabled: > > > > fs/dax.c:736:12: error: ‘dax_insert_mapping’ defined but not used [-Werror=unused-function] > > fs/dax.c:512:12: error: ‘copy_user_dax’ defined but not used [-Werror=unused-function] > > fs/dax.c:490:12: error: ‘dax_load_hole’ defined but not used [-Werror=unused-function] > > fs/dax.c:294:14: error: ‘grab_mapping_entry’ defined but not used [-Werror=unused-function] > > > > This patch blindly marks those as __maybe_unused, which avoids the warnings. > > However, I suspect that there is actually more code in this file that should > > not be provided without CONFIG_FS_IOMAP even though we don't get a warning > > for it, and that we actually want a different rework, so please treat this > > as a bug report. I have applied the patch locally in my randconfig build > > setup to avoid seeing the warnings. > > > > Fixes: 5ac65736f740 ("dax: rip out get_block based IO support") > > Signed-off-by: Arnd Bergmann > > Thanks for the report. I think the right way to deal with this is to just > select FS_IOMAP when we pull in the DAX code. I sent out a patch last week > that does this: > > https://lkml.org/lkml/2016/11/23/591 It seems we never got agreement on the approach, and we still get the warnings above in v4.10. Should we use my patch to fix up 4.10 and get a clean build again? It no longer applies, but I have a rebased version that I can send. Arnd