From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756501AbcHYP1P (ORCPT ); Thu, 25 Aug 2016 11:27:15 -0400 Received: from mail-pa0-f66.google.com ([209.85.220.66]:36374 "EHLO mail-pa0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757032AbcHYP1K (ORCPT ); Thu, 25 Aug 2016 11:27:10 -0400 Subject: Re: [PATCH v3] clk: let clk_disable() return immediately if clk is NULL To: Masahiro Yamada , linux-clk@vger.kernel.org References: <1472059613-30551-1-git-send-email-yamada.masahiro@socionext.com> Cc: Stephen Boyd , Ralf Baechle , Michael Turquette , linux-mips@linux-mips.org, Haojian Zhuang , Eric Miao , linux-kernel@vger.kernel.org, adi-buildroot-devel@lists.sourceforge.net, Greg Ungerer , linux-m68k@vger.kernel.org, bcm-kernel-feedback-list@broadcom.com, Wan ZongShun , Geert Uytterhoeven , Steven Miao , Russell King , linux-arm-kernel@lists.infradead.org From: Florian Fainelli Message-ID: <194aebe5-38dd-f43d-fb4d-16ce592a68e8@gmail.com> Date: Thu, 25 Aug 2016 08:27:07 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <1472059613-30551-1-git-send-email-yamada.masahiro@socionext.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 08/24/2016 10:26 AM, Masahiro Yamada wrote: > Many of clk_disable() implementations just return for NULL pointer, > but this check is missing from some. Let's make it tree-wide > consistent. It will allow clock consumers to call clk_disable() > without NULL pointer check. > > Signed-off-by: Masahiro Yamada > Acked-by: Greg Ungerer > Acked-by: Wan Zongshun > --- > > I came back after a long pause. > You can see the discussion about the previous version: > https://www.linux-mips.org/archives/linux-mips/2016-04/msg00063.html > > > Changes in v3: > - Return only when clk is NULL. Do not take care of error pointer. > > Changes in v2: > - Rebase on Linux 4.6-rc1 > > arch/arm/mach-mmp/clock.c | 3 +++ > arch/arm/mach-w90x900/clock.c | 3 +++ > arch/blackfin/mach-bf609/clock.c | 3 +++ > arch/m68k/coldfire/clk.c | 4 ++++ > arch/mips/bcm63xx/clk.c | 3 +++ For bcm63xx: Acked-by: Florian Fainelli -- Florian From mboxrd@z Thu Jan 1 00:00:00 1970 From: Florian Fainelli Subject: Re: [PATCH v3] clk: let clk_disable() return immediately if clk is NULL Date: Thu, 25 Aug 2016 08:27:07 -0700 Message-ID: <194aebe5-38dd-f43d-fb4d-16ce592a68e8@gmail.com> References: <1472059613-30551-1-git-send-email-yamada.masahiro@socionext.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1472059613-30551-1-git-send-email-yamada.masahiro@socionext.com> Sender: linux-m68k-owner@vger.kernel.org List-Id: linux-m68k@vger.kernel.org To: Masahiro Yamada , linux-clk@vger.kernel.org Cc: Stephen Boyd , Ralf Baechle , Michael Turquette , linux-mips@linux-mips.org, Haojian Zhuang , Eric Miao , linux-kernel@vger.kernel.org, adi-buildroot-devel@lists.sourceforge.net, Greg Ungerer , linux-m68k@lists.linux-m68k.org, bcm-kernel-feedback-list@broadcom.com, Wan ZongShun , Geert Uytterhoeven , Steven Miao , Russell King , linux-arm-kernel@lists.infradead.org On 08/24/2016 10:26 AM, Masahiro Yamada wrote: > Many of clk_disable() implementations just return for NULL pointer, > but this check is missing from some. Let's make it tree-wide > consistent. It will allow clock consumers to call clk_disable() > without NULL pointer check. > > Signed-off-by: Masahiro Yamada > Acked-by: Greg Ungerer > Acked-by: Wan Zongshun > --- > > I came back after a long pause. > You can see the discussion about the previous version: > https://www.linux-mips.org/archives/linux-mips/2016-04/msg00063.html > > > Changes in v3: > - Return only when clk is NULL. Do not take care of error pointer. > > Changes in v2: > - Rebase on Linux 4.6-rc1 > > arch/arm/mach-mmp/clock.c | 3 +++ > arch/arm/mach-w90x900/clock.c | 3 +++ > arch/blackfin/mach-bf609/clock.c | 3 +++ > arch/m68k/coldfire/clk.c | 4 ++++ > arch/mips/bcm63xx/clk.c | 3 +++ For bcm63xx: Acked-by: Florian Fainelli -- Florian From mboxrd@z Thu Jan 1 00:00:00 1970 From: f.fainelli@gmail.com (Florian Fainelli) Date: Thu, 25 Aug 2016 08:27:07 -0700 Subject: [PATCH v3] clk: let clk_disable() return immediately if clk is NULL In-Reply-To: <1472059613-30551-1-git-send-email-yamada.masahiro@socionext.com> References: <1472059613-30551-1-git-send-email-yamada.masahiro@socionext.com> Message-ID: <194aebe5-38dd-f43d-fb4d-16ce592a68e8@gmail.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 08/24/2016 10:26 AM, Masahiro Yamada wrote: > Many of clk_disable() implementations just return for NULL pointer, > but this check is missing from some. Let's make it tree-wide > consistent. It will allow clock consumers to call clk_disable() > without NULL pointer check. > > Signed-off-by: Masahiro Yamada > Acked-by: Greg Ungerer > Acked-by: Wan Zongshun > --- > > I came back after a long pause. > You can see the discussion about the previous version: > https://www.linux-mips.org/archives/linux-mips/2016-04/msg00063.html > > > Changes in v3: > - Return only when clk is NULL. Do not take care of error pointer. > > Changes in v2: > - Rebase on Linux 4.6-rc1 > > arch/arm/mach-mmp/clock.c | 3 +++ > arch/arm/mach-w90x900/clock.c | 3 +++ > arch/blackfin/mach-bf609/clock.c | 3 +++ > arch/m68k/coldfire/clk.c | 4 ++++ > arch/mips/bcm63xx/clk.c | 3 +++ For bcm63xx: Acked-by: Florian Fainelli -- Florian