From mboxrd@z Thu Jan  1 00:00:00 1970
From: Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [RFC PATCH 0/4] Add support for EPT execute only for nested
 hypervisors
Date: Fri, 24 Jun 2016 00:22:52 -0400 (EDT)
Message-ID: <1951526417.1647454.1466742172232.JavaMail.zimbra@redhat.com>
References: <1466478746-14153-1-git-send-email-bsd@redhat.com> <576A169B.5090608@linux.intel.com> <jpglh1xw5ap.fsf@linux.bootlegged.copy> <576B6D9F.9020806@linux.intel.com> <jpg8txv47mh.fsf@linux.bootlegged.copy>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Cc: Xiao Guangrong <guangrong.xiao@linux.intel.com>,
	kvm@vger.kernel.org
To: Bandan Das <bsd@redhat.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx3-phx2.redhat.com ([209.132.183.24]:55405 "EHLO
	mx3-phx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1750891AbcFXEW6 (ORCPT <rfc822;kvm@vger.kernel.org>);
	Fri, 24 Jun 2016 00:22:58 -0400
In-Reply-To: <jpg8txv47mh.fsf@linux.bootlegged.copy>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>


> I am tempted to remove the FNAME version altogether and change
> is_present_gpte()
> to return (pte & PT_PRESENT_MASK) || (shadow_xonly_valid && (pte & 4)). This
> will take care of all cases. Hope I am not missing something :)

Please rename the non-FNAME version to pae_is_present_pdpte or just inline
it in the two callers.

Paolo