From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Jackson Subject: Re: [PATCH] Introduce dom0-min-space configuration option Date: Tue, 13 Jul 2010 19:02:13 +0100 Message-ID: <19516.43557.723062.885082@mariner.uk.xensource.com> References: <4C3B59FE.2060201@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <4C3B59FE.2060201@redhat.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Michal Novotny Cc: "'xen-devel@lists.xensource.com'" List-Id: xen-devel@lists.xenproject.org Michal Novotny writes ("[Xen-devel] [PATCH] Introduce dom0-min-space configuration option"): > This is the patch to introduce configuration option called > dom0-min-space since there were some issues with data inflation > because of invalid input data stream for zlib decompression. > The issue occured because of insufficient free space on the dom0 so > this patch checks the free available space for /var/lib/xen > and refuses to start up any guests when the space is below > specified value. Setting up the value to 0 disables the check > which preserves the behaviour before this patch applied and > this is the default value for this option. Thanks for the patch, but I'm not sure I entirely follow. What "issues with data inflation because of invalid input data stream for zlib decompression" were there and how do they relate to lack of space on /var/lib/xen ? Is this just for the situation where the dom0 filesystem hasn't enough space to contain the uncompressed version of the domU kernel and initrd which are to be loaded ? Your patch just raises an error. Why does the situation in which the patch is needed not already raise an appropriate error ? Perhaps it would be better to arrange that it does. Ian.