All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paul Eggleton <paul.eggleton@linux.intel.com>
To: "Aníbal Limón" <anibal.limon@linux.intel.com>
Cc: yocto@yoctoproject.org
Subject: Re: [PATCH 10/10][auh] upgradehelper: Add support for generate buildhistory recipe diff's
Date: Fri, 31 Jul 2015 16:29:41 +0100	[thread overview]
Message-ID: <1954435.FDO7q63aNY@peggleto-mobl.ger.corp.intel.com> (raw)
In-Reply-To: <1438203053-7909-11-git-send-email-anibal.limon@linux.intel.com>

Hi Aníbal,

On Wednesday 29 July 2015 15:50:53 Aníbal Limón wrote:
> Now AUH generates buildhistory diff when recipe was upgraded
> successfully.
> 
> For enable this feature set into local.conf.
> 
> 	INHERIT += "buildhistory"
> 	BUILDHISTORY_COMMIT = "1"
> 
> Summary of the changes,
> 
> 	- bitbake.py: Enable environment generation without recipe,
>           removes Buildhistory class.
> 	- buildhistory.py: Add buildhistory class that generates initial
>           buildhistory revision and keeps track of build revisions for
>           generate diff when build is successful.
>         - upgradehelper.py: Add buildhistory steps for upgrade, add
>           support for detect when buildhistory is enabled loading the
>           environment without recipe.

So this looks OK, but I can't tell if it ensures you get the difference between 
successful builds rather than the difference to the last build - we need to 
ensure that a failed build of a recipe in between isn't considered as part of 
the comparison. In practice I guess this would mean storing the buildhistory 
revision of the last successful build for each recipe.

Cheers,
Paul

-- 

Paul Eggleton
Intel Open Source Technology Centre


  reply	other threads:[~2015-07-31 15:29 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-29 20:50 [PATCH 00/10][auh] Add support for buildhistory and minor fixes Aníbal Limón
2015-07-29 20:50 ` [PATCH 01/10][auh] upgradehelper.py: Only run with one recipe or all Aníbal Limón
2015-07-31 13:48   ` Paul Eggleton
2015-07-29 20:50 ` [PATCH 02/10][auh] upgradehelper.py: Validate if upgrade is needed Aníbal Limón
2015-07-29 20:50 ` [PATCH 03/10][auh] upgradehelper.py: Only send emails when patch file exist Aníbal Limón
2015-07-29 20:50 ` [PATCH 04/10][auh] bitbake.py: Improve performance on env() call Aníbal Limón
2015-07-29 20:50 ` [PATCH 05/10][auh] upgradehelper.py: Add own step for loading environment Aníbal Limón
2015-07-31 13:48   ` Paul Eggleton
2015-07-29 20:50 ` [PATCH 06/10][auh] upgradehelper.py: UniverseUpdate don't abort if recipe checkpkg fails Aníbal Limón
2015-07-29 20:50 ` [PATCH 07/10][auh] bitbake.py: Rename bitbake_log.txt to bitbake_error_log Aníbal Limón
2015-07-29 20:50 ` [PATCH 08/10][auh] upgradehelper.py: Remove unused references to Buildhistory class Aníbal Limón
2015-07-29 20:50 ` [PATCH 09/10][auh] upgradehelper.py: Move upstream versioning code to UniverseUpdater Aníbal Limón
2015-07-29 20:50 ` [PATCH 10/10][auh] upgradehelper: Add support for generate buildhistory recipe diff's Aníbal Limón
2015-07-31 15:29   ` Paul Eggleton [this message]
2015-07-31 15:39     ` Aníbal Limón
2015-07-31 16:10       ` Paul Eggleton
2015-07-31 16:19         ` Aníbal Limón
2015-07-31 16:21           ` Paul Eggleton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1954435.FDO7q63aNY@peggleto-mobl.ger.corp.intel.com \
    --to=paul.eggleton@linux.intel.com \
    --cc=anibal.limon@linux.intel.com \
    --cc=yocto@yoctoproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.