All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Marc-André Lureau" <mlureau@redhat.com>
To: Prerna Saxena <prerna.saxena@nutanix.com>
Cc: Fam Zheng <famz@redhat.com>,
	"Michael S. Tsirkin" <mst@redhat.com>,
	qemu-devel@nongnu.org, Peter Maydell <peter.maydell@linaro.org>,
	marcandre lureau <marcandre.lureau@redhat.com>
Subject: Re: [Qemu-devel] [PULL 3/3] vhost-user: Attempt to fix a race with set_mem_table.
Date: Fri, 12 Aug 2016 03:20:56 -0400 (EDT)	[thread overview]
Message-ID: <1956404709.2011431.1470986456062.JavaMail.zimbra@redhat.com> (raw)
In-Reply-To: <D0BB11C2-AA9A-4AC8-80CF-9927DF67834F@nutanix.com>

Hi

----- Original Message -----
> sent a follow-up response to GET_FEATURES), I am now wondering if this patch
> may break existing vhost applications too ? If so, reverting it possibly
> better.
> What confuses me is why it doesn’t fail all the time, but only about 20% to
> 30% time as Fam reports.
> 
> Thoughts : Michael, Fam, MarcAndre ?

Indeed, I didn't ack that patch in the first place for that kind of reasons, so I would revert it.

thanks

  reply	other threads:[~2016-08-12 15:03 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-10 15:30 [Qemu-devel] [PULL 0/3] virtio/vhost: fixes Michael S. Tsirkin
2016-08-10 15:30 ` [Qemu-devel] [PULL 1/3] vhost: check for vhost_ops before using Michael S. Tsirkin
2016-08-10 15:30 ` [Qemu-devel] [PULL 2/3] vhost-user: Introduce a new protocol feature REPLY_ACK Michael S. Tsirkin
2016-08-10 15:30 ` [Qemu-devel] [PULL 3/3] vhost-user: Attempt to fix a race with set_mem_table Michael S. Tsirkin
2016-08-12  6:38   ` Fam Zheng
2016-08-12  7:16     ` Prerna Saxena
2016-08-12  7:20       ` Marc-André Lureau [this message]
2016-08-12 12:01         ` Peter Maydell
2016-08-12 15:49           ` Michael S. Tsirkin
2016-08-15 10:20             ` Peter Maydell
2016-08-12 15:47         ` Michael S. Tsirkin
2016-08-12 15:54           ` Marc-André Lureau
2016-08-12 21:12             ` Michael S. Tsirkin
2016-08-13  6:13               ` Marc-André Lureau
2016-08-14  2:30                 ` Michael S. Tsirkin
2016-08-14  2:44                 ` Michael S. Tsirkin
2016-08-14  2:51       ` Michael S. Tsirkin
2016-08-14  9:42         ` Prerna Saxena
2016-08-14 21:39           ` Michael S. Tsirkin
2016-08-31 11:19           ` Maxime Coquelin
2016-09-01 13:46             ` Michael S. Tsirkin
2016-09-02  8:57               ` Maxime Coquelin
2016-09-02 17:29                 ` Michael S. Tsirkin
2016-09-05 13:06                   ` Maxime Coquelin
2016-09-06  2:22                     ` Michael S. Tsirkin
2016-08-10 17:32 ` [Qemu-devel] [PULL 0/3] virtio/vhost: fixes Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1956404709.2011431.1470986456062.JavaMail.zimbra@redhat.com \
    --to=mlureau@redhat.com \
    --cc=famz@redhat.com \
    --cc=marcandre.lureau@redhat.com \
    --cc=mst@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=prerna.saxena@nutanix.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.