From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Jackson <Ian.Jackson@eu.citrix.com>
Subject: RE: [PATCH] Fix hvm vcpu hotplug bug
Date: Tue, 24 Aug 2010 15:19:23 +0100
Message-ID: <19571.54507.780108.421366@mariner.uk.xensource.com>
References: <BC00F5384FCFC9499AF06F92E8B78A9E0B0007FD20@shsmsx502.ccr.corp.intel.com>
	<19554.43920.11785.97567@mariner.uk.xensource.com>
	<BC00F5384FCFC9499AF06F92E8B78A9E164C8CB703@shsmsx502.ccr.corp.intel.com>
	<19563.58860.249044.209893@mariner.uk.xensource.com>
	<BC00F5384FCFC9499AF06F92E8B78A9E165097298D@shsmsx502.ccr.corp.intel.com>
	<19565.17092.616097.195948@mariner.uk.xensource.com>
	<BC00F5384FCFC9499AF06F92E8B78A9E16509730BB@shsmsx502.ccr.corp.intel.com>
	<19566.33227.5055.515834@mariner.uk.xensource.com>
	<BC00F5384FCFC9499AF06F92E8B78A9E18373CEDBE@shsmsx502.ccr.corp.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xensource.com>
In-Reply-To: <BC00F5384FCFC9499AF06F92E8B78A9E18373CEDBE@shsmsx502.ccr.corp.intel.com>
List-Unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: "Liu, Jinsong" <jinsong.liu@intel.com>
Cc: Keir Fraser <Keir.Fraser@eu.citrix.com>, "Jiang,
	Yunhong" <yunhong.jiang@intel.com>, Ian Jackson <Ian.Jackson@eu.citrix.com>, "xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>, "Li, Xin" <xin.li@intel.com>
List-Id: xen-devel@lists.xenproject.org

Liu, Jinsong writes ("RE: [Xen-devel] [PATCH] Fix hvm vcpu hotplug bug"):
> Ian Jackson wrote:
> > Liu, Jinsong writes ("RE: [Xen-devel] [PATCH] Fix hvm vcpu hotplug bug"): 
> >> [linux/drivers/acpi/acpica/ will:]
> >> 1). clear pge_en x by writing '0' to the bit;
> >> 2). asynchronic call control method;
> >> 3). clear gpe_sts x by writing '1' to the bit;
> >> 4). re-enable gpe_en x by writing '1' to the bit;
> > 
> > So the code in qemu should never clear gpe_sts itself.
> 
> No, that's just what qemu should do, to simulate hardware behavior.

Obviously I still haven't understood.  If the guest kernel driver is
supposed to clear this bit as you seem to say above, then it should
not be cleared automatically by qemu-dm as part of the hotplug
notification.

Obviously the register ought to be emulated by qemu and the bit ought
to be cleared in qemu when the kernel driver writes an inactive value
to it.

None of this seems to be implemented in qemu right now AFAICT ?

Ian.