From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0AC4AC433F5 for ; Sat, 16 Apr 2022 06:48:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229821AbiDPGut (ORCPT ); Sat, 16 Apr 2022 02:50:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49102 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229551AbiDPGuq (ORCPT ); Sat, 16 Apr 2022 02:50:46 -0400 Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C4DBCFA221; Fri, 15 Apr 2022 23:48:14 -0700 (PDT) Received: from canpemm500002.china.huawei.com (unknown [172.30.72.56]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4KgNzm6KRZzfYnt; Sat, 16 Apr 2022 14:47:32 +0800 (CST) Received: from [10.174.177.76] (10.174.177.76) by canpemm500002.china.huawei.com (7.192.104.244) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Sat, 16 Apr 2022 14:48:10 +0800 Subject: Re: [PATCH v10 03/14] mm/vmscan.c: refactor shrink_node() To: Yu Zhao , Stephen Rothwell , CC: Andi Kleen , Andrew Morton , Aneesh Kumar , Barry Song <21cnbao@gmail.com>, Catalin Marinas , Dave Hansen , Hillf Danton , Jens Axboe , Jesse Barnes , Johannes Weiner , Jonathan Corbet , Linus Torvalds , Matthew Wilcox , Mel Gorman , Michael Larabel , Michal Hocko , Mike Rapoport , Rik van Riel , Vlastimil Babka , Will Deacon , Ying Huang , , , , , , Barry Song , Brian Geffon , Jan Alexander Steffens , Oleksandr Natalenko , Steven Barrett , Suleiman Souhlal , Daniel Byrne , Donald Carr , =?UTF-8?Q?Holger_Hoffst=c3=a4tte?= , Konstantin Kharlamov , Shuang Zhai , Sofia Trinh , Vaibhav Jain References: <20220407031525.2368067-1-yuzhao@google.com> <20220407031525.2368067-4-yuzhao@google.com> From: Miaohe Lin Message-ID: <195d4677-e033-e124-144c-9ede270b4f70@huawei.com> Date: Sat, 16 Apr 2022 14:48:10 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: <20220407031525.2368067-4-yuzhao@google.com> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 8bit X-Originating-IP: [10.174.177.76] X-ClientProxiedBy: dggems703-chm.china.huawei.com (10.3.19.180) To canpemm500002.china.huawei.com (7.192.104.244) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2022/4/7 11:15, Yu Zhao wrote: > This patch refactors shrink_node() to improve readability for the > upcoming changes to mm/vmscan.c. > > Signed-off-by: Yu Zhao > Reviewed-by: Barry Song > Acked-by: Brian Geffon > Acked-by: Jan Alexander Steffens (heftig) > Acked-by: Oleksandr Natalenko > Acked-by: Steven Barrett > Acked-by: Suleiman Souhlal > Tested-by: Daniel Byrne > Tested-by: Donald Carr > Tested-by: Holger Hoffstätte > Tested-by: Konstantin Kharlamov > Tested-by: Shuang Zhai > Tested-by: Sofia Trinh > Tested-by: Vaibhav Jain > --- > mm/vmscan.c | 198 +++++++++++++++++++++++++++------------------------- > 1 file changed, 104 insertions(+), 94 deletions(-) > Looks good to me. Thanks! Reviewed-by: Miaohe Lin > diff --git a/mm/vmscan.c b/mm/vmscan.c > index 1678802e03e7..2232cb55af41 100644 > --- a/mm/vmscan.c > +++ b/mm/vmscan.c > @@ -2644,6 +2644,109 @@ enum scan_balance { > SCAN_FILE, > }; > > +static void prepare_scan_count(pg_data_t *pgdat, struct scan_control *sc) > +{ > + unsigned long file; > + struct lruvec *target_lruvec; > + > + target_lruvec = mem_cgroup_lruvec(sc->target_mem_cgroup, pgdat); > + > + /* > + * Flush the memory cgroup stats, so that we read accurate per-memcg > + * lruvec stats for heuristics. > + */ > + mem_cgroup_flush_stats(); > + > + /* > + * Determine the scan balance between anon and file LRUs. > + */ > + spin_lock_irq(&target_lruvec->lru_lock); > + sc->anon_cost = target_lruvec->anon_cost; > + sc->file_cost = target_lruvec->file_cost; > + spin_unlock_irq(&target_lruvec->lru_lock); > + > + /* > + * Target desirable inactive:active list ratios for the anon > + * and file LRU lists. > + */ > + if (!sc->force_deactivate) { > + unsigned long refaults; > + > + refaults = lruvec_page_state(target_lruvec, > + WORKINGSET_ACTIVATE_ANON); > + if (refaults != target_lruvec->refaults[0] || > + inactive_is_low(target_lruvec, LRU_INACTIVE_ANON)) > + sc->may_deactivate |= DEACTIVATE_ANON; > + else > + sc->may_deactivate &= ~DEACTIVATE_ANON; > + > + /* > + * When refaults are being observed, it means a new > + * workingset is being established. Deactivate to get > + * rid of any stale active pages quickly. > + */ > + refaults = lruvec_page_state(target_lruvec, > + WORKINGSET_ACTIVATE_FILE); > + if (refaults != target_lruvec->refaults[1] || > + inactive_is_low(target_lruvec, LRU_INACTIVE_FILE)) > + sc->may_deactivate |= DEACTIVATE_FILE; > + else > + sc->may_deactivate &= ~DEACTIVATE_FILE; > + } else > + sc->may_deactivate = DEACTIVATE_ANON | DEACTIVATE_FILE; > + > + /* > + * If we have plenty of inactive file pages that aren't > + * thrashing, try to reclaim those first before touching > + * anonymous pages. > + */ > + file = lruvec_page_state(target_lruvec, NR_INACTIVE_FILE); > + if (file >> sc->priority && !(sc->may_deactivate & DEACTIVATE_FILE)) > + sc->cache_trim_mode = 1; > + else > + sc->cache_trim_mode = 0; > + > + /* > + * Prevent the reclaimer from falling into the cache trap: as > + * cache pages start out inactive, every cache fault will tip > + * the scan balance towards the file LRU. And as the file LRU > + * shrinks, so does the window for rotation from references. > + * This means we have a runaway feedback loop where a tiny > + * thrashing file LRU becomes infinitely more attractive than > + * anon pages. Try to detect this based on file LRU size. > + */ > + if (!cgroup_reclaim(sc)) { > + unsigned long total_high_wmark = 0; > + unsigned long free, anon; > + int z; > + > + free = sum_zone_node_page_state(pgdat->node_id, NR_FREE_PAGES); > + file = node_page_state(pgdat, NR_ACTIVE_FILE) + > + node_page_state(pgdat, NR_INACTIVE_FILE); > + > + for (z = 0; z < MAX_NR_ZONES; z++) { > + struct zone *zone = &pgdat->node_zones[z]; > + > + if (!managed_zone(zone)) > + continue; > + > + total_high_wmark += high_wmark_pages(zone); > + } > + > + /* > + * Consider anon: if that's low too, this isn't a > + * runaway file reclaim problem, but rather just > + * extreme pressure. Reclaim as per usual then. > + */ > + anon = node_page_state(pgdat, NR_INACTIVE_ANON); > + > + sc->file_is_tiny = > + file + free <= total_high_wmark && > + !(sc->may_deactivate & DEACTIVATE_ANON) && > + anon >> sc->priority; > + } > +} > + > /* > * Determine how aggressively the anon and file LRU lists should be > * scanned. The relative value of each set of LRU lists is determined > @@ -3114,109 +3217,16 @@ static void shrink_node(pg_data_t *pgdat, struct scan_control *sc) > unsigned long nr_reclaimed, nr_scanned; > struct lruvec *target_lruvec; > bool reclaimable = false; > - unsigned long file; > > target_lruvec = mem_cgroup_lruvec(sc->target_mem_cgroup, pgdat); > > again: > - /* > - * Flush the memory cgroup stats, so that we read accurate per-memcg > - * lruvec stats for heuristics. > - */ > - mem_cgroup_flush_stats(); > - > memset(&sc->nr, 0, sizeof(sc->nr)); > > nr_reclaimed = sc->nr_reclaimed; > nr_scanned = sc->nr_scanned; > > - /* > - * Determine the scan balance between anon and file LRUs. > - */ > - spin_lock_irq(&target_lruvec->lru_lock); > - sc->anon_cost = target_lruvec->anon_cost; > - sc->file_cost = target_lruvec->file_cost; > - spin_unlock_irq(&target_lruvec->lru_lock); > - > - /* > - * Target desirable inactive:active list ratios for the anon > - * and file LRU lists. > - */ > - if (!sc->force_deactivate) { > - unsigned long refaults; > - > - refaults = lruvec_page_state(target_lruvec, > - WORKINGSET_ACTIVATE_ANON); > - if (refaults != target_lruvec->refaults[0] || > - inactive_is_low(target_lruvec, LRU_INACTIVE_ANON)) > - sc->may_deactivate |= DEACTIVATE_ANON; > - else > - sc->may_deactivate &= ~DEACTIVATE_ANON; > - > - /* > - * When refaults are being observed, it means a new > - * workingset is being established. Deactivate to get > - * rid of any stale active pages quickly. > - */ > - refaults = lruvec_page_state(target_lruvec, > - WORKINGSET_ACTIVATE_FILE); > - if (refaults != target_lruvec->refaults[1] || > - inactive_is_low(target_lruvec, LRU_INACTIVE_FILE)) > - sc->may_deactivate |= DEACTIVATE_FILE; > - else > - sc->may_deactivate &= ~DEACTIVATE_FILE; > - } else > - sc->may_deactivate = DEACTIVATE_ANON | DEACTIVATE_FILE; > - > - /* > - * If we have plenty of inactive file pages that aren't > - * thrashing, try to reclaim those first before touching > - * anonymous pages. > - */ > - file = lruvec_page_state(target_lruvec, NR_INACTIVE_FILE); > - if (file >> sc->priority && !(sc->may_deactivate & DEACTIVATE_FILE)) > - sc->cache_trim_mode = 1; > - else > - sc->cache_trim_mode = 0; > - > - /* > - * Prevent the reclaimer from falling into the cache trap: as > - * cache pages start out inactive, every cache fault will tip > - * the scan balance towards the file LRU. And as the file LRU > - * shrinks, so does the window for rotation from references. > - * This means we have a runaway feedback loop where a tiny > - * thrashing file LRU becomes infinitely more attractive than > - * anon pages. Try to detect this based on file LRU size. > - */ > - if (!cgroup_reclaim(sc)) { > - unsigned long total_high_wmark = 0; > - unsigned long free, anon; > - int z; > - > - free = sum_zone_node_page_state(pgdat->node_id, NR_FREE_PAGES); > - file = node_page_state(pgdat, NR_ACTIVE_FILE) + > - node_page_state(pgdat, NR_INACTIVE_FILE); > - > - for (z = 0; z < MAX_NR_ZONES; z++) { > - struct zone *zone = &pgdat->node_zones[z]; > - if (!managed_zone(zone)) > - continue; > - > - total_high_wmark += high_wmark_pages(zone); > - } > - > - /* > - * Consider anon: if that's low too, this isn't a > - * runaway file reclaim problem, but rather just > - * extreme pressure. Reclaim as per usual then. > - */ > - anon = node_page_state(pgdat, NR_INACTIVE_ANON); > - > - sc->file_is_tiny = > - file + free <= total_high_wmark && > - !(sc->may_deactivate & DEACTIVATE_ANON) && > - anon >> sc->priority; > - } > + prepare_scan_count(pgdat, sc); > > shrink_node_memcgs(pgdat, sc); > > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8EE73C433F5 for ; Sat, 16 Apr 2022 06:49:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:From:References:CC:To:Subject:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=ZcYbpwJe6aOftWwob0ubJ8Q7zVof/2yWr+UzF/dyRTQ=; b=r02PKQ27Tj4ws36qylzKksdkS4 APeUblLDwt4CIYUT1NAclD9F9MR0D9Vi7pVz5TF1meh/SCumMGOgPQhCJGWINFFT+Q3wP08HusKXB 96mBksggUQ+9UKH5C9e3iCEvY6ODH7+iWa6wGLUuyLaCmLVCV4SMr8tfWHhwaWEbOw7Dbdr6WXCr6 hk4FSsmd5FUGEIdYZabXE59jvdew1heZ+3L/34ZHDlPibQs/aFHyPebO5vByzgprU6ln3UZzwkNzH V0M7n1FFkNCzOfRcRIMFOnGAx3QQz5MLCthIK3rrtoNvFOGtROhhNOi5jOMFT8YSnzagQxafnP7DL MWBvsqkQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nfcEK-00CNdq-SW; Sat, 16 Apr 2022 06:48:24 +0000 Received: from szxga01-in.huawei.com ([45.249.212.187]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nfcEF-00CNbt-K5 for linux-arm-kernel@lists.infradead.org; Sat, 16 Apr 2022 06:48:22 +0000 Received: from canpemm500002.china.huawei.com (unknown [172.30.72.56]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4KgNzm6KRZzfYnt; Sat, 16 Apr 2022 14:47:32 +0800 (CST) Received: from [10.174.177.76] (10.174.177.76) by canpemm500002.china.huawei.com (7.192.104.244) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Sat, 16 Apr 2022 14:48:10 +0800 Subject: Re: [PATCH v10 03/14] mm/vmscan.c: refactor shrink_node() To: Yu Zhao , Stephen Rothwell , CC: Andi Kleen , Andrew Morton , Aneesh Kumar , Barry Song <21cnbao@gmail.com>, Catalin Marinas , Dave Hansen , Hillf Danton , Jens Axboe , Jesse Barnes , Johannes Weiner , Jonathan Corbet , Linus Torvalds , Matthew Wilcox , Mel Gorman , Michael Larabel , Michal Hocko , Mike Rapoport , Rik van Riel , Vlastimil Babka , Will Deacon , Ying Huang , , , , , , Barry Song , Brian Geffon , Jan Alexander Steffens , Oleksandr Natalenko , Steven Barrett , Suleiman Souhlal , Daniel Byrne , Donald Carr , =?UTF-8?Q?Holger_Hoffst=c3=a4tte?= , Konstantin Kharlamov , Shuang Zhai , Sofia Trinh , Vaibhav Jain References: <20220407031525.2368067-1-yuzhao@google.com> <20220407031525.2368067-4-yuzhao@google.com> From: Miaohe Lin Message-ID: <195d4677-e033-e124-144c-9ede270b4f70@huawei.com> Date: Sat, 16 Apr 2022 14:48:10 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: <20220407031525.2368067-4-yuzhao@google.com> Content-Language: en-US X-Originating-IP: [10.174.177.76] X-ClientProxiedBy: dggems703-chm.china.huawei.com (10.3.19.180) To canpemm500002.china.huawei.com (7.192.104.244) X-CFilter-Loop: Reflected X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220415_234820_082365_75E4AA8F X-CRM114-Status: GOOD ( 28.81 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gMjAyMi80LzcgMTE6MTUsIFl1IFpoYW8gd3JvdGU6Cj4gVGhpcyBwYXRjaCByZWZhY3RvcnMg c2hyaW5rX25vZGUoKSB0byBpbXByb3ZlIHJlYWRhYmlsaXR5IGZvciB0aGUKPiB1cGNvbWluZyBj aGFuZ2VzIHRvIG1tL3Ztc2Nhbi5jLgo+IAo+IFNpZ25lZC1vZmYtYnk6IFl1IFpoYW8gPHl1emhh b0Bnb29nbGUuY29tPgo+IFJldmlld2VkLWJ5OiBCYXJyeSBTb25nIDxiYW9odWFAa2VybmVsLm9y Zz4KPiBBY2tlZC1ieTogQnJpYW4gR2VmZm9uIDxiZ2VmZm9uQGdvb2dsZS5jb20+Cj4gQWNrZWQt Ynk6IEphbiBBbGV4YW5kZXIgU3RlZmZlbnMgKGhlZnRpZykgPGhlZnRpZ0BhcmNobGludXgub3Jn Pgo+IEFja2VkLWJ5OiBPbGVrc2FuZHIgTmF0YWxlbmtvIDxvbGVrc2FuZHJAbmF0YWxlbmtvLm5h bWU+Cj4gQWNrZWQtYnk6IFN0ZXZlbiBCYXJyZXR0IDxzdGV2ZW5AbGlxdW9yaXgubmV0Pgo+IEFj a2VkLWJ5OiBTdWxlaW1hbiBTb3VobGFsIDxzdWxlaW1hbkBnb29nbGUuY29tPgo+IFRlc3RlZC1i eTogRGFuaWVsIEJ5cm5lIDxkamJ5cm5lQG10dS5lZHU+Cj4gVGVzdGVkLWJ5OiBEb25hbGQgQ2Fy ciA8ZEBjaGFvcy1yZWlucy5jb20+Cj4gVGVzdGVkLWJ5OiBIb2xnZXIgSG9mZnN0w6R0dGUgPGhv bGdlckBhcHBsaWVkLWFzeW5jaHJvbnkuY29tPgo+IFRlc3RlZC1ieTogS29uc3RhbnRpbiBLaGFy bGFtb3YgPEhpLUFuZ2VsQHlhbmRleC5ydT4KPiBUZXN0ZWQtYnk6IFNodWFuZyBaaGFpIDxzemhh aTJAY3Mucm9jaGVzdGVyLmVkdT4KPiBUZXN0ZWQtYnk6IFNvZmlhIFRyaW5oIDxzb2ZpYS50cmlu aEBlZGkud29ya3M+Cj4gVGVzdGVkLWJ5OiBWYWliaGF2IEphaW4gPHZhaWJoYXZAbGludXguaWJt LmNvbT4KPiAtLS0KPiAgbW0vdm1zY2FuLmMgfCAxOTggKysrKysrKysrKysrKysrKysrKysrKysr KysrLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLQo+ICAxIGZpbGUgY2hhbmdlZCwgMTA0IGluc2Vy dGlvbnMoKyksIDk0IGRlbGV0aW9ucygtKQo+IAoKTG9va3MgZ29vZCB0byBtZS4gVGhhbmtzIQoK UmV2aWV3ZWQtYnk6IE1pYW9oZSBMaW4gPGxpbm1pYW9oZUBodWF3ZWkuY29tPgoKPiBkaWZmIC0t Z2l0IGEvbW0vdm1zY2FuLmMgYi9tbS92bXNjYW4uYwo+IGluZGV4IDE2Nzg4MDJlMDNlNy4uMjIz MmNiNTVhZjQxIDEwMDY0NAo+IC0tLSBhL21tL3Ztc2Nhbi5jCj4gKysrIGIvbW0vdm1zY2FuLmMK PiBAQCAtMjY0NCw2ICsyNjQ0LDEwOSBAQCBlbnVtIHNjYW5fYmFsYW5jZSB7Cj4gIAlTQ0FOX0ZJ TEUsCj4gIH07Cj4gIAo+ICtzdGF0aWMgdm9pZCBwcmVwYXJlX3NjYW5fY291bnQocGdfZGF0YV90 ICpwZ2RhdCwgc3RydWN0IHNjYW5fY29udHJvbCAqc2MpCj4gK3sKPiArCXVuc2lnbmVkIGxvbmcg ZmlsZTsKPiArCXN0cnVjdCBscnV2ZWMgKnRhcmdldF9scnV2ZWM7Cj4gKwo+ICsJdGFyZ2V0X2xy dXZlYyA9IG1lbV9jZ3JvdXBfbHJ1dmVjKHNjLT50YXJnZXRfbWVtX2Nncm91cCwgcGdkYXQpOwo+ ICsKPiArCS8qCj4gKwkgKiBGbHVzaCB0aGUgbWVtb3J5IGNncm91cCBzdGF0cywgc28gdGhhdCB3 ZSByZWFkIGFjY3VyYXRlIHBlci1tZW1jZwo+ICsJICogbHJ1dmVjIHN0YXRzIGZvciBoZXVyaXN0 aWNzLgo+ICsJICovCj4gKwltZW1fY2dyb3VwX2ZsdXNoX3N0YXRzKCk7Cj4gKwo+ICsJLyoKPiAr CSAqIERldGVybWluZSB0aGUgc2NhbiBiYWxhbmNlIGJldHdlZW4gYW5vbiBhbmQgZmlsZSBMUlVz Lgo+ICsJICovCj4gKwlzcGluX2xvY2tfaXJxKCZ0YXJnZXRfbHJ1dmVjLT5scnVfbG9jayk7Cj4g KwlzYy0+YW5vbl9jb3N0ID0gdGFyZ2V0X2xydXZlYy0+YW5vbl9jb3N0Owo+ICsJc2MtPmZpbGVf Y29zdCA9IHRhcmdldF9scnV2ZWMtPmZpbGVfY29zdDsKPiArCXNwaW5fdW5sb2NrX2lycSgmdGFy Z2V0X2xydXZlYy0+bHJ1X2xvY2spOwo+ICsKPiArCS8qCj4gKwkgKiBUYXJnZXQgZGVzaXJhYmxl IGluYWN0aXZlOmFjdGl2ZSBsaXN0IHJhdGlvcyBmb3IgdGhlIGFub24KPiArCSAqIGFuZCBmaWxl IExSVSBsaXN0cy4KPiArCSAqLwo+ICsJaWYgKCFzYy0+Zm9yY2VfZGVhY3RpdmF0ZSkgewo+ICsJ CXVuc2lnbmVkIGxvbmcgcmVmYXVsdHM7Cj4gKwo+ICsJCXJlZmF1bHRzID0gbHJ1dmVjX3BhZ2Vf c3RhdGUodGFyZ2V0X2xydXZlYywKPiArCQkJCVdPUktJTkdTRVRfQUNUSVZBVEVfQU5PTik7Cj4g KwkJaWYgKHJlZmF1bHRzICE9IHRhcmdldF9scnV2ZWMtPnJlZmF1bHRzWzBdIHx8Cj4gKwkJCWlu YWN0aXZlX2lzX2xvdyh0YXJnZXRfbHJ1dmVjLCBMUlVfSU5BQ1RJVkVfQU5PTikpCj4gKwkJCXNj LT5tYXlfZGVhY3RpdmF0ZSB8PSBERUFDVElWQVRFX0FOT047Cj4gKwkJZWxzZQo+ICsJCQlzYy0+ bWF5X2RlYWN0aXZhdGUgJj0gfkRFQUNUSVZBVEVfQU5PTjsKPiArCj4gKwkJLyoKPiArCQkgKiBX aGVuIHJlZmF1bHRzIGFyZSBiZWluZyBvYnNlcnZlZCwgaXQgbWVhbnMgYSBuZXcKPiArCQkgKiB3 b3JraW5nc2V0IGlzIGJlaW5nIGVzdGFibGlzaGVkLiBEZWFjdGl2YXRlIHRvIGdldAo+ICsJCSAq IHJpZCBvZiBhbnkgc3RhbGUgYWN0aXZlIHBhZ2VzIHF1aWNrbHkuCj4gKwkJICovCj4gKwkJcmVm YXVsdHMgPSBscnV2ZWNfcGFnZV9zdGF0ZSh0YXJnZXRfbHJ1dmVjLAo+ICsJCQkJV09SS0lOR1NF VF9BQ1RJVkFURV9GSUxFKTsKPiArCQlpZiAocmVmYXVsdHMgIT0gdGFyZ2V0X2xydXZlYy0+cmVm YXVsdHNbMV0gfHwKPiArCQkgICAgaW5hY3RpdmVfaXNfbG93KHRhcmdldF9scnV2ZWMsIExSVV9J TkFDVElWRV9GSUxFKSkKPiArCQkJc2MtPm1heV9kZWFjdGl2YXRlIHw9IERFQUNUSVZBVEVfRklM RTsKPiArCQllbHNlCj4gKwkJCXNjLT5tYXlfZGVhY3RpdmF0ZSAmPSB+REVBQ1RJVkFURV9GSUxF Owo+ICsJfSBlbHNlCj4gKwkJc2MtPm1heV9kZWFjdGl2YXRlID0gREVBQ1RJVkFURV9BTk9OIHwg REVBQ1RJVkFURV9GSUxFOwo+ICsKPiArCS8qCj4gKwkgKiBJZiB3ZSBoYXZlIHBsZW50eSBvZiBp bmFjdGl2ZSBmaWxlIHBhZ2VzIHRoYXQgYXJlbid0Cj4gKwkgKiB0aHJhc2hpbmcsIHRyeSB0byBy ZWNsYWltIHRob3NlIGZpcnN0IGJlZm9yZSB0b3VjaGluZwo+ICsJICogYW5vbnltb3VzIHBhZ2Vz Lgo+ICsJICovCj4gKwlmaWxlID0gbHJ1dmVjX3BhZ2Vfc3RhdGUodGFyZ2V0X2xydXZlYywgTlJf SU5BQ1RJVkVfRklMRSk7Cj4gKwlpZiAoZmlsZSA+PiBzYy0+cHJpb3JpdHkgJiYgIShzYy0+bWF5 X2RlYWN0aXZhdGUgJiBERUFDVElWQVRFX0ZJTEUpKQo+ICsJCXNjLT5jYWNoZV90cmltX21vZGUg PSAxOwo+ICsJZWxzZQo+ICsJCXNjLT5jYWNoZV90cmltX21vZGUgPSAwOwo+ICsKPiArCS8qCj4g KwkgKiBQcmV2ZW50IHRoZSByZWNsYWltZXIgZnJvbSBmYWxsaW5nIGludG8gdGhlIGNhY2hlIHRy YXA6IGFzCj4gKwkgKiBjYWNoZSBwYWdlcyBzdGFydCBvdXQgaW5hY3RpdmUsIGV2ZXJ5IGNhY2hl IGZhdWx0IHdpbGwgdGlwCj4gKwkgKiB0aGUgc2NhbiBiYWxhbmNlIHRvd2FyZHMgdGhlIGZpbGUg TFJVLiAgQW5kIGFzIHRoZSBmaWxlIExSVQo+ICsJICogc2hyaW5rcywgc28gZG9lcyB0aGUgd2lu ZG93IGZvciByb3RhdGlvbiBmcm9tIHJlZmVyZW5jZXMuCj4gKwkgKiBUaGlzIG1lYW5zIHdlIGhh dmUgYSBydW5hd2F5IGZlZWRiYWNrIGxvb3Agd2hlcmUgYSB0aW55Cj4gKwkgKiB0aHJhc2hpbmcg ZmlsZSBMUlUgYmVjb21lcyBpbmZpbml0ZWx5IG1vcmUgYXR0cmFjdGl2ZSB0aGFuCj4gKwkgKiBh bm9uIHBhZ2VzLiAgVHJ5IHRvIGRldGVjdCB0aGlzIGJhc2VkIG9uIGZpbGUgTFJVIHNpemUuCj4g KwkgKi8KPiArCWlmICghY2dyb3VwX3JlY2xhaW0oc2MpKSB7Cj4gKwkJdW5zaWduZWQgbG9uZyB0 b3RhbF9oaWdoX3dtYXJrID0gMDsKPiArCQl1bnNpZ25lZCBsb25nIGZyZWUsIGFub247Cj4gKwkJ aW50IHo7Cj4gKwo+ICsJCWZyZWUgPSBzdW1fem9uZV9ub2RlX3BhZ2Vfc3RhdGUocGdkYXQtPm5v ZGVfaWQsIE5SX0ZSRUVfUEFHRVMpOwo+ICsJCWZpbGUgPSBub2RlX3BhZ2Vfc3RhdGUocGdkYXQs IE5SX0FDVElWRV9GSUxFKSArCj4gKwkJCSAgIG5vZGVfcGFnZV9zdGF0ZShwZ2RhdCwgTlJfSU5B Q1RJVkVfRklMRSk7Cj4gKwo+ICsJCWZvciAoeiA9IDA7IHogPCBNQVhfTlJfWk9ORVM7IHorKykg ewo+ICsJCQlzdHJ1Y3Qgem9uZSAqem9uZSA9ICZwZ2RhdC0+bm9kZV96b25lc1t6XTsKPiArCj4g KwkJCWlmICghbWFuYWdlZF96b25lKHpvbmUpKQo+ICsJCQkJY29udGludWU7Cj4gKwo+ICsJCQl0 b3RhbF9oaWdoX3dtYXJrICs9IGhpZ2hfd21hcmtfcGFnZXMoem9uZSk7Cj4gKwkJfQo+ICsKPiAr CQkvKgo+ICsJCSAqIENvbnNpZGVyIGFub246IGlmIHRoYXQncyBsb3cgdG9vLCB0aGlzIGlzbid0 IGEKPiArCQkgKiBydW5hd2F5IGZpbGUgcmVjbGFpbSBwcm9ibGVtLCBidXQgcmF0aGVyIGp1c3QK PiArCQkgKiBleHRyZW1lIHByZXNzdXJlLiBSZWNsYWltIGFzIHBlciB1c3VhbCB0aGVuLgo+ICsJ CSAqLwo+ICsJCWFub24gPSBub2RlX3BhZ2Vfc3RhdGUocGdkYXQsIE5SX0lOQUNUSVZFX0FOT04p Owo+ICsKPiArCQlzYy0+ZmlsZV9pc190aW55ID0KPiArCQkJZmlsZSArIGZyZWUgPD0gdG90YWxf aGlnaF93bWFyayAmJgo+ICsJCQkhKHNjLT5tYXlfZGVhY3RpdmF0ZSAmIERFQUNUSVZBVEVfQU5P TikgJiYKPiArCQkJYW5vbiA+PiBzYy0+cHJpb3JpdHk7Cj4gKwl9Cj4gK30KPiArCj4gIC8qCj4g ICAqIERldGVybWluZSBob3cgYWdncmVzc2l2ZWx5IHRoZSBhbm9uIGFuZCBmaWxlIExSVSBsaXN0 cyBzaG91bGQgYmUKPiAgICogc2Nhbm5lZC4gIFRoZSByZWxhdGl2ZSB2YWx1ZSBvZiBlYWNoIHNl dCBvZiBMUlUgbGlzdHMgaXMgZGV0ZXJtaW5lZAo+IEBAIC0zMTE0LDEwOSArMzIxNywxNiBAQCBz dGF0aWMgdm9pZCBzaHJpbmtfbm9kZShwZ19kYXRhX3QgKnBnZGF0LCBzdHJ1Y3Qgc2Nhbl9jb250 cm9sICpzYykKPiAgCXVuc2lnbmVkIGxvbmcgbnJfcmVjbGFpbWVkLCBucl9zY2FubmVkOwo+ICAJ c3RydWN0IGxydXZlYyAqdGFyZ2V0X2xydXZlYzsKPiAgCWJvb2wgcmVjbGFpbWFibGUgPSBmYWxz ZTsKPiAtCXVuc2lnbmVkIGxvbmcgZmlsZTsKPiAgCj4gIAl0YXJnZXRfbHJ1dmVjID0gbWVtX2Nn cm91cF9scnV2ZWMoc2MtPnRhcmdldF9tZW1fY2dyb3VwLCBwZ2RhdCk7Cj4gIAo+ICBhZ2FpbjoK PiAtCS8qCj4gLQkgKiBGbHVzaCB0aGUgbWVtb3J5IGNncm91cCBzdGF0cywgc28gdGhhdCB3ZSBy ZWFkIGFjY3VyYXRlIHBlci1tZW1jZwo+IC0JICogbHJ1dmVjIHN0YXRzIGZvciBoZXVyaXN0aWNz Lgo+IC0JICovCj4gLQltZW1fY2dyb3VwX2ZsdXNoX3N0YXRzKCk7Cj4gLQo+ICAJbWVtc2V0KCZz Yy0+bnIsIDAsIHNpemVvZihzYy0+bnIpKTsKPiAgCj4gIAlucl9yZWNsYWltZWQgPSBzYy0+bnJf cmVjbGFpbWVkOwo+ICAJbnJfc2Nhbm5lZCA9IHNjLT5ucl9zY2FubmVkOwo+ICAKPiAtCS8qCj4g LQkgKiBEZXRlcm1pbmUgdGhlIHNjYW4gYmFsYW5jZSBiZXR3ZWVuIGFub24gYW5kIGZpbGUgTFJV cy4KPiAtCSAqLwo+IC0Jc3Bpbl9sb2NrX2lycSgmdGFyZ2V0X2xydXZlYy0+bHJ1X2xvY2spOwo+ IC0Jc2MtPmFub25fY29zdCA9IHRhcmdldF9scnV2ZWMtPmFub25fY29zdDsKPiAtCXNjLT5maWxl X2Nvc3QgPSB0YXJnZXRfbHJ1dmVjLT5maWxlX2Nvc3Q7Cj4gLQlzcGluX3VubG9ja19pcnEoJnRh cmdldF9scnV2ZWMtPmxydV9sb2NrKTsKPiAtCj4gLQkvKgo+IC0JICogVGFyZ2V0IGRlc2lyYWJs ZSBpbmFjdGl2ZTphY3RpdmUgbGlzdCByYXRpb3MgZm9yIHRoZSBhbm9uCj4gLQkgKiBhbmQgZmls ZSBMUlUgbGlzdHMuCj4gLQkgKi8KPiAtCWlmICghc2MtPmZvcmNlX2RlYWN0aXZhdGUpIHsKPiAt CQl1bnNpZ25lZCBsb25nIHJlZmF1bHRzOwo+IC0KPiAtCQlyZWZhdWx0cyA9IGxydXZlY19wYWdl X3N0YXRlKHRhcmdldF9scnV2ZWMsCj4gLQkJCQlXT1JLSU5HU0VUX0FDVElWQVRFX0FOT04pOwo+ IC0JCWlmIChyZWZhdWx0cyAhPSB0YXJnZXRfbHJ1dmVjLT5yZWZhdWx0c1swXSB8fAo+IC0JCQlp bmFjdGl2ZV9pc19sb3codGFyZ2V0X2xydXZlYywgTFJVX0lOQUNUSVZFX0FOT04pKQo+IC0JCQlz Yy0+bWF5X2RlYWN0aXZhdGUgfD0gREVBQ1RJVkFURV9BTk9OOwo+IC0JCWVsc2UKPiAtCQkJc2Mt Pm1heV9kZWFjdGl2YXRlICY9IH5ERUFDVElWQVRFX0FOT047Cj4gLQo+IC0JCS8qCj4gLQkJICog V2hlbiByZWZhdWx0cyBhcmUgYmVpbmcgb2JzZXJ2ZWQsIGl0IG1lYW5zIGEgbmV3Cj4gLQkJICog d29ya2luZ3NldCBpcyBiZWluZyBlc3RhYmxpc2hlZC4gRGVhY3RpdmF0ZSB0byBnZXQKPiAtCQkg KiByaWQgb2YgYW55IHN0YWxlIGFjdGl2ZSBwYWdlcyBxdWlja2x5Lgo+IC0JCSAqLwo+IC0JCXJl ZmF1bHRzID0gbHJ1dmVjX3BhZ2Vfc3RhdGUodGFyZ2V0X2xydXZlYywKPiAtCQkJCVdPUktJTkdT RVRfQUNUSVZBVEVfRklMRSk7Cj4gLQkJaWYgKHJlZmF1bHRzICE9IHRhcmdldF9scnV2ZWMtPnJl ZmF1bHRzWzFdIHx8Cj4gLQkJICAgIGluYWN0aXZlX2lzX2xvdyh0YXJnZXRfbHJ1dmVjLCBMUlVf SU5BQ1RJVkVfRklMRSkpCj4gLQkJCXNjLT5tYXlfZGVhY3RpdmF0ZSB8PSBERUFDVElWQVRFX0ZJ TEU7Cj4gLQkJZWxzZQo+IC0JCQlzYy0+bWF5X2RlYWN0aXZhdGUgJj0gfkRFQUNUSVZBVEVfRklM RTsKPiAtCX0gZWxzZQo+IC0JCXNjLT5tYXlfZGVhY3RpdmF0ZSA9IERFQUNUSVZBVEVfQU5PTiB8 IERFQUNUSVZBVEVfRklMRTsKPiAtCj4gLQkvKgo+IC0JICogSWYgd2UgaGF2ZSBwbGVudHkgb2Yg aW5hY3RpdmUgZmlsZSBwYWdlcyB0aGF0IGFyZW4ndAo+IC0JICogdGhyYXNoaW5nLCB0cnkgdG8g cmVjbGFpbSB0aG9zZSBmaXJzdCBiZWZvcmUgdG91Y2hpbmcKPiAtCSAqIGFub255bW91cyBwYWdl cy4KPiAtCSAqLwo+IC0JZmlsZSA9IGxydXZlY19wYWdlX3N0YXRlKHRhcmdldF9scnV2ZWMsIE5S X0lOQUNUSVZFX0ZJTEUpOwo+IC0JaWYgKGZpbGUgPj4gc2MtPnByaW9yaXR5ICYmICEoc2MtPm1h eV9kZWFjdGl2YXRlICYgREVBQ1RJVkFURV9GSUxFKSkKPiAtCQlzYy0+Y2FjaGVfdHJpbV9tb2Rl ID0gMTsKPiAtCWVsc2UKPiAtCQlzYy0+Y2FjaGVfdHJpbV9tb2RlID0gMDsKPiAtCj4gLQkvKgo+ IC0JICogUHJldmVudCB0aGUgcmVjbGFpbWVyIGZyb20gZmFsbGluZyBpbnRvIHRoZSBjYWNoZSB0 cmFwOiBhcwo+IC0JICogY2FjaGUgcGFnZXMgc3RhcnQgb3V0IGluYWN0aXZlLCBldmVyeSBjYWNo ZSBmYXVsdCB3aWxsIHRpcAo+IC0JICogdGhlIHNjYW4gYmFsYW5jZSB0b3dhcmRzIHRoZSBmaWxl IExSVS4gIEFuZCBhcyB0aGUgZmlsZSBMUlUKPiAtCSAqIHNocmlua3MsIHNvIGRvZXMgdGhlIHdp bmRvdyBmb3Igcm90YXRpb24gZnJvbSByZWZlcmVuY2VzLgo+IC0JICogVGhpcyBtZWFucyB3ZSBo YXZlIGEgcnVuYXdheSBmZWVkYmFjayBsb29wIHdoZXJlIGEgdGlueQo+IC0JICogdGhyYXNoaW5n IGZpbGUgTFJVIGJlY29tZXMgaW5maW5pdGVseSBtb3JlIGF0dHJhY3RpdmUgdGhhbgo+IC0JICog YW5vbiBwYWdlcy4gIFRyeSB0byBkZXRlY3QgdGhpcyBiYXNlZCBvbiBmaWxlIExSVSBzaXplLgo+ IC0JICovCj4gLQlpZiAoIWNncm91cF9yZWNsYWltKHNjKSkgewo+IC0JCXVuc2lnbmVkIGxvbmcg dG90YWxfaGlnaF93bWFyayA9IDA7Cj4gLQkJdW5zaWduZWQgbG9uZyBmcmVlLCBhbm9uOwo+IC0J CWludCB6Owo+IC0KPiAtCQlmcmVlID0gc3VtX3pvbmVfbm9kZV9wYWdlX3N0YXRlKHBnZGF0LT5u b2RlX2lkLCBOUl9GUkVFX1BBR0VTKTsKPiAtCQlmaWxlID0gbm9kZV9wYWdlX3N0YXRlKHBnZGF0 LCBOUl9BQ1RJVkVfRklMRSkgKwo+IC0JCQkgICBub2RlX3BhZ2Vfc3RhdGUocGdkYXQsIE5SX0lO QUNUSVZFX0ZJTEUpOwo+IC0KPiAtCQlmb3IgKHogPSAwOyB6IDwgTUFYX05SX1pPTkVTOyB6Kysp IHsKPiAtCQkJc3RydWN0IHpvbmUgKnpvbmUgPSAmcGdkYXQtPm5vZGVfem9uZXNbel07Cj4gLQkJ CWlmICghbWFuYWdlZF96b25lKHpvbmUpKQo+IC0JCQkJY29udGludWU7Cj4gLQo+IC0JCQl0b3Rh bF9oaWdoX3dtYXJrICs9IGhpZ2hfd21hcmtfcGFnZXMoem9uZSk7Cj4gLQkJfQo+IC0KPiAtCQkv Kgo+IC0JCSAqIENvbnNpZGVyIGFub246IGlmIHRoYXQncyBsb3cgdG9vLCB0aGlzIGlzbid0IGEK PiAtCQkgKiBydW5hd2F5IGZpbGUgcmVjbGFpbSBwcm9ibGVtLCBidXQgcmF0aGVyIGp1c3QKPiAt CQkgKiBleHRyZW1lIHByZXNzdXJlLiBSZWNsYWltIGFzIHBlciB1c3VhbCB0aGVuLgo+IC0JCSAq Lwo+IC0JCWFub24gPSBub2RlX3BhZ2Vfc3RhdGUocGdkYXQsIE5SX0lOQUNUSVZFX0FOT04pOwo+ IC0KPiAtCQlzYy0+ZmlsZV9pc190aW55ID0KPiAtCQkJZmlsZSArIGZyZWUgPD0gdG90YWxfaGln aF93bWFyayAmJgo+IC0JCQkhKHNjLT5tYXlfZGVhY3RpdmF0ZSAmIERFQUNUSVZBVEVfQU5PTikg JiYKPiAtCQkJYW5vbiA+PiBzYy0+cHJpb3JpdHk7Cj4gLQl9Cj4gKwlwcmVwYXJlX3NjYW5fY291 bnQocGdkYXQsIHNjKTsKPiAgCj4gIAlzaHJpbmtfbm9kZV9tZW1jZ3MocGdkYXQsIHNjKTsKPiAg Cj4gCgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGlu dXgtYXJtLWtlcm5lbCBtYWlsaW5nIGxpc3QKbGludXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRl YWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgt YXJtLWtlcm5lbAo=