From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F20EEC433DF for ; Tue, 13 Oct 2020 19:24:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A697B20E65 for ; Tue, 13 Oct 2020 19:24:36 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="eLQum2g/" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732495AbgJMTYf (ORCPT ); Tue, 13 Oct 2020 15:24:35 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:48400 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726944AbgJMTYf (ORCPT ); Tue, 13 Oct 2020 15:24:35 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1602617073; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=mROpDD81dZMvuz/AL/wFzK+yDGJlDRaA6Hxnsxnh1II=; b=eLQum2g/TbZtDVTME2Y/gRQ5SG2whRmaur4jyeJg1PzWyl9aX/zqvIdXE9YlD189tZLWlz R4zMVF9QNng331UG+Qx/dCbBSlTQMFxgee+4L26R0TnWn+0j+tzTfs9Fxr+Z30Wo132e9g KL0PUozbOJJcSlvzuJ0kK14lKeyrP10= Received: from mail-il1-f199.google.com (mail-il1-f199.google.com [209.85.166.199]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-299-7tSZxPP5MjK4PyH0ZVaxpA-1; Tue, 13 Oct 2020 15:24:31 -0400 X-MC-Unique: 7tSZxPP5MjK4PyH0ZVaxpA-1 Received: by mail-il1-f199.google.com with SMTP id l5so667158ilf.8 for ; Tue, 13 Oct 2020 12:24:31 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:subject:from:reply-to:to:cc:date :in-reply-to:references:organization:user-agent:mime-version :content-transfer-encoding; bh=mROpDD81dZMvuz/AL/wFzK+yDGJlDRaA6Hxnsxnh1II=; b=JxVqhN26U7g2FItaENjoZRrqWJNs43ZCN15DN8Bki43F27OhxYIkx1+EhmqlYoy95F h9v4jgSY7dfdX3jTbH1GidGbghkp79jWCqS9Ny9bCtPadJPj/K1NXob7wYDlLlgVz7Aq OCdABvfW3kYE14FrrStwKmy9WlPoyXt7VaDGV96K+g5Ux4q+COmC1Dpec2rM1TsfYD4q KmlxrFsEVgcfrsjhZIYGExNZlws3GMahn+NVJU9LjaoSeU+wNCXSTkQ71b7eecf2NvE7 tilIU4XJc0tWE50hjN2f19GyNnVNQ+IivBzlx7G1dr5Zo7q76s8M3dh9lxuNOs31+nL+ Tv8g== X-Gm-Message-State: AOAM531jqyKlV1V+RsIhgKSrP+8vZqWgPsnxhVB201eth+UFIj8GSBrT /jbDhhvM3lToN0AWoYWtEFpq1AxCBmbkBfQKbNwv/8iUk6l+jWox+DImlkJV+e0fKtEVSN/E5Z8 5rEPtYkxJoH/Rh6Dagz2tqu6N X-Received: by 2002:a5d:9693:: with SMTP id m19mr278061ion.161.1602617070906; Tue, 13 Oct 2020 12:24:30 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxexpvv1trKHY3fOYkDVpjsNWt+h1IcDl+tBkAzFj7h6q2G5dun5m8lXLcBt9JKl3VfJCYqTA== X-Received: by 2002:a5d:9693:: with SMTP id m19mr278043ion.161.1602617070662; Tue, 13 Oct 2020 12:24:30 -0700 (PDT) Received: from Whitewolf.lyude.net (pool-108-49-102-102.bstnma.fios.verizon.net. [108.49.102.102]) by smtp.gmail.com with ESMTPSA id h14sm651139ilc.38.2020.10.13.12.24.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 13 Oct 2020 12:24:30 -0700 (PDT) Message-ID: <195e21dc50fbcccf4f7a17d089d5dbdc6603d645.camel@redhat.com> Subject: Re: [PATCH v2 12/24] drm/dp: fix a kernel-doc issue at drm_edid.c From: Lyude Paul Reply-To: lyude@redhat.com To: Mauro Carvalho Chehab , Linux Doc Mailing List Cc: Jonathan Corbet , Ville =?ISO-8859-1?Q?Syrj=E4l=E4?= , Daniel Vetter , David Airlie , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Date: Tue, 13 Oct 2020 15:24:28 -0400 In-Reply-To: <96d648f86024535e5f7d5b0caf8ebf93c7f8eaab.1602590106.git.mchehab+huawei@kernel.org> References: <96d648f86024535e5f7d5b0caf8ebf93c7f8eaab.1602590106.git.mchehab+huawei@kernel.org> Organization: Red Hat Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.36.5 (3.36.5-1.fc32) MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Reviewed-by: Lyude Paul Thanks for the fixes! I will go ahead and push 11 and 12 to drm-misc-next. On Tue, 2020-10-13 at 14:14 +0200, Mauro Carvalho Chehab wrote: > The name of the argument is different, causing those warnings: > > ./drivers/gpu/drm/drm_edid.c:3754: warning: Function parameter or member > 'video_code' not described in 'drm_display_mode_from_cea_vic' > ./drivers/gpu/drm/drm_edid.c:3754: warning: Excess function parameter > 'vic' description in 'drm_display_mode_from_cea_vic' > > Fixes: 7af655bce275 ("drm/dp: Add drm_dp_downstream_mode()") > Signed-off-by: Mauro Carvalho Chehab > --- > drivers/gpu/drm/drm_edid.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c > index a82f37d44258..631125b46e04 100644 > --- a/drivers/gpu/drm/drm_edid.c > +++ b/drivers/gpu/drm/drm_edid.c > @@ -3741,7 +3741,7 @@ drm_add_cmdb_modes(struct drm_connector *connector, u8 > svd) > /** > * drm_display_mode_from_cea_vic() - return a mode for CEA VIC > * @dev: DRM device > - * @vic: CEA VIC of the mode > + * @video_code: CEA VIC of the mode > * > * Creates a new mode matching the specified CEA VIC. > * -- Sincerely, Lyude Paul (she/her) Software Engineer at Red Hat Note: I deal with a lot of emails and have a lot of bugs on my plate. If you've asked me a question, are waiting for a review/merge on a patch, etc. and I haven't responded in a while, please feel free to send me another email to check on my status. I don't bite! From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E0CD3C43457 for ; Tue, 13 Oct 2020 19:24:38 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7C9EB208D5 for ; Tue, 13 Oct 2020 19:24:38 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="GLhSLShV" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7C9EB208D5 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 516336E931; Tue, 13 Oct 2020 19:24:37 +0000 (UTC) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by gabe.freedesktop.org (Postfix) with ESMTPS id 582686E931 for ; Tue, 13 Oct 2020 19:24:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1602617075; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=mROpDD81dZMvuz/AL/wFzK+yDGJlDRaA6Hxnsxnh1II=; b=GLhSLShVaHewQn5zo8iGlESqqFQrY37TwWNqHQOw4jMijGjPEve9+shBkDXEAR2etXlddu XspZKWUVgfXz2FfSTiosDxrSHbYaznXqRjLbfxTa6NJLUxy4ieU0/rWQ9BJio1xirBa/Ru dP+iED8+QTDmbEmZwyVVWeQjmIdoYZE= Received: from mail-il1-f200.google.com (mail-il1-f200.google.com [209.85.166.200]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-175-fJmgsTLCPtuzkxLxZ5SEtQ-1; Tue, 13 Oct 2020 15:24:31 -0400 X-MC-Unique: fJmgsTLCPtuzkxLxZ5SEtQ-1 Received: by mail-il1-f200.google.com with SMTP id y62so642413ilk.20 for ; Tue, 13 Oct 2020 12:24:31 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:subject:from:reply-to:to:cc:date :in-reply-to:references:organization:user-agent:mime-version :content-transfer-encoding; bh=mROpDD81dZMvuz/AL/wFzK+yDGJlDRaA6Hxnsxnh1II=; b=W1OT+UhTsrbbb0lCrFyMDXMtHjvLcRqFApH2MtzI6upC831y2pgo2tScRY3qPwcDox YW+fd8fefDaqYEk04nD4o/WqhZXRXsVjrX+FYcx/ee7cIhVNetRgF9k9Gi0BsPoiR+t2 41E1Wt0Z4sPwGwbvlqo4l7Xv/aTQvuQMMqHEjBK9UPNC3gTC9HEq2mAsvDRgcGiw8qqY 9NcRDcQzY/oUtyJEKuWfosgqXgXyQDcoHezPeGIFB+C7tDk1bP4nye6MTpJQUhRwywPS coAxzluIatQUXolA6BnD0Xg1UYmymL+dDVO8eueDPvZyGnF/XS/tBGo+WEy2SDgGc1Bb Dg7A== X-Gm-Message-State: AOAM532ug0zJruouSkUtlJYmbV9XhHL1m/vGDQSZB4g2lm8VExLm6k45 qK+ilIEl/6ulFYx3QSKJ4T5qpezFRYAgG5idIkIgfmeUz42wWbFIrSOUFXlY02nIiEWnzIAdHml rVojHcAMCKSF2VuD6TA2vuqtUOISm X-Received: by 2002:a5d:9693:: with SMTP id m19mr278064ion.161.1602617070906; Tue, 13 Oct 2020 12:24:30 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxexpvv1trKHY3fOYkDVpjsNWt+h1IcDl+tBkAzFj7h6q2G5dun5m8lXLcBt9JKl3VfJCYqTA== X-Received: by 2002:a5d:9693:: with SMTP id m19mr278043ion.161.1602617070662; Tue, 13 Oct 2020 12:24:30 -0700 (PDT) Received: from Whitewolf.lyude.net (pool-108-49-102-102.bstnma.fios.verizon.net. [108.49.102.102]) by smtp.gmail.com with ESMTPSA id h14sm651139ilc.38.2020.10.13.12.24.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 13 Oct 2020 12:24:30 -0700 (PDT) Message-ID: <195e21dc50fbcccf4f7a17d089d5dbdc6603d645.camel@redhat.com> Subject: Re: [PATCH v2 12/24] drm/dp: fix a kernel-doc issue at drm_edid.c From: Lyude Paul To: Mauro Carvalho Chehab , Linux Doc Mailing List Date: Tue, 13 Oct 2020 15:24:28 -0400 In-Reply-To: <96d648f86024535e5f7d5b0caf8ebf93c7f8eaab.1602590106.git.mchehab+huawei@kernel.org> References: <96d648f86024535e5f7d5b0caf8ebf93c7f8eaab.1602590106.git.mchehab+huawei@kernel.org> Organization: Red Hat User-Agent: Evolution 3.36.5 (3.36.5-1.fc32) MIME-Version: 1.0 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=lyude@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: lyude@redhat.com Cc: Thomas Zimmermann , Jonathan Corbet , David Airlie , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Reviewed-by: Lyude Paul Thanks for the fixes! I will go ahead and push 11 and 12 to drm-misc-next. On Tue, 2020-10-13 at 14:14 +0200, Mauro Carvalho Chehab wrote: > The name of the argument is different, causing those warnings: > > ./drivers/gpu/drm/drm_edid.c:3754: warning: Function parameter or member > 'video_code' not described in 'drm_display_mode_from_cea_vic' > ./drivers/gpu/drm/drm_edid.c:3754: warning: Excess function parameter > 'vic' description in 'drm_display_mode_from_cea_vic' > > Fixes: 7af655bce275 ("drm/dp: Add drm_dp_downstream_mode()") > Signed-off-by: Mauro Carvalho Chehab > --- > drivers/gpu/drm/drm_edid.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c > index a82f37d44258..631125b46e04 100644 > --- a/drivers/gpu/drm/drm_edid.c > +++ b/drivers/gpu/drm/drm_edid.c > @@ -3741,7 +3741,7 @@ drm_add_cmdb_modes(struct drm_connector *connector, u8 > svd) > /** > * drm_display_mode_from_cea_vic() - return a mode for CEA VIC > * @dev: DRM device > - * @vic: CEA VIC of the mode > + * @video_code: CEA VIC of the mode > * > * Creates a new mode matching the specified CEA VIC. > * -- Sincerely, Lyude Paul (she/her) Software Engineer at Red Hat Note: I deal with a lot of emails and have a lot of bugs on my plate. If you've asked me a question, are waiting for a review/merge on a patch, etc. and I haven't responded in a while, please feel free to send me another email to check on my status. I don't bite! _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel