From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=BAYES_00,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 33F63C433DB for ; Thu, 21 Jan 2021 16:27:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E0FA423A22 for ; Thu, 21 Jan 2021 16:27:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387892AbhAUQ1h (ORCPT ); Thu, 21 Jan 2021 11:27:37 -0500 Received: from mail.kernel.org ([198.145.29.99]:58996 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726993AbhAUQ0j (ORCPT ); Thu, 21 Jan 2021 11:26:39 -0500 Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id C7CBF206D8; Thu, 21 Jan 2021 16:25:56 +0000 (UTC) Received: from disco-boy.misterjones.org ([51.254.78.96] helo=www.loen.fr) by disco-boy.misterjones.org with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94) (envelope-from ) id 1l2cmQ-009ERR-Gs; Thu, 21 Jan 2021 16:25:54 +0000 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Date: Thu, 21 Jan 2021 16:25:54 +0000 From: Marc Zyngier To: Mohamed Mediouni Cc: Will Deacon , Linux ARM , Catalin Marinas , Mark Rutland , Hector Martin , linux-kernel@vger.kernel.org, Stan Skowronek Subject: Re: [RFC PATCH 3/7] arm64: mm: use nGnRnE instead of nGnRE on Apple processors In-Reply-To: <39067FDD-F7D3-4F37-8B43-1A9FCF80EEE5@caramail.com> References: <20210120132717.395873-1-mohamed.mediouni@caramail.com> <20210120132717.395873-4-mohamed.mediouni@caramail.com> <20210121112725.GA21750@willie-the-truck> <20210121124742.GA22123@willie-the-truck> <39067FDD-F7D3-4F37-8B43-1A9FCF80EEE5@caramail.com> User-Agent: Roundcube Webmail/1.4.10 Message-ID: <195e2bfe3a5e5503d9988b517159300e@kernel.org> X-Sender: maz@kernel.org X-SA-Exim-Connect-IP: 51.254.78.96 X-SA-Exim-Rcpt-To: mohamed.mediouni@caramail.com, will@kernel.org, linux-arm-kernel@lists.infradead.org, catalin.marinas@arm.com, mark.rutland@arm.com, marcan@marcan.st, linux-kernel@vger.kernel.org, stan@corellium.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2021-01-21 15:12, Mohamed Mediouni wrote: > Please ignore that patch. > > It turns out that the PCIe controller on Apple M1 expects posted > writes and so the memory range for it ought to be set nGnRE. > So, we need to use nGnRnE for on-chip MMIO and nGnRE for PCIe BARs. > > The MAIR approach isn’t adequate for such a thing, so we’ll have to > look elsewhere. Well, there isn't many alternative to having a memory type defined in MAIR if you want to access your PCIe devices with specific semantics. It probably means defining a memory type for PCI only, but: - we only have a single free MT entry, and I'm not sure we can afford to waste this on a specific platform (can we re-purpose GRE instead?), - we'd need to teach the PCI code to use this... Thanks, M. -- Jazz is not dead. It just smells funny... From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DAE28C433DB for ; Thu, 21 Jan 2021 16:27:22 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7FFA1206D8 for ; Thu, 21 Jan 2021 16:27:22 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7FFA1206D8 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Message-ID:References:In-Reply-To:Subject:To:From: Date:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=60RYSAqNdiMGjRuJ7vkpuKsm3ZR/B2MQS35/YSTk8nU=; b=R8cKy4lJIvQUv6eq6Cba8QEWd 6LDI8Wtklh867LT0GInLGRl1nGwHfEAgQOTw3tbN2FZeqguONFribIcfluel2CAP9o1poEwz8PjEw kbk9mk2AbLdkYXBbiZle4d54c/7nHgieoDvcaUI+BgCstzpshWih3zqMyznFivqU/TSTFgDEnDuuS Ls6FkHafFruizqlh7iUDl1e/su+0npLMzcRSGhQZZpNFYo1vvcFbnT1G0R5hfCprt4rbPPh/PhZTv nZ1uk2OS+JhdJNi5fbtOq8r5O2o/Urjq+ce7rC/hXTUV0Sy1w+/0imJXjB9+EBXvz0mA+gPzTG1Jz aSaaKv28A==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1l2cmW-0008Fu-IT; Thu, 21 Jan 2021 16:26:00 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1l2cmT-0008Ex-Jr for linux-arm-kernel@lists.infradead.org; Thu, 21 Jan 2021 16:25:58 +0000 Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id C7CBF206D8; Thu, 21 Jan 2021 16:25:56 +0000 (UTC) Received: from disco-boy.misterjones.org ([51.254.78.96] helo=www.loen.fr) by disco-boy.misterjones.org with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94) (envelope-from ) id 1l2cmQ-009ERR-Gs; Thu, 21 Jan 2021 16:25:54 +0000 MIME-Version: 1.0 Date: Thu, 21 Jan 2021 16:25:54 +0000 From: Marc Zyngier To: Mohamed Mediouni Subject: Re: [RFC PATCH 3/7] arm64: mm: use nGnRnE instead of nGnRE on Apple processors In-Reply-To: <39067FDD-F7D3-4F37-8B43-1A9FCF80EEE5@caramail.com> References: <20210120132717.395873-1-mohamed.mediouni@caramail.com> <20210120132717.395873-4-mohamed.mediouni@caramail.com> <20210121112725.GA21750@willie-the-truck> <20210121124742.GA22123@willie-the-truck> <39067FDD-F7D3-4F37-8B43-1A9FCF80EEE5@caramail.com> User-Agent: Roundcube Webmail/1.4.10 Message-ID: <195e2bfe3a5e5503d9988b517159300e@kernel.org> X-Sender: maz@kernel.org X-SA-Exim-Connect-IP: 51.254.78.96 X-SA-Exim-Rcpt-To: mohamed.mediouni@caramail.com, will@kernel.org, linux-arm-kernel@lists.infradead.org, catalin.marinas@arm.com, mark.rutland@arm.com, marcan@marcan.st, linux-kernel@vger.kernel.org, stan@corellium.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210121_112557_722713_349A7ED8 X-CRM114-Status: GOOD ( 13.71 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , Catalin Marinas , Hector Martin , linux-kernel@vger.kernel.org, Will Deacon , Linux ARM , Stan Skowronek Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gMjAyMS0wMS0yMSAxNToxMiwgTW9oYW1lZCBNZWRpb3VuaSB3cm90ZToKPiBQbGVhc2UgaWdu b3JlIHRoYXQgcGF0Y2guCj4gCj4gSXQgdHVybnMgb3V0IHRoYXQgdGhlIFBDSWUgY29udHJvbGxl ciBvbiBBcHBsZSBNMSBleHBlY3RzIHBvc3RlZAo+IHdyaXRlcyBhbmQgc28gdGhlIG1lbW9yeSBy YW5nZSBmb3IgaXQgb3VnaHQgdG8gYmUgc2V0IG5HblJFLgo+IFNvLCB3ZSBuZWVkIHRvIHVzZSBu R25SbkUgZm9yIG9uLWNoaXAgTU1JTyBhbmQgbkduUkUgZm9yIFBDSWUgQkFScy4KPiAKPiBUaGUg TUFJUiBhcHByb2FjaCBpc27igJl0IGFkZXF1YXRlIGZvciBzdWNoIGEgdGhpbmcsIHNvIHdl4oCZ bGwgaGF2ZSB0bwo+IGxvb2sgZWxzZXdoZXJlLgoKV2VsbCwgdGhlcmUgaXNuJ3QgbWFueSBhbHRl cm5hdGl2ZSB0byBoYXZpbmcgYSBtZW1vcnkgdHlwZSBkZWZpbmVkCmluIE1BSVIgaWYgeW91IHdh bnQgdG8gYWNjZXNzIHlvdXIgUENJZSBkZXZpY2VzIHdpdGggc3BlY2lmaWMKc2VtYW50aWNzLgoK SXQgcHJvYmFibHkgbWVhbnMgZGVmaW5pbmcgYSBtZW1vcnkgdHlwZSBmb3IgUENJIG9ubHksIGJ1 dDoKLSB3ZSBvbmx5IGhhdmUgYSBzaW5nbGUgZnJlZSBNVCBlbnRyeSwgYW5kIEknbSBub3Qgc3Vy ZSB3ZSBjYW4KICAgYWZmb3JkIHRvIHdhc3RlIHRoaXMgb24gYSBzcGVjaWZpYyBwbGF0Zm9ybSAo Y2FuIHdlIHJlLXB1cnBvc2UKICAgR1JFIGluc3RlYWQ/KSwKLSB3ZSdkIG5lZWQgdG8gdGVhY2gg dGhlIFBDSSBjb2RlIHRvIHVzZSB0aGlzLi4uCgpUaGFua3MsCgogICAgICAgICBNLgotLSAKSmF6 eiBpcyBub3QgZGVhZC4gSXQganVzdCBzbWVsbHMgZnVubnkuLi4KCl9fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmxpbnV4LWFybS1rZXJuZWwgbWFpbGluZyBs aXN0CmxpbnV4LWFybS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5m cmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LWFybS1rZXJuZWwK