From mboxrd@z Thu Jan  1 00:00:00 1970
From: Remy Horton <remy.horton@intel.com>
Subject: Re: [PATCH v14 1/6] lib: add information metrics library
Date: Wed, 5 Apr 2017 15:46:04 +0100
Message-ID: <195ebf71-69a7-fca2-ce95-8912ad7ef51a@intel.com>
References: <1490907662-27666-1-git-send-email-remy.horton@intel.com>
 <1490907662-27666-2-git-send-email-remy.horton@intel.com>
 <165712131.qiFBceb8LK@xps13>
Mime-Version: 1.0
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Cc: dev@dpdk.org
To: Thomas Monjalon <thomas.monjalon@6wind.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mga09.intel.com (mga09.intel.com [134.134.136.24])
 by dpdk.org (Postfix) with ESMTP id 9CB3A2B84
 for <dev@dpdk.org>; Wed,  5 Apr 2017 16:46:07 +0200 (CEST)
In-Reply-To: <165712131.qiFBceb8LK@xps13>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>


On 05/04/2017 14:39, Thomas Monjalon wrote:
> 2017-03-30 22:00, Remy Horton:
>> --- a/mk/rte.app.mk
>> +++ b/mk/rte.app.mk
[..]
>> +_LDLIBS-$(CONFIG_RTE_LIBRTE_METRICS)        += -lrte_metrics
>
> It should not be added here in --whole-archive as it is not going to be
> used by plugins (drivers).
>
> I suggest moving it upper with rte_jobstats.

Ok.

As an aside, there seems to have been recent changes to the build 
system, so I suspect there might be a few redundant Makefile additions 
lying around the patchset.

..Remy