From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Jackson Subject: RE: [PATCH V4] libxl: make libxl communicate with xenstored by socket or xenbus driver Date: Fri, 17 Sep 2010 16:16:07 +0100 Message-ID: <19603.34359.834112.276353@mariner.uk.xensource.com> References: <433DDF91DFB08148BAD3FDB6FDDA314C9F35F3BB6A@LONPMAILBOX01.citrite.net> <19599.41566.729352.138960@mariner.uk.xensource.com> <1284540109.14311.18387.camel@zakaz.uk.xensource.com> <19602.18229.95233.935776@mariner.uk.xensource.com> <433DDF91DFB08148BAD3FDB6FDDA314C9F35F3BB6F@LONPMAILBOX01.citrite.net> <1284712745.16095.3048.camel@zakaz.uk.xensource.com> <19603.33765.15374.821794@mariner.uk.xensource.com> <1284736403.16095.3880.camel@zakaz.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1284736403.16095.3880.camel@zakaz.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Ian Campbell Cc: "Jun Zhu (Intern)" , "xen-devel@lists.xensource.com" List-Id: xen-devel@lists.xenproject.org Ian Campbell writes ("RE: [Xen-devel] [PATCH V4] libxl: make libxl communicate with xenstored by socket or xenbus driver"): > I'd similarly concerned about any other fds linked to the context, are > any fds used by the particular xentoollog_logger implementation used by > the context going to be alright for example? All the current logger implementations will be fine. If there were a problem it would be no trouble for a logger to do getpid() before each log message. > I would have thought that reusing ctx->xsh over a fork would cause all > manner of mayhem but it looks like libxl_fork cleverly takes care of > that for us. Yes, I did it like that to try to make it harder to accidentally introduce xsh reuse problems. Ian.