From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [PATCH v2] devtools: add explicit warning messages
	for forbidden tokens
Date: Fri, 02 Nov 2018 11:43:12 +0100
Message-ID: <1962879.kOuKm9R6DT@xps>
References: <1541138405-6608-1-git-send-email-arnon@qwilt.com>
 <4348558.Aku75RrXBD@xps>
 <CAKy9EB1L3MRdFKFZotAe7DQTQxndxBpA+u63=0km3vA_Wby+og@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org, john.mcnamara@intel.com, marko.kovacevic@intel.com
To: Arnon Warshavsky <arnon@qwilt.com>
Return-path: <dev-bounces@dpdk.org>
Received: from wout1-smtp.messagingengine.com (wout1-smtp.messagingengine.com
 [64.147.123.24]) by dpdk.org (Postfix) with ESMTP id 184791B21A
 for <dev@dpdk.org>; Fri,  2 Nov 2018 11:43:16 +0100 (CET)
In-Reply-To: <CAKy9EB1L3MRdFKFZotAe7DQTQxndxBpA+u63=0km3vA_Wby+og@mail.gmail.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

02/11/2018 11:37, Arnon Warshavsky:
> >
> > > +     message="Using explicit .svg extension in figures instead of .*"
> > >       awk -v FOLDERS='doc' \
> > >               -v EXPRESSIONS='::[[:space:]]*[^[:space:]]*\\.svg' \
> > >               -v RET_ON_FAIL=1 \
> > > +             -v MESSAGE="$message" \
> > >               -f $(dirname $(readlink -e $0))/check-forbidden-tokens.awk
> > \
> > >               "$1"
> > >  }
> >
> > Why using a variable for message in the second check?
> >
> >
> > This was to avoid the 80 characters long line warning I get.
> It also seems more convenient should there be a need for multi-line
> messages.
> Is there a more preferred way in such a case of a passed parameter?

I think I prefer passing the string directly.
You can make a shorter message:
	Using explicit .svg extension in rST instead of .*
or
	Using explicit .svg extension instead of .*