From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH v3 00/32] Adding Cavium's OCTEONTX crypto PMD Date: Mon, 08 Oct 2018 15:06:12 +0200 Message-ID: <1968766.8UszeQjU0E@xps> References: <1536033560-21541-1-git-send-email-ajoseph@caviumnetworks.com> <4676876.qg1oKfV5S6@xps> <9f88e0e8-5999-8eb3-a47b-0bbfa6d5d017@caviumnetworks.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org, Akhil Goyal , Pablo de Lara , Jerin Jacob , Narayana Prasad , Ankur Dwivedi , Murthy NSSR , Nithin Dabilpuram , Ragothaman Jayaraman , Srisivasubramanian S , Tejasree Kondoj To: "Joseph, Anoob" Return-path: Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id AF6009B67 for ; Mon, 8 Oct 2018 15:06:16 +0200 (CEST) In-Reply-To: <9f88e0e8-5999-8eb3-a47b-0bbfa6d5d017@caviumnetworks.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 08/10/2018 14:58, Joseph, Anoob: > On 08-10-2018 18:03, Thomas Monjalon wrote: > > A lot of patches are split in 2 parts for common/cpt and crypto/octeontx. > > I think it is useless most of the time. > > You are allowed to update any related code in the common part > > while implementing some features in the crypto driver. > The tool, check-git-log.sh was giving warnings when we were making > changes in two places. That's one reason we had to split it this way. By definition, a tool is silly :-) It is raising a warning to ask you checking manually. If you know what you do, you can ignore this warning.