All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ian Jackson <Ian.Jackson@eu.citrix.com>
To: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Cc: xen-devel@lists.xensource.com
Subject: Re: [PATCH] libxl: implement trigger s3resume
Date: Tue, 11 Jan 2011 16:59:55 +0000	[thread overview]
Message-ID: <19756.35979.333697.849223@mariner.uk.xensource.com> (raw)
In-Reply-To: <alpine.DEB.2.00.1101101059170.2390@kaball-desktop>

Stefano Stabellini writes ("[Xen-devel] [PATCH] libxl: implement trigger s3resume"):
> Implement trigger s3resume
> 
> This is the equivalent of xm trigger s3resume and it is implemented the
> same way: using an ACPI state change.

The code here is a bit odd - callers are apparently expected to pass
strings rather than enums through into the libxl API.  I think
trigger_type_from_string ought to be libxlu_...

But given the current code and the state of freeze we shouldn't do
that now.

This is clearly a low-impact new feature and I'm inclined to make
exception to the freeze for it.  Have you tested the patch ?  Anyone
object ?

Thanks,
Ian.

  reply	other threads:[~2011-01-11 16:59 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-01-10 11:02 [PATCH] libxl: implement trigger s3resume Stefano Stabellini
2011-01-11 16:59 ` Ian Jackson [this message]
2011-02-14 15:29   ` Stefano Stabellini
2011-02-14 16:49     ` Ian Jackson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=19756.35979.333697.849223@mariner.uk.xensource.com \
    --to=ian.jackson@eu.citrix.com \
    --cc=stefano.stabellini@eu.citrix.com \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.