From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Jackson <Ian.Jackson@eu.citrix.com>
Subject: Re: [PATCH 3/6] libxl, xl: fixes to domain creation
	cleanup logic (domid values)
Date: Thu, 27 Jan 2011 18:59:54 +0000
Message-ID: <19777.49322.747849.408538@mariner.uk.xensource.com>
References: <1296150064-31991-1-git-send-email-ian.jackson@eu.citrix.com>
	<1296150064-31991-2-git-send-email-ian.jackson@eu.citrix.com>
	<1296150064-31991-3-git-send-email-ian.jackson@eu.citrix.com>
	<1296150064-31991-4-git-send-email-ian.jackson@eu.citrix.com>
	<alpine.DEB.2.00.1101271832240.7277@kaball-desktop>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xensource.com>
In-Reply-To: <alpine.DEB.2.00.1101271832240.7277@kaball-desktop>
List-Unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Cc: "xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>
List-Id: xen-devel@lists.xenproject.org

Stefano Stabellini writes ("Re: [Xen-devel] [PATCH 3/6] libxl, xl: fixes to domain creation cleanup logic (domid values)"):
> It is non-trivial to understand what this code is supposed to check for.
> You should use a more obvious expression or check for DOMID_INVALID.

Hrm.  Perhaps a utility function for testing valid guest domids would
be a good idea.

Ian.