Re: [Qemu-devel] [PATCH v3 2/3] vus: Introduce vhost-user-scsi host device

[Felipe Franciosi <felipe@nutanix.com>]

Hi Paolo,

Thanks again for the review.
Just to clarify:

> On 2 Jan 2017, at 02:25, Paolo Bonzini <pbonzini@redhat.com> wrote:
> 
> 
> 
> On 21/12/2016 23:17, Felipe Franciosi wrote:
>> To use it, one must configure Qemu with --enable-vhost-user-scsi and
>> start Qemu with a command line equivalent to:
>> 
>> qemu-system-x86_64 \
>>       -chardev socket,id=vus0,path=/tmp/vus.sock \
>>       -device vhost-user-scsi-pci,chardev=vus0,bus=pci.0,addr=...
>> 
>> A separate commit presents a sample application linked with libiscsi to
>> provide a backend for vhost-user-scsi.
> 
> Please place CONFIG_VHOST_USER_SCSI=$(CONFIG_POSIX) symbol in
> default-configs/ (so that it is enabled by default on non-Windows hosts)
> instead of having the configure option.  Otherwise, the patches look good!

Which architectures would you like me to add this to? How about putting it in "pci.mak"?

And when you say "instead", do you mean on top of? I imagine having a --disable switch is at least desirable, so I'd rather not remove the commands from 'configure'.

Cheers,
Felipe

> 
> Paolo