From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DC2D2C433DF for ; Fri, 26 Jun 2020 03:53:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id AA2F620767 for ; Fri, 26 Jun 2020 03:53:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728493AbgFZDx1 (ORCPT ); Thu, 25 Jun 2020 23:53:27 -0400 Received: from mail-pg1-f196.google.com ([209.85.215.196]:33945 "EHLO mail-pg1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726139AbgFZDx0 (ORCPT ); Thu, 25 Jun 2020 23:53:26 -0400 Received: by mail-pg1-f196.google.com with SMTP id t6so4390474pgq.1; Thu, 25 Jun 2020 20:53:26 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:autocrypt :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=dcn+HuSCqrGgLqFUN6RjkKcmkX6X/zJUm5zPHi3c1tw=; b=PKjVKj3TEKn6b7pMawHB5zWRx+Jh0TcvHgkjWS11D6vp1dBqGywsIYxQlOGWrU2crP cWyRQtVQWjXI/sRBzVumc3gtvpoXeLVr2wL5m5NmZxirrXgvs/KJKLUwHKc4+eg8MHxp FOqjthzP+8rG2J9Mrpewwu6hi+IjuUuLlxvj1sLnjACqHTedovvg17oeyQIK105NNZ+0 TLTUE4YnCLCT0LD8tyeWmx/sgn4DiwHRR/9C0UC6wNoMnHoGgHYRpz4fy9qgRsYPDIur r0Z3Gq/d7gwk73vTrR03EZvd4OQMttEdw/I79YhBD/U5iP4zP6HNWoxctEltvm3UQ8uH mzLg== X-Gm-Message-State: AOAM533cOf9eZnLzZf4yI8/oEMzrxD3ObsKwM5OsKr4P5C9NMWu4bsgP jHFRbxlJzv4zvZkplCd5BN8= X-Google-Smtp-Source: ABdhPJw8p2HL18iYGaDTw8w87cibqtCVqxQ5O4BvuC4dsuNx3UBYcRwTgJXy+mj72rbZR2AR4U8/sA== X-Received: by 2002:a63:fe0a:: with SMTP id p10mr944788pgh.255.1593143605899; Thu, 25 Jun 2020 20:53:25 -0700 (PDT) Received: from [192.168.50.147] (c-73-241-217-19.hsd1.ca.comcast.net. [73.241.217.19]) by smtp.gmail.com with ESMTPSA id h6sm939876pfg.25.2020.06.25.20.53.23 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 25 Jun 2020 20:53:24 -0700 (PDT) Subject: Re: [PATCH] scsi: sd: add runtime pm to open / release To: Martin Kepplinger , jejb@linux.ibm.com, martin.petersen@oracle.com, Alan Stern Cc: linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, kernel@puri.sm References: <20200623111018.31954-1-martin.kepplinger@puri.sm> From: Bart Van Assche Autocrypt: addr=bvanassche@acm.org; prefer-encrypt=mutual; keydata= mQENBFSOu4oBCADcRWxVUvkkvRmmwTwIjIJvZOu6wNm+dz5AF4z0FHW2KNZL3oheO3P8UZWr LQOrCfRcK8e/sIs2Y2D3Lg/SL7qqbMehGEYcJptu6mKkywBfoYbtBkVoJ/jQsi2H0vBiiCOy fmxMHIPcYxaJdXxrOG2UO4B60Y/BzE6OrPDT44w4cZA9DH5xialliWU447Bts8TJNa3lZKS1 AvW1ZklbvJfAJJAwzDih35LxU2fcWbmhPa7EO2DCv/LM1B10GBB/oQB5kvlq4aA2PSIWkqz4 3SI5kCPSsygD6wKnbRsvNn2mIACva6VHdm62A7xel5dJRfpQjXj2snd1F/YNoNc66UUTABEB AAG0JEJhcnQgVmFuIEFzc2NoZSA8YnZhbmFzc2NoZUBhY20ub3JnPokBOQQTAQIAIwUCVI67 igIbAwcLCQgHAwIBBhUIAgkKCwQWAgMBAh4BAheAAAoJEHFcPTXFzhAJ8QkH/1AdXblKL65M Y1Zk1bYKnkAb4a98LxCPm/pJBilvci6boefwlBDZ2NZuuYWYgyrehMB5H+q+Kq4P0IBbTqTa jTPAANn62A6jwJ0FnCn6YaM9TZQjM1F7LoDX3v+oAkaoXuq0dQ4hnxQNu792bi6QyVdZUvKc macVFVgfK9n04mL7RzjO3f+X4midKt/s+G+IPr4DGlrq+WH27eDbpUR3aYRk8EgbgGKvQFdD CEBFJi+5ZKOArmJVBSk21RHDpqyz6Vit3rjep7c1SN8s7NhVi9cjkKmMDM7KYhXkWc10lKx2 RTkFI30rkDm4U+JpdAd2+tP3tjGf9AyGGinpzE2XY1K5AQ0EVI67igEIAKiSyd0nECrgz+H5 PcFDGYQpGDMTl8MOPCKw/F3diXPuj2eql4xSbAdbUCJzk2ETif5s3twT2ER8cUTEVOaCEUY3 eOiaFgQ+nGLx4BXqqGewikPJCe+UBjFnH1m2/IFn4T9jPZkV8xlkKmDUqMK5EV9n3eQLkn5g lco+FepTtmbkSCCjd91EfThVbNYpVQ5ZjdBCXN66CKyJDMJ85HVr5rmXG/nqriTh6cv1l1Js T7AFvvPjUPknS6d+BETMhTkbGzoyS+sywEsQAgA+BMCxBH4LvUmHYhpS+W6CiZ3ZMxjO8Hgc ++w1mLeRUvda3i4/U8wDT3SWuHcB3DWlcppECLkAEQEAAYkBHwQYAQIACQUCVI67igIbDAAK CRBxXD01xc4QCZ4dB/0QrnEasxjM0PGeXK5hcZMT9Eo998alUfn5XU0RQDYdwp6/kMEXMdmT oH0F0xB3SQ8WVSXA9rrc4EBvZruWQ+5/zjVrhhfUAx12CzL4oQ9Ro2k45daYaonKTANYG22y //x8dLe2Fv1By4SKGhmzwH87uXxbTJAUxiWIi1np0z3/RDnoVyfmfbbL1DY7zf2hYXLLzsJR mSsED/1nlJ9Oq5fALdNEPgDyPUerqHxcmIub+pF0AzJoYHK5punqpqfGmqPbjxrJLPJfHVKy goMj5DlBMoYqEgpbwdUYkH6QdizJJCur4icy8GUNbisFYABeoJ91pnD4IGei3MTdvINSZI5e Message-ID: <197d485d-d226-17c1-d6c2-c3a9080eaa58@acm.org> Date: Thu, 25 Jun 2020 20:53:22 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.9.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2020-06-25 01:16, Martin Kepplinger wrote: > Also, why isn't "autopm" used in its ioctl() implementation > (as opposed to in "sr")? Some of the scsi_autopm_{get,put}_device() calls in the sr driver have been introduced by me before I fully understood runtime pm. I will have a another look to see whether these are really necessary and if not, post a patch to remove these again. Bart.