From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7E589C433DB for ; Tue, 2 Feb 2021 17:52:40 +0000 (UTC) Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by mail.kernel.org (Postfix) with ESMTP id 0B1CD64E9E for ; Tue, 2 Feb 2021 17:52:40 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0B1CD64E9E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dev-bounces@dpdk.org Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 64F1824038E; Tue, 2 Feb 2021 18:52:39 +0100 (CET) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by mails.dpdk.org (Postfix) with ESMTP id 3337E24038D for ; Tue, 2 Feb 2021 18:52:38 +0100 (CET) IronPort-SDR: PIVqCOzAOkrJtv96zYUcSlvsq/Ppq9W1LSF1D0ud7y4JmSUfkYaHvUlteaZBRlYoQrzT3ZyBIO FK21vjkNklcQ== X-IronPort-AV: E=McAfee;i="6000,8403,9883"; a="180975306" X-IronPort-AV: E=Sophos;i="5.79,396,1602572400"; d="scan'208";a="180975306" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Feb 2021 09:52:36 -0800 IronPort-SDR: r3kTCxeGOKsTajl6lSaR1vY4bSCGn3kzstinn3KP5LyE8chBDoAQvzpdnGssDN/IEXiLSvMX1W l9+Zuiqn7K9A== X-IronPort-AV: E=Sophos;i="5.79,396,1602572400"; d="scan'208";a="391596852" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.213.226.112]) ([10.213.226.112]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Feb 2021 09:52:35 -0800 To: Jiawen Wu , dev@dpdk.org References: <20210122094800.197748-1-jiawenwu@trustnetic.com> <20210122094800.197748-10-jiawenwu@trustnetic.com> From: Ferruh Yigit Message-ID: <197e6952-ed17-0211-996d-cc350d519564@intel.com> Date: Tue, 2 Feb 2021 17:52:33 +0000 MIME-Version: 1.0 In-Reply-To: <20210122094800.197748-10-jiawenwu@trustnetic.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH v1 09/20] net/txgbe: add VLAN handle support to VF driver X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 1/22/2021 9:47 AM, Jiawen Wu wrote: > Add VLAN filter, offload and strip set support to VF driver. > > Signed-off-by: Jiawen Wu <...> > +static int > +txgbevf_vlan_filter_set(struct rte_eth_dev *dev, uint16_t vlan_id, int on) > +{ > + struct txgbe_hw *hw = TXGBE_DEV_HW(dev); > + struct txgbe_vfta *shadow_vfta = TXGBE_DEV_VFTA(dev); > + uint32_t vid_idx = 0; > + uint32_t vid_bit = 0; > + int ret = 0; > + > + PMD_INIT_FUNC_TRACE(); > + > + /* vind is not used in VF driver, set to 0, check txgbe_set_vfta_vf */ > + ret = hw->mac.set_vfta(hw, vlan_id, 0, !!on, false); > + if (ret) { > + PMD_INIT_LOG(ERR, "Unable to set VF vlan"); > + return ret; > + } > + vid_idx = (uint32_t)((vlan_id >> 5) & 0x7F); > + vid_bit = (uint32_t)(1 << (vlan_id & 0x1F)); > + > + /* Save what we set and retore it after device reset */ s/retore/restore