From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Jackson <Ian.Jackson@eu.citrix.com>
Subject: Re: [PATCH] correct xl cpupool-create with extra
	parameters
Date: Mon, 14 Feb 2011 16:55:07 +0000
Message-ID: <19801.24171.286631.919912@mariner.uk.xensource.com>
References: <78995dd5b66b19395412.1297675624@nehalem1>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xensource.com>
In-Reply-To: <78995dd5b66b19395412.1297675624@nehalem1>
List-Unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: Juergen Gross <juergen.gross@ts.fujitsu.com>
Cc: xen-devel@lists.xensource.com
List-Id: xen-devel@lists.xenproject.org

Juergen Gross writes ("[Xen-devel] [PATCH] correct xl cpupool-create with extra parameters"):
> xl cpupool-create won't take always extra parameters specified on the command
> line, as a 0-byte is missing at the end of the configuration file contents.

Thanks, this looks right to me; I have applied it.

Acked-by: Ian Jackson <ian.jackson@eu.citrix.com>

Having said that, I think this approach (reallocing the config data
buffer and tacking the args on the end) is pretty nasty really.  The
right thing would be probably call xlu_cfg_read* more than once.
Let's not do that now, though.

Ian.