From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Subject: Re: [PATCH v9 0/2] PWM support for HiFive Unleashed References: <1552378289-27245-1-git-send-email-yash.shah@sifive.com> From: Paul Walmsley Message-ID: <19807892-f450-58d8-2e78-34d3954da56f@sifive.com> Date: Mon, 18 Mar 2019 16:15:48 -0700 MIME-Version: 1.0 In-Reply-To: Content-Type: multipart/alternative; boundary="------------1DDAA2E043AB5BD9F61CDEA9" Content-Language: en-US To: Yash Shah Cc: Andreas Schwab , Palmer Dabbelt , linux-pwm@vger.kernel.org, linux-riscv@lists.infradead.org, Thierry Reding , robh+dt@kernel.org, mark.rutland@arm.com, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Sachin Ghadi List-ID: This is a multi-part message in MIME format. --------------1DDAA2E043AB5BD9F61CDEA9 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Hi Yash On 3/18/19 10:26 AM, Andreas Schwab wrote: > On Mär 15 2019, Yash Shah wrote: > >> You need to make sure the period setting is passed via the >> conventional way in DT file. >> Example: >> pwmleds { >> compatible = "pwm-leds"; >> heartbeat { >> pwms = <&L45 0 10000000 0>; >> max-brightness = <255>; >> linux,default-trigger = "heartbeat"; >> }; >> }; > I've now managed to build a working FSBL with that change, but that > didn't change anything. There is not even a heartbeat option in > /sys/class/leds/heartbeat/trigger any more. Could you post a copy of the current DTS file and Kconfig that you're using so that Andreas can duplicate your results? thanks, - Paul --------------1DDAA2E043AB5BD9F61CDEA9 Content-Type: text/html; charset=utf-8 Content-Transfer-Encoding: 8bit

Hi Yash


On 3/18/19 10:26 AM, Andreas Schwab wrote:
On Mär 15 2019, Yash Shah <yash.shah@sifive.com> wrote:


You need to make sure the period setting is passed via the
conventional way in DT file.
Example:
pwmleds {
    compatible = "pwm-leds";
    heartbeat {
        pwms = <&L45 0 10000000 0>;
        max-brightness = <255>;
        linux,default-trigger = "heartbeat";
    };
};

I've now managed to build a working FSBL with that change, but that
didn't change anything.  There is not even a heartbeat option in
/sys/class/leds/heartbeat/trigger any more.


Could you post a copy of the current DTS file and Kconfig that you're using so that Andreas can duplicate your results?


thanks,


- Paul

--------------1DDAA2E043AB5BD9F61CDEA9--