From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [PATCH v2] app/testpmd: add bitrate stats option
Date: Mon, 01 May 2017 22:22:26 +0200
Message-ID: <1984316.gczFh5jcb3@xps>
References: <1493211774-28249-1-git-send-email-remy.horton@intel.com>
 <1493377213-156955-1-git-send-email-pablo.de.lara.guarch@intel.com>
 <D52CE0DB.13C49C%Harish.Patil@cavium.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Cc: dev@dpdk.org, Pablo de Lara <pablo.de.lara.guarch@intel.com>,
 "jingjing.wu@intel.com" <jingjing.wu@intel.com>
To: "Patil, Harish" <Harish.Patil@cavium.com>,
 Remy Horton <remy.horton@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com
 [66.111.4.28]) by dpdk.org (Postfix) with ESMTP id E3FF25942
 for <dev@dpdk.org>; Mon,  1 May 2017 22:22:27 +0200 (CEST)
In-Reply-To: <D52CE0DB.13C49C%Harish.Patil@cavium.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

01/05/2017 22:07, Patil, Harish:
> Hi Remy,
> Have a small suggestion here.
> Since testpmd uses new libraries of librte_latencystats and
> librte_bitratestats it hurts packet processing performance.
> Many users who use testpmd to do the initial performance benchmarks may
> not be aware of such a feature is default enabled.

Yes, the default config of testpmd must give good performance.

> So can we disable this feature by default in the config?
> =B7         CONFIG_RTE_LIBRTE_BITRATE=3Dn
> =B7         CONFIG_RTE_LIBRTE_LATENCY_STATS=3Dn
> Only those folks interested in latency/jitter measurements can recompile
> with those configs enabled.

I disagree about compile-time options.
It should be a run-time option of testpmd.

Please Remy (or others),
disable the metrics in the default configuration of testpmd,
before the 17.05 release.
You have few days, it is urgent.