All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sven Eckelmann <sven@narfation.org>
To: b.a.t.m.a.n@lists.open-mesh.org
Cc: Maximilian Wilhelm <max@rfc2324.org>
Subject: Re: [PATCH] batctl: Add per interface hop penalty command
Date: Tue, 02 Jun 2020 09:11:04 +0200	[thread overview]
Message-ID: <1986436.iMA26uce0h@bentobox> (raw)
In-Reply-To: <20200601203538.5318-1-linus.luessing@c0d3.blue>

[-- Attachment #1: Type: text/plain, Size: 894 bytes --]

On Monday, 1 June 2020 22:35:38 CEST Linus Lüssing wrote:
> This patch extends the hop penalty setting to be configurable not only
> on a node scope but also on a per hard interface basis.

I would prefer not to have "this patch" in all your patches :)

Maybe something more like:

* why is it needed
* what was changed

> 
> Signed-off-by: Linus Lüssing <linus.luessing@c0d3.blue>
> ---
>  Makefile         |   1 +
>  README.rst       |   7 ++-
>  if_hop_penalty.c | 113 +++++++++++++++++++++++++++++++++++++++++++++++

Wouldn't it be more consistent to have this in the main hop_penalty file and 
just add a new COMMAND_NAMED?

>  man/batctl.8     |   4 ++
>  4 files changed, 124 insertions(+), 1 deletion(-)
>  create mode 100644 if_hop_penalty.c

This is missing the change to parse the per hardif in the `batctl event` 
monitor command.

Kind regards,
	Sven

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

      reply	other threads:[~2020-06-02  7:11 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-01 20:35 [PATCH] batctl: Add per interface hop penalty command Linus Lüssing
2020-06-02  7:11 ` Sven Eckelmann [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1986436.iMA26uce0h@bentobox \
    --to=sven@narfation.org \
    --cc=b.a.t.m.a.n@lists.open-mesh.org \
    --cc=max@rfc2324.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.