From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3F5E9C48BE8 for ; Wed, 16 Jun 2021 17:52:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 221EA613C7 for ; Wed, 16 Jun 2021 17:52:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231431AbhFPRy1 (ORCPT ); Wed, 16 Jun 2021 13:54:27 -0400 Received: from mail.efficios.com ([167.114.26.124]:52058 "EHLO mail.efficios.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230291AbhFPRyZ (ORCPT ); Wed, 16 Jun 2021 13:54:25 -0400 Received: from localhost (localhost [127.0.0.1]) by mail.efficios.com (Postfix) with ESMTP id E22C434A83B; Wed, 16 Jun 2021 13:52:18 -0400 (EDT) Received: from mail.efficios.com ([127.0.0.1]) by localhost (mail03.efficios.com [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id 9ZYE4D70ELzT; Wed, 16 Jun 2021 13:52:18 -0400 (EDT) Received: from localhost (localhost [127.0.0.1]) by mail.efficios.com (Postfix) with ESMTP id 67C0B34A83A; Wed, 16 Jun 2021 13:52:18 -0400 (EDT) DKIM-Filter: OpenDKIM Filter v2.10.3 mail.efficios.com 67C0B34A83A DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=efficios.com; s=default; t=1623865938; bh=4Pql156OANcBAMgk+nu7NzfwOJ207oQZemvg3h8Ppcw=; h=Date:From:To:Message-ID:MIME-Version; b=XliKh7qEgz1tjdc+X0m8DH60/LgoWT3zYRHvbWVq/EezHiYRVFhFcJnxW2OL2/Yxy CjWtHq2tBuEv7Y5vLTda2YQnYw2qRfYAtXwwI0kHjwSnfgEFARo7mCMIViaJaizIoG 3Bs2vIQR5JXlVnVeXqR3ZQHfMTOe//45C02h8Tj+9IpIspbOqGdthl2y3ZtU/9/5xF Y/004qg8YKTc/3qIxWdLwz41GxgV1NpCzCjBGjAp3EWUOOH8i0PqbkPpVvkO5iGpkf GJSQLGd8cQ0p2jt/nb0vvuGSHSq6Kpiu5CtmrGGIwYdplMay37q9T34VpQZZVkY+yP YEuyHEKOwGC1g== X-Virus-Scanned: amavisd-new at efficios.com Received: from mail.efficios.com ([127.0.0.1]) by localhost (mail03.efficios.com [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id l8S-TV0E36aw; Wed, 16 Jun 2021 13:52:18 -0400 (EDT) Received: from mail03.efficios.com (mail03.efficios.com [167.114.26.124]) by mail.efficios.com (Postfix) with ESMTP id 57CBB34AA02; Wed, 16 Jun 2021 13:52:18 -0400 (EDT) Date: Wed, 16 Jun 2021 13:52:18 -0400 (EDT) From: Mathieu Desnoyers To: Andy Lutomirski Cc: x86 , Dave Hansen , linux-kernel , linux-mm , Andrew Morton , Nicholas Piggin , Peter Zijlstra Message-ID: <1990263287.9043.1623865938326.JavaMail.zimbra@efficios.com> In-Reply-To: <2d45c55c4fbbe38317ff625e2a2158b6fbe0dc2d.1623813516.git.luto@kernel.org> References: <2d45c55c4fbbe38317ff625e2a2158b6fbe0dc2d.1623813516.git.luto@kernel.org> Subject: Re: [PATCH 3/8] membarrier: Remove membarrier_arch_switch_mm() prototype in core code MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Originating-IP: [167.114.26.124] X-Mailer: Zimbra 8.8.15_GA_4018 (ZimbraWebClient - FF89 (Linux)/8.8.15_GA_4026) Thread-Topic: membarrier: Remove membarrier_arch_switch_mm() prototype in core code Thread-Index: po3kb64XWToyumkqJkr6VhDu+QTKbw== Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org ----- On Jun 15, 2021, at 11:21 PM, Andy Lutomirski luto@kernel.org wrote: > membarrier_arch_switch_mm()'s sole implementation and caller are in > arch/powerpc. Having a fallback implementation in include/linux is > confusing -- remove it. > > It's still mentioned in a comment, but a subsequent patch will remove > it. > Acked-by: Mathieu Desnoyers > Cc: Mathieu Desnoyers > Cc: Nicholas Piggin > Cc: Peter Zijlstra > Signed-off-by: Andy Lutomirski > --- > include/linux/sched/mm.h | 7 ------- > 1 file changed, 7 deletions(-) > > diff --git a/include/linux/sched/mm.h b/include/linux/sched/mm.h > index 24d97d1b6252..10aace21d25e 100644 > --- a/include/linux/sched/mm.h > +++ b/include/linux/sched/mm.h > @@ -350,13 +350,6 @@ extern void membarrier_exec_mmap(struct mm_struct *mm); > extern void membarrier_update_current_mm(struct mm_struct *next_mm); > > #else > -#ifdef CONFIG_ARCH_HAS_MEMBARRIER_CALLBACKS > -static inline void membarrier_arch_switch_mm(struct mm_struct *prev, > - struct mm_struct *next, > - struct task_struct *tsk) > -{ > -} > -#endif > static inline void membarrier_exec_mmap(struct mm_struct *mm) > { > } > -- > 2.31.1 -- Mathieu Desnoyers EfficiOS Inc. http://www.efficios.com From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 839E7C48BE6 for ; Wed, 16 Jun 2021 17:52:21 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 11959613C7 for ; Wed, 16 Jun 2021 17:52:21 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 11959613C7 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=efficios.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 5C4996B0036; Wed, 16 Jun 2021 13:52:20 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5728E6B006C; Wed, 16 Jun 2021 13:52:20 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 413406B0070; Wed, 16 Jun 2021 13:52:20 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0083.hostedemail.com [216.40.44.83]) by kanga.kvack.org (Postfix) with ESMTP id 1074D6B0036 for ; Wed, 16 Jun 2021 13:52:20 -0400 (EDT) Received: from smtpin30.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 9F132180AD806 for ; Wed, 16 Jun 2021 17:52:19 +0000 (UTC) X-FDA: 78260331198.30.C00EACC Received: from mail.efficios.com (mail.efficios.com [167.114.26.124]) by imf21.hostedemail.com (Postfix) with ESMTP id 8C72EE000264 for ; Wed, 16 Jun 2021 17:52:05 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by mail.efficios.com (Postfix) with ESMTP id E22C434A83B; Wed, 16 Jun 2021 13:52:18 -0400 (EDT) Received: from mail.efficios.com ([127.0.0.1]) by localhost (mail03.efficios.com [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id 9ZYE4D70ELzT; Wed, 16 Jun 2021 13:52:18 -0400 (EDT) Received: from localhost (localhost [127.0.0.1]) by mail.efficios.com (Postfix) with ESMTP id 67C0B34A83A; Wed, 16 Jun 2021 13:52:18 -0400 (EDT) DKIM-Filter: OpenDKIM Filter v2.10.3 mail.efficios.com 67C0B34A83A DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=efficios.com; s=default; t=1623865938; bh=4Pql156OANcBAMgk+nu7NzfwOJ207oQZemvg3h8Ppcw=; h=Date:From:To:Message-ID:MIME-Version; b=XliKh7qEgz1tjdc+X0m8DH60/LgoWT3zYRHvbWVq/EezHiYRVFhFcJnxW2OL2/Yxy CjWtHq2tBuEv7Y5vLTda2YQnYw2qRfYAtXwwI0kHjwSnfgEFARo7mCMIViaJaizIoG 3Bs2vIQR5JXlVnVeXqR3ZQHfMTOe//45C02h8Tj+9IpIspbOqGdthl2y3ZtU/9/5xF Y/004qg8YKTc/3qIxWdLwz41GxgV1NpCzCjBGjAp3EWUOOH8i0PqbkPpVvkO5iGpkf GJSQLGd8cQ0p2jt/nb0vvuGSHSq6Kpiu5CtmrGGIwYdplMay37q9T34VpQZZVkY+yP YEuyHEKOwGC1g== X-Virus-Scanned: amavisd-new at efficios.com Received: from mail.efficios.com ([127.0.0.1]) by localhost (mail03.efficios.com [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id l8S-TV0E36aw; Wed, 16 Jun 2021 13:52:18 -0400 (EDT) Received: from mail03.efficios.com (mail03.efficios.com [167.114.26.124]) by mail.efficios.com (Postfix) with ESMTP id 57CBB34AA02; Wed, 16 Jun 2021 13:52:18 -0400 (EDT) Date: Wed, 16 Jun 2021 13:52:18 -0400 (EDT) From: Mathieu Desnoyers To: Andy Lutomirski Cc: x86 , Dave Hansen , linux-kernel , linux-mm , Andrew Morton , Nicholas Piggin , Peter Zijlstra Message-ID: <1990263287.9043.1623865938326.JavaMail.zimbra@efficios.com> In-Reply-To: <2d45c55c4fbbe38317ff625e2a2158b6fbe0dc2d.1623813516.git.luto@kernel.org> References: <2d45c55c4fbbe38317ff625e2a2158b6fbe0dc2d.1623813516.git.luto@kernel.org> Subject: Re: [PATCH 3/8] membarrier: Remove membarrier_arch_switch_mm() prototype in core code MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Originating-IP: [167.114.26.124] X-Mailer: Zimbra 8.8.15_GA_4018 (ZimbraWebClient - FF89 (Linux)/8.8.15_GA_4026) Thread-Topic: membarrier: Remove membarrier_arch_switch_mm() prototype in core code Thread-Index: po3kb64XWToyumkqJkr6VhDu+QTKbw== Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=efficios.com header.s=default header.b=XliKh7qE; dmarc=pass (policy=none) header.from=efficios.com; spf=pass (imf21.hostedemail.com: domain of compudj@efficios.com designates 167.114.26.124 as permitted sender) smtp.mailfrom=compudj@efficios.com X-Stat-Signature: r6wzncn1omen6g76fyce6xdnf4h9k6et X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 8C72EE000264 X-HE-Tag: 1623865925-63553 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: ----- On Jun 15, 2021, at 11:21 PM, Andy Lutomirski luto@kernel.org wrote: > membarrier_arch_switch_mm()'s sole implementation and caller are in > arch/powerpc. Having a fallback implementation in include/linux is > confusing -- remove it. > > It's still mentioned in a comment, but a subsequent patch will remove > it. > Acked-by: Mathieu Desnoyers > Cc: Mathieu Desnoyers > Cc: Nicholas Piggin > Cc: Peter Zijlstra > Signed-off-by: Andy Lutomirski > --- > include/linux/sched/mm.h | 7 ------- > 1 file changed, 7 deletions(-) > > diff --git a/include/linux/sched/mm.h b/include/linux/sched/mm.h > index 24d97d1b6252..10aace21d25e 100644 > --- a/include/linux/sched/mm.h > +++ b/include/linux/sched/mm.h > @@ -350,13 +350,6 @@ extern void membarrier_exec_mmap(struct mm_struct *mm); > extern void membarrier_update_current_mm(struct mm_struct *next_mm); > > #else > -#ifdef CONFIG_ARCH_HAS_MEMBARRIER_CALLBACKS > -static inline void membarrier_arch_switch_mm(struct mm_struct *prev, > - struct mm_struct *next, > - struct task_struct *tsk) > -{ > -} > -#endif > static inline void membarrier_exec_mmap(struct mm_struct *mm) > { > } > -- > 2.31.1 -- Mathieu Desnoyers EfficiOS Inc. http://www.efficios.com