From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753299Ab1EGNQp (ORCPT ); Sat, 7 May 2011 09:16:45 -0400 Received: from fanny.its.uu.se ([130.238.4.241]:10928 "EHLO fanny.its.uu.se" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751967Ab1EGNQn (ORCPT ); Sat, 7 May 2011 09:16:43 -0400 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <19909.17976.119505.890308@pilspetsen.it.uu.se> Date: Sat, 7 May 2011 15:16:40 +0200 From: Mikael Pettersson To: Geert Uytterhoeven Cc: Mikael Pettersson , Arnd Bergmann , "Linux/m68k" , Greg Ungerer , Linux Kernel Development , uClinux list Subject: Re: [PATCH] m68k: Merge mmu and non-mmu versions of sys_call_table In-Reply-To: References: <201105050824.34056.arnd@arndb.de> <19907.2804.330120.193924@pilspetsen.it.uu.se> X-Mailer: VM 7.17 under Emacs 20.7.1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 7 May 2011 10:34:25 +0200, Geert Uytterhoeven wrote: > On Thu, May 5, 2011 at 22:39, Mikael Pettersson wrote: > > Geert Uytterhoeven writes: > > =C2=A0> On Thu, 5 May 2011, Arnd Bergmann wrote: > > =C2=A0> > Did you check the macros in unistd to see if they match the > > =C2=A0> > actual table? I guess it would be a good time to comment out > > =C2=A0> > the ones that are not implemented in either of the two ABIs. > > =C2=A0> > > =C2=A0> Like this? > > =C2=A0> > > =C2=A0> warning: #warning syscall pselect6 not implemented > > =C2=A0> warning: #warning syscall ppoll not implemented > > =C2=A0> warning: #warning syscall recvmmsg not implemented > > =C2=A0> > > =C2=A0> Do we need pselect6 and ppoll? I have vague memories not requirin= > g it. > > > > They close user-space race conditions, so you want them. > > So do you recommend to backport the wiring up of pselect6/ppoll to -stable? > We always had their _NR_* defines, so I guess glibc was always compiled > with pselect6/ppoll support, and will use it if it's present. Any kernel with working TIF_RESTORE_SIGMASK should ideally also wire up pselect6/ppoll. But their omission is not a regression so backporting to 2.6.38 is probably sufficient. /Mikael