From: Ian Jackson <Ian.Jackson@eu.citrix.com>
To: "xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>
Subject: Re: [PATCH 10/14] docs: update xl-disk-configuration.txt to describe new syntax
Date: Fri, 20 May 2011 11:21:02 +0100 [thread overview]
Message-ID: <19926.16526.426215.289046@mariner.uk.xensource.com> (raw)
In-Reply-To: <1305883643.20576.11.camel@zakaz.uk.xensource.com>
Ian Campbell writes ("Re: [Xen-devel] [PATCH 10/14] docs: update xl-disk-configuration.txt to describe new syntax"):
> I think it would be ok if you correct the * placements etc. Having some
> sort of (semi-)formal syntax declaration in addition to the wordy
> description is useful IMHO.
>
> Would the syntax be clearer as a BNF style thing rather than a regexp-y
> thing? e.g. this would allow "[<target>, [<format>, [<vdev>,
> [<access>]]]]," to be declared as "POSITIONAL_PARAMETERS := ..." making
> the syntax a little more self-documenting and "KEY := ..." could be
> defined with reference to the relevant following sections etc.
The trouble with bnf is that it all comes out of order -
self-assembly, so to speak.
> Should the second "<key>=<value>" usage also have a "|flag"?
Yes.
> I presume "key" can also == "target" and can be the non-ultimate key so
> long as the value does not contain any problematic characters. In this
> case the explicit target= needs to be marked as optional.
No, general "key" may not be "target". "target=" always eats the rest
of the string.
Ian.
next prev parent reply other threads:[~2011-05-20 10:21 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-12 14:36 [PATCH/RFC 00/14] libxl: disk configuration handling Ian Jackson
2011-05-12 14:36 ` [PATCH 01/14] libxl: add missing copyright notices to some files Ian Jackson
2011-05-12 14:36 ` [PATCH 02/14] libxl: add missing copyright notices to autogenerated files Ian Jackson
2011-05-12 14:36 ` [PATCH 03/14] libxl: provide TOSTRING in libxl_internal.h and libxlu_internal.h Ian Jackson
2011-05-12 14:36 ` [PATCH 04/14] libxl: make libxl_ctx_free tolerate NULL ctx argument Ian Jackson
2011-05-12 14:36 ` [PATCH 05/14] libxl: disks: expose new "script" parameter for external block scripts Ian Jackson
2011-05-12 14:36 ` [PATCH 06/14] libxl: disks: rename disk param "unpluggable" to "removable" Ian Jackson
2011-05-12 14:36 ` [PATCH 07/14] libxl: disks: Make LIBXL_DISK_BACKEND_UNKNOWN work Ian Jackson
2011-05-12 14:36 ` [PATCH 08/14] libxl: disks: new xlu_disk_parse function Ian Jackson
2011-05-12 14:36 ` [PATCH 09/14] libxl: disks: commit libxlu_disk_l.[ch] flex output Ian Jackson
2011-05-12 14:36 ` [PATCH 10/14] docs: update xl-disk-configuration.txt to describe new syntax Ian Jackson
2011-05-12 14:36 ` [PATCH 11/14] xl: disks: replace config file disk spec parser with call to xlu_disk_parse Ian Jackson
2011-05-12 14:36 ` [PATCH 12/14] xl: disks: replace block-attach disk config parser with call to xlu_parse_disk Ian Jackson
2011-05-12 14:36 ` [PATCH 13/14] libxl: disks: allow specification of "backendtype=phy|tap|qdisk" Ian Jackson
2011-05-12 14:36 ` [PATCH 14/14] xl: xl block-attach -N (dry run) option Ian Jackson
2011-05-13 12:56 ` Ian Campbell
2011-05-13 12:53 ` [PATCH 13/14] libxl: disks: allow specification of "backendtype=phy|tap|qdisk" Ian Campbell
2011-06-02 16:57 ` Ian Jackson
2011-05-12 14:42 ` [PATCH 12/14] xl: disks: replace block-attach disk config parser with call to xlu_parse_disk Ian Jackson
2011-05-13 12:50 ` Ian Campbell
2011-05-13 12:49 ` [PATCH 11/14] xl: disks: replace config file disk spec parser with call to xlu_disk_parse Ian Campbell
2011-05-13 12:45 ` [PATCH 10/14] docs: update xl-disk-configuration.txt to describe new syntax Ian Campbell
2011-05-18 10:31 ` Ian Jackson
2011-05-20 9:27 ` Ian Campbell
2011-05-20 10:21 ` Ian Jackson [this message]
2011-05-20 10:26 ` Ian Campbell
2011-05-13 10:49 ` [PATCH 09/14] libxl: disks: commit libxlu_disk_l.[ch] flex output Ian Campbell
2011-05-13 10:48 ` [PATCH 08/14] libxl: disks: new xlu_disk_parse function Ian Campbell
2011-06-02 16:50 ` Ian Jackson
2011-05-13 10:38 ` [PATCH 07/14] libxl: disks: Make LIBXL_DISK_BACKEND_UNKNOWN work Ian Campbell
2011-06-02 16:48 ` Ian Jackson
2011-05-13 10:36 ` [PATCH 06/14] libxl: disks: rename disk param "unpluggable" to "removable" Ian Campbell
2011-05-13 10:35 ` [PATCH 05/14] libxl: disks: expose new "script" parameter for external block scripts Ian Campbell
2011-06-02 16:48 ` Ian Jackson
2011-05-13 10:33 ` [PATCH/RFC 00/14] libxl: disk configuration handling Ian Campbell
2011-06-02 16:57 ` Ian Jackson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=19926.16526.426215.289046@mariner.uk.xensource.com \
--to=ian.jackson@eu.citrix.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.