From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Jackson Subject: Re: [PATCH 08/14] libxl: disks: new xlu_disk_parse function Date: Thu, 2 Jun 2011 17:50:08 +0100 Message-ID: <19943.48960.806749.53604@mariner.uk.xensource.com> References: <1305211004-31687-1-git-send-email-ian.jackson@eu.citrix.com> <1305211004-31687-2-git-send-email-ian.jackson@eu.citrix.com> <1305211004-31687-3-git-send-email-ian.jackson@eu.citrix.com> <1305211004-31687-4-git-send-email-ian.jackson@eu.citrix.com> <1305211004-31687-5-git-send-email-ian.jackson@eu.citrix.com> <1305211004-31687-6-git-send-email-ian.jackson@eu.citrix.com> <1305211004-31687-7-git-send-email-ian.jackson@eu.citrix.com> <1305211004-31687-8-git-send-email-ian.jackson@eu.citrix.com> <1305211004-31687-9-git-send-email-ian.jackson@eu.citrix.com> <1305283706.31488.88.camel@zakaz.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1305283706.31488.88.camel@zakaz.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Ian Campbell Cc: "xen-devel@lists.xensource.com" List-Id: xen-devel@lists.xenproject.org Ian Campbell writes ("Re: [Xen-devel] [PATCH 08/14] libxl: disks: new xlu_disk_parse function"): > On Thu, 2011-05-12 at 15:36 +0100, Ian Jackson wrote: > > [...] ... > Something seems to be up with the leading whitespace here. Fixed. > > + * string containing a collection of parameters (but they all refer > > + * to of the configuration for a single disk). > ^^ what is that doing there? Fixed. .... > This is the third time this week I've wondered if a patch ought to come > along with a library of test inputs and expected outputs. I'll be > proposing we switch to the waterfall model before you know it... My series repost will include one, since it seemed useful. Ian.