From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.4 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F13CFC433DF for ; Wed, 14 Oct 2020 14:34:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 99E2A212CC for ; Wed, 14 Oct 2020 14:34:54 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="vCMS6T6n" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728009AbgJNOex (ORCPT ); Wed, 14 Oct 2020 10:34:53 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60540 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727928AbgJNOex (ORCPT ); Wed, 14 Oct 2020 10:34:53 -0400 Received: from mail-wr1-x443.google.com (mail-wr1-x443.google.com [IPv6:2a00:1450:4864:20::443]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D732BC061755 for ; Wed, 14 Oct 2020 07:34:52 -0700 (PDT) Received: by mail-wr1-x443.google.com with SMTP id e17so4093668wru.12 for ; Wed, 14 Oct 2020 07:34:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=mpnbVKj5Qvt4DLAKTdCVqMoS29Ls9wg8TdVumw+fCxI=; b=vCMS6T6nHEkh+s+Q2LVJ98o8dY2qydszI5cCQbV5feZqTzhNuEOXvuV+k4ViVXXLBg AAwjwORQfzTpmXQ+7JBR7bWx+2Clt3yI/2f5DG9FRpFbLcjkJsOGcStJ7P93PjPLOTwy y4Ig0aDQ9U4vKR/AqHc7SyCyjxWNo3ZqcoKTOOtjCMjMs64TW2v/lavmWZ3dzD1KS5N/ GZOlV8wIwTuq6pMlOxNgx9/h+yw5R8CM1vlVdG0tJTCOL2w8NnzFzrTZmDliKDRZA+K0 Awb7BHd6dejw+JxPPveRl7R73heF3KL46Yu6m0tX7tWFIYVG0f5RchI1NAdmI6+aGil4 RRlw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=mpnbVKj5Qvt4DLAKTdCVqMoS29Ls9wg8TdVumw+fCxI=; b=uTnBswEwDiIuV6iE6gNooDtULaCz/l40FF2vZenhad7piQjV6kuQlX9yPTbBvSSBeV Sb/sihj7VvJvC+pJzHqPNsvXLFry1LaAeQly3Sj4z1dGx3n78YW4Bnxjf57bil2Rj1M7 6gtIvWPAGZMSYr0SBXoMo+p+h0OuaiJITE4Qx73fWF7QrEpiXAYZiKTivxEUl84URwIW b9Yzzh1884YXpll0dIQ/S/GwrybKDVftzqh3QrFVa3eB2rZ7Sy5N6lkECsRM9DC0E7yn eG6ZierjLEtEorpCoNAdlHoWX3OddF336jVmimDIEoxJQDxkrmkB+Yoo/GT+OlnBDAwv /wiw== X-Gm-Message-State: AOAM533QdDJEh6YWTqaR/uziknEuTzsBtma7CqCCBiFBgGjcPf8CfaJO Julay4UW3URz83fV9hbJqIvFOA== X-Google-Smtp-Source: ABdhPJxIq6cbJb8jyXUYvZ0nHc3Wjr5aiEeT2TGg5YK+5ormUkrDUikCiPSvQ7U+JTvAn1RU0xXKbw== X-Received: by 2002:adf:f48c:: with SMTP id l12mr6283823wro.77.1602686090400; Wed, 14 Oct 2020 07:34:50 -0700 (PDT) Received: from ?IPv6:2a01:e34:ed2f:f020:8b3:b79b:6fb0:3e8f? ([2a01:e34:ed2f:f020:8b3:b79b:6fb0:3e8f]) by smtp.googlemail.com with ESMTPSA id z127sm4179758wmc.2.2020.10.14.07.34.48 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 14 Oct 2020 07:34:49 -0700 (PDT) Subject: Re: [PATCH 2/5] thermal: devfreq_cooling: get a copy of device status To: Lukasz Luba , linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, dri-devel@lists.freedesktop.org Cc: rui.zhang@intel.com, amit.kucheria@verdurent.com, orjan.eide@arm.com, robh@kernel.org, alyssa.rosenzweig@collabora.com, steven.price@arm.com, airlied@linux.ie, daniel@ffwll.ch References: <20200921122007.29610-1-lukasz.luba@arm.com> <20200921122007.29610-3-lukasz.luba@arm.com> From: Daniel Lezcano Message-ID: <199bf0e0-88b3-1908-c291-92c85bfe06b1@linaro.org> Date: Wed, 14 Oct 2020 16:34:48 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20200921122007.29610-3-lukasz.luba@arm.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 21/09/2020 14:20, Lukasz Luba wrote: > Devfreq cooling needs to now the correct status of the device in order > to operate. Do not rely on Devfreq last_status which might be a stale data > and get more up-to-date values of the load. > > Devfreq framework can change the device status in the background. To > mitigate this situation make a copy of the status structure and use it > for internal calculations. > > In addition this patch adds normalization function, which also makes sure > that whatever data comes from the device, it is in a sane range. > > Signed-off-by: Lukasz Luba > --- > drivers/thermal/devfreq_cooling.c | 52 +++++++++++++++++++++++++------ > 1 file changed, 43 insertions(+), 9 deletions(-) > > diff --git a/drivers/thermal/devfreq_cooling.c b/drivers/thermal/devfreq_cooling.c > index 7063ccb7b86d..cf045bd4d16b 100644 > --- a/drivers/thermal/devfreq_cooling.c > +++ b/drivers/thermal/devfreq_cooling.c > @@ -227,6 +227,24 @@ static inline unsigned long get_total_power(struct devfreq_cooling_device *dfc, > voltage); > } > > +static void _normalize_load(struct devfreq_dev_status *status) > +{ > + /* Make some space if needed */ > + if (status->busy_time > 0xffff) { > + status->busy_time >>= 10; > + status->total_time >>= 10; > + } > + > + if (status->busy_time > status->total_time) > + status->busy_time = status->total_time; > + > + status->busy_time *= 100; > + status->busy_time /= status->total_time ? : 1; > + > + /* Avoid division by 0 */ > + status->busy_time = status->busy_time ? : 1; > + status->total_time = 100; > +} Not sure that works if the devfreq governor is not on-demand. Is it possible to use the energy model directly in devfreq to compute the energy consumption given the state transitions since the last reading ? The power will be read directly from devfreq which will return: nrj + (current_power * (jiffies - last_update)) / (jiffies - last_update) The devfreq cooling device driver would result in a much simpler code, no? > static int devfreq_cooling_get_requested_power(struct thermal_cooling_device *cdev, > struct thermal_zone_device *tz, > @@ -234,14 +252,22 @@ static int devfreq_cooling_get_requested_power(struct thermal_cooling_device *cd > { > struct devfreq_cooling_device *dfc = cdev->devdata; > struct devfreq *df = dfc->devfreq; > - struct devfreq_dev_status *status = &df->last_status; > + struct devfreq_dev_status status; > unsigned long state; > - unsigned long freq = status->current_frequency; > + unsigned long freq; > unsigned long voltage; > u32 dyn_power = 0; > u32 static_power = 0; > int res; > > + mutex_lock(&df->lock); > + res = df->profile->get_dev_status(df->dev.parent, &status); > + mutex_unlock(&df->lock); > + if (res) > + return res; > + > + freq = status.current_frequency; > + > state = freq_get_state(dfc, freq); > if (state == THERMAL_CSTATE_INVALID) { > res = -EAGAIN; > @@ -269,16 +295,18 @@ static int devfreq_cooling_get_requested_power(struct thermal_cooling_device *cd > } else { > dyn_power = dfc->power_table[state]; > > + _normalize_load(&status); > + > /* Scale dynamic power for utilization */ > - dyn_power *= status->busy_time; > - dyn_power /= status->total_time; > + dyn_power *= status.busy_time; > + dyn_power /= status.total_time; > /* Get static power */ > static_power = get_static_power(dfc, freq); > > *power = dyn_power + static_power; > } > > - trace_thermal_power_devfreq_get_power(cdev, status, freq, *power); > + trace_thermal_power_devfreq_get_power(cdev, &status, freq, *power); > > return 0; > fail: > @@ -312,14 +340,20 @@ static int devfreq_cooling_power2state(struct thermal_cooling_device *cdev, > { > struct devfreq_cooling_device *dfc = cdev->devdata; > struct devfreq *df = dfc->devfreq; > - struct devfreq_dev_status *status = &df->last_status; > - unsigned long freq = status->current_frequency; > + struct devfreq_dev_status status; > unsigned long busy_time; > + unsigned long freq; > s32 dyn_power; > u32 static_power; > s32 est_power; > int i; > > + mutex_lock(&df->lock); > + status = df->last_status; > + mutex_unlock(&df->lock); > + > + freq = status.current_frequency; > + > if (dfc->power_ops->get_real_power) { > /* Scale for resource utilization */ > est_power = power * dfc->res_util; > @@ -331,8 +365,8 @@ static int devfreq_cooling_power2state(struct thermal_cooling_device *cdev, > dyn_power = dyn_power > 0 ? dyn_power : 0; > > /* Scale dynamic power for utilization */ > - busy_time = status->busy_time ?: 1; > - est_power = (dyn_power * status->total_time) / busy_time; > + busy_time = status.busy_time ?: 1; > + est_power = (dyn_power * status.total_time) / busy_time; > } > > /* > -- Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, NICE_REPLY_A,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 61B16C4363A for ; Thu, 15 Oct 2020 07:08:57 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E967A2224E for ; Thu, 15 Oct 2020 07:08:56 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="vCMS6T6n" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E967A2224E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 0F80B6EC2A; Thu, 15 Oct 2020 07:08:38 +0000 (UTC) Received: from mail-wr1-x443.google.com (mail-wr1-x443.google.com [IPv6:2a00:1450:4864:20::443]) by gabe.freedesktop.org (Postfix) with ESMTPS id 0CC256EA97 for ; Wed, 14 Oct 2020 14:34:52 +0000 (UTC) Received: by mail-wr1-x443.google.com with SMTP id n15so4171831wrq.2 for ; Wed, 14 Oct 2020 07:34:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=mpnbVKj5Qvt4DLAKTdCVqMoS29Ls9wg8TdVumw+fCxI=; b=vCMS6T6nHEkh+s+Q2LVJ98o8dY2qydszI5cCQbV5feZqTzhNuEOXvuV+k4ViVXXLBg AAwjwORQfzTpmXQ+7JBR7bWx+2Clt3yI/2f5DG9FRpFbLcjkJsOGcStJ7P93PjPLOTwy y4Ig0aDQ9U4vKR/AqHc7SyCyjxWNo3ZqcoKTOOtjCMjMs64TW2v/lavmWZ3dzD1KS5N/ GZOlV8wIwTuq6pMlOxNgx9/h+yw5R8CM1vlVdG0tJTCOL2w8NnzFzrTZmDliKDRZA+K0 Awb7BHd6dejw+JxPPveRl7R73heF3KL46Yu6m0tX7tWFIYVG0f5RchI1NAdmI6+aGil4 RRlw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=mpnbVKj5Qvt4DLAKTdCVqMoS29Ls9wg8TdVumw+fCxI=; b=XePuwFzrXhe+2Utq3jRMSGlFyZHjKHYXUTi7eDW8XCHJCxucll49cJACycPnlwLeN1 MEbkklXIoXYA2I325tAVqpXCBFUMd9QQs8GEPKdWTfgC4z+FbmpZKoU9G92eUq6NEqw8 a1mvwytP1pCdB51+UKn8H8ur3csqyzyQVGbwHL/Lr5Lt6fPJqa7UYqKBibVAaUAD73FO X6Nxcge4HY80vIg9q2/fyoGwgIC1Be8gjhmVOiY7/SzSgnvyBhbIZoF8RYkAUxwdrxyv Qg98RfeNeBxxUpn9UIyXiknUBmcMGT/uw71O7m5KZ5ST4nz6i2iPvgnsDmfNO5nyx/zT OEdQ== X-Gm-Message-State: AOAM530bFh6O9XRk9G7VEkVzBJb9iH+JYYwnrY1ZjVB99vYFEFNkzctf LlXNP0oF2nowvnts+gusB6hRQw== X-Google-Smtp-Source: ABdhPJxIq6cbJb8jyXUYvZ0nHc3Wjr5aiEeT2TGg5YK+5ormUkrDUikCiPSvQ7U+JTvAn1RU0xXKbw== X-Received: by 2002:adf:f48c:: with SMTP id l12mr6283823wro.77.1602686090400; Wed, 14 Oct 2020 07:34:50 -0700 (PDT) Received: from ?IPv6:2a01:e34:ed2f:f020:8b3:b79b:6fb0:3e8f? ([2a01:e34:ed2f:f020:8b3:b79b:6fb0:3e8f]) by smtp.googlemail.com with ESMTPSA id z127sm4179758wmc.2.2020.10.14.07.34.48 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 14 Oct 2020 07:34:49 -0700 (PDT) Subject: Re: [PATCH 2/5] thermal: devfreq_cooling: get a copy of device status To: Lukasz Luba , linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, dri-devel@lists.freedesktop.org References: <20200921122007.29610-1-lukasz.luba@arm.com> <20200921122007.29610-3-lukasz.luba@arm.com> From: Daniel Lezcano Message-ID: <199bf0e0-88b3-1908-c291-92c85bfe06b1@linaro.org> Date: Wed, 14 Oct 2020 16:34:48 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20200921122007.29610-3-lukasz.luba@arm.com> Content-Language: en-US X-Mailman-Approved-At: Thu, 15 Oct 2020 07:08:24 +0000 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: amit.kucheria@verdurent.com, airlied@linux.ie, steven.price@arm.com, alyssa.rosenzweig@collabora.com, rui.zhang@intel.com, orjan.eide@arm.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" T24gMjEvMDkvMjAyMCAxNDoyMCwgTHVrYXN6IEx1YmEgd3JvdGU6Cj4gRGV2ZnJlcSBjb29saW5n IG5lZWRzIHRvIG5vdyB0aGUgY29ycmVjdCBzdGF0dXMgb2YgdGhlIGRldmljZSBpbiBvcmRlcgo+ IHRvIG9wZXJhdGUuIERvIG5vdCByZWx5IG9uIERldmZyZXEgbGFzdF9zdGF0dXMgd2hpY2ggbWln aHQgYmUgYSBzdGFsZSBkYXRhCj4gYW5kIGdldCBtb3JlIHVwLXRvLWRhdGUgdmFsdWVzIG9mIHRo ZSBsb2FkLgo+IAo+IERldmZyZXEgZnJhbWV3b3JrIGNhbiBjaGFuZ2UgdGhlIGRldmljZSBzdGF0 dXMgaW4gdGhlIGJhY2tncm91bmQuIFRvCj4gbWl0aWdhdGUgdGhpcyBzaXR1YXRpb24gbWFrZSBh IGNvcHkgb2YgdGhlIHN0YXR1cyBzdHJ1Y3R1cmUgYW5kIHVzZSBpdAo+IGZvciBpbnRlcm5hbCBj YWxjdWxhdGlvbnMuCj4gCj4gSW4gYWRkaXRpb24gdGhpcyBwYXRjaCBhZGRzIG5vcm1hbGl6YXRp b24gZnVuY3Rpb24sIHdoaWNoIGFsc28gbWFrZXMgc3VyZQo+IHRoYXQgd2hhdGV2ZXIgZGF0YSBj b21lcyBmcm9tIHRoZSBkZXZpY2UsIGl0IGlzIGluIGEgc2FuZSByYW5nZS4KPiAKPiBTaWduZWQt b2ZmLWJ5OiBMdWthc3ogTHViYSA8bHVrYXN6Lmx1YmFAYXJtLmNvbT4KPiAtLS0KPiAgZHJpdmVy cy90aGVybWFsL2RldmZyZXFfY29vbGluZy5jIHwgNTIgKysrKysrKysrKysrKysrKysrKysrKysr Ky0tLS0tLQo+ICAxIGZpbGUgY2hhbmdlZCwgNDMgaW5zZXJ0aW9ucygrKSwgOSBkZWxldGlvbnMo LSkKPiAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy90aGVybWFsL2RldmZyZXFfY29vbGluZy5jIGIv ZHJpdmVycy90aGVybWFsL2RldmZyZXFfY29vbGluZy5jCj4gaW5kZXggNzA2M2NjYjdiODZkLi5j ZjA0NWJkNGQxNmIgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy90aGVybWFsL2RldmZyZXFfY29vbGlu Zy5jCj4gKysrIGIvZHJpdmVycy90aGVybWFsL2RldmZyZXFfY29vbGluZy5jCj4gQEAgLTIyNyw2 ICsyMjcsMjQgQEAgc3RhdGljIGlubGluZSB1bnNpZ25lZCBsb25nIGdldF90b3RhbF9wb3dlcihz dHJ1Y3QgZGV2ZnJlcV9jb29saW5nX2RldmljZSAqZGZjLAo+ICAJCQkJCQkJICAgICAgIHZvbHRh Z2UpOwo+ICB9Cj4gIAo+ICtzdGF0aWMgdm9pZCBfbm9ybWFsaXplX2xvYWQoc3RydWN0IGRldmZy ZXFfZGV2X3N0YXR1cyAqc3RhdHVzKQo+ICt7Cj4gKwkvKiBNYWtlIHNvbWUgc3BhY2UgaWYgbmVl ZGVkICovCj4gKwlpZiAoc3RhdHVzLT5idXN5X3RpbWUgPiAweGZmZmYpIHsKPiArCQlzdGF0dXMt PmJ1c3lfdGltZSA+Pj0gMTA7Cj4gKwkJc3RhdHVzLT50b3RhbF90aW1lID4+PSAxMDsKPiArCX0K PiArCj4gKwlpZiAoc3RhdHVzLT5idXN5X3RpbWUgPiBzdGF0dXMtPnRvdGFsX3RpbWUpCj4gKwkJ c3RhdHVzLT5idXN5X3RpbWUgPSBzdGF0dXMtPnRvdGFsX3RpbWU7Cj4gKwo+ICsJc3RhdHVzLT5i dXN5X3RpbWUgKj0gMTAwOwo+ICsJc3RhdHVzLT5idXN5X3RpbWUgLz0gc3RhdHVzLT50b3RhbF90 aW1lID8gOiAxOwo+ICsKPiArCS8qIEF2b2lkIGRpdmlzaW9uIGJ5IDAgKi8KPiArCXN0YXR1cy0+ YnVzeV90aW1lID0gc3RhdHVzLT5idXN5X3RpbWUgPyA6IDE7Cj4gKwlzdGF0dXMtPnRvdGFsX3Rp bWUgPSAxMDA7Cj4gK30KCk5vdCBzdXJlIHRoYXQgd29ya3MgaWYgdGhlIGRldmZyZXEgZ292ZXJu b3IgaXMgbm90IG9uLWRlbWFuZC4KCklzIGl0IHBvc3NpYmxlIHRvIHVzZSB0aGUgZW5lcmd5IG1v ZGVsIGRpcmVjdGx5IGluIGRldmZyZXEgdG8gY29tcHV0ZQp0aGUgZW5lcmd5IGNvbnN1bXB0aW9u IGdpdmVuIHRoZSBzdGF0ZSB0cmFuc2l0aW9ucyBzaW5jZSB0aGUgbGFzdCByZWFkaW5nID8KClRo ZSBwb3dlciB3aWxsIGJlIHJlYWQgZGlyZWN0bHkgZnJvbSBkZXZmcmVxIHdoaWNoIHdpbGwgcmV0 dXJuOgoKbnJqICsgKGN1cnJlbnRfcG93ZXIgKiAoamlmZmllcyAtIGxhc3RfdXBkYXRlKSkgLyAo amlmZmllcyAtIGxhc3RfdXBkYXRlKQoKVGhlIGRldmZyZXEgY29vbGluZyBkZXZpY2UgZHJpdmVy IHdvdWxkIHJlc3VsdCBpbiBhIG11Y2ggc2ltcGxlciBjb2RlLCBubz8KCj4gIHN0YXRpYyBpbnQg ZGV2ZnJlcV9jb29saW5nX2dldF9yZXF1ZXN0ZWRfcG93ZXIoc3RydWN0IHRoZXJtYWxfY29vbGlu Z19kZXZpY2UgKmNkZXYsCj4gIAkJCQkJICAgICAgIHN0cnVjdCB0aGVybWFsX3pvbmVfZGV2aWNl ICp0eiwKPiBAQCAtMjM0LDE0ICsyNTIsMjIgQEAgc3RhdGljIGludCBkZXZmcmVxX2Nvb2xpbmdf Z2V0X3JlcXVlc3RlZF9wb3dlcihzdHJ1Y3QgdGhlcm1hbF9jb29saW5nX2RldmljZSAqY2QKPiAg ewo+ICAJc3RydWN0IGRldmZyZXFfY29vbGluZ19kZXZpY2UgKmRmYyA9IGNkZXYtPmRldmRhdGE7 Cj4gIAlzdHJ1Y3QgZGV2ZnJlcSAqZGYgPSBkZmMtPmRldmZyZXE7Cj4gLQlzdHJ1Y3QgZGV2ZnJl cV9kZXZfc3RhdHVzICpzdGF0dXMgPSAmZGYtPmxhc3Rfc3RhdHVzOwo+ICsJc3RydWN0IGRldmZy ZXFfZGV2X3N0YXR1cyBzdGF0dXM7Cj4gIAl1bnNpZ25lZCBsb25nIHN0YXRlOwo+IC0JdW5zaWdu ZWQgbG9uZyBmcmVxID0gc3RhdHVzLT5jdXJyZW50X2ZyZXF1ZW5jeTsKPiArCXVuc2lnbmVkIGxv bmcgZnJlcTsKPiAgCXVuc2lnbmVkIGxvbmcgdm9sdGFnZTsKPiAgCXUzMiBkeW5fcG93ZXIgPSAw Owo+ICAJdTMyIHN0YXRpY19wb3dlciA9IDA7Cj4gIAlpbnQgcmVzOwo+ICAKPiArCW11dGV4X2xv Y2soJmRmLT5sb2NrKTsKPiArCXJlcyA9IGRmLT5wcm9maWxlLT5nZXRfZGV2X3N0YXR1cyhkZi0+ ZGV2LnBhcmVudCwgJnN0YXR1cyk7Cj4gKwltdXRleF91bmxvY2soJmRmLT5sb2NrKTsKPiArCWlm IChyZXMpCj4gKwkJcmV0dXJuIHJlczsKPiArCj4gKwlmcmVxID0gc3RhdHVzLmN1cnJlbnRfZnJl cXVlbmN5Owo+ICsKPiAgCXN0YXRlID0gZnJlcV9nZXRfc3RhdGUoZGZjLCBmcmVxKTsKPiAgCWlm IChzdGF0ZSA9PSBUSEVSTUFMX0NTVEFURV9JTlZBTElEKSB7Cj4gIAkJcmVzID0gLUVBR0FJTjsK PiBAQCAtMjY5LDE2ICsyOTUsMTggQEAgc3RhdGljIGludCBkZXZmcmVxX2Nvb2xpbmdfZ2V0X3Jl cXVlc3RlZF9wb3dlcihzdHJ1Y3QgdGhlcm1hbF9jb29saW5nX2RldmljZSAqY2QKPiAgCX0gZWxz ZSB7Cj4gIAkJZHluX3Bvd2VyID0gZGZjLT5wb3dlcl90YWJsZVtzdGF0ZV07Cj4gIAo+ICsJCV9u b3JtYWxpemVfbG9hZCgmc3RhdHVzKTsKPiArCj4gIAkJLyogU2NhbGUgZHluYW1pYyBwb3dlciBm b3IgdXRpbGl6YXRpb24gKi8KPiAtCQlkeW5fcG93ZXIgKj0gc3RhdHVzLT5idXN5X3RpbWU7Cj4g LQkJZHluX3Bvd2VyIC89IHN0YXR1cy0+dG90YWxfdGltZTsKPiArCQlkeW5fcG93ZXIgKj0gc3Rh dHVzLmJ1c3lfdGltZTsKPiArCQlkeW5fcG93ZXIgLz0gc3RhdHVzLnRvdGFsX3RpbWU7Cj4gIAkJ LyogR2V0IHN0YXRpYyBwb3dlciAqLwo+ICAJCXN0YXRpY19wb3dlciA9IGdldF9zdGF0aWNfcG93 ZXIoZGZjLCBmcmVxKTsKPiAgCj4gIAkJKnBvd2VyID0gZHluX3Bvd2VyICsgc3RhdGljX3Bvd2Vy Owo+ICAJfQo+ICAKPiAtCXRyYWNlX3RoZXJtYWxfcG93ZXJfZGV2ZnJlcV9nZXRfcG93ZXIoY2Rl diwgc3RhdHVzLCBmcmVxLCAqcG93ZXIpOwo+ICsJdHJhY2VfdGhlcm1hbF9wb3dlcl9kZXZmcmVx X2dldF9wb3dlcihjZGV2LCAmc3RhdHVzLCBmcmVxLCAqcG93ZXIpOwo+ICAKPiAgCXJldHVybiAw Owo+ICBmYWlsOgo+IEBAIC0zMTIsMTQgKzM0MCwyMCBAQCBzdGF0aWMgaW50IGRldmZyZXFfY29v bGluZ19wb3dlcjJzdGF0ZShzdHJ1Y3QgdGhlcm1hbF9jb29saW5nX2RldmljZSAqY2RldiwKPiAg ewo+ICAJc3RydWN0IGRldmZyZXFfY29vbGluZ19kZXZpY2UgKmRmYyA9IGNkZXYtPmRldmRhdGE7 Cj4gIAlzdHJ1Y3QgZGV2ZnJlcSAqZGYgPSBkZmMtPmRldmZyZXE7Cj4gLQlzdHJ1Y3QgZGV2ZnJl cV9kZXZfc3RhdHVzICpzdGF0dXMgPSAmZGYtPmxhc3Rfc3RhdHVzOwo+IC0JdW5zaWduZWQgbG9u ZyBmcmVxID0gc3RhdHVzLT5jdXJyZW50X2ZyZXF1ZW5jeTsKPiArCXN0cnVjdCBkZXZmcmVxX2Rl dl9zdGF0dXMgc3RhdHVzOwo+ICAJdW5zaWduZWQgbG9uZyBidXN5X3RpbWU7Cj4gKwl1bnNpZ25l ZCBsb25nIGZyZXE7Cj4gIAlzMzIgZHluX3Bvd2VyOwo+ICAJdTMyIHN0YXRpY19wb3dlcjsKPiAg CXMzMiBlc3RfcG93ZXI7Cj4gIAlpbnQgaTsKPiAgCj4gKwltdXRleF9sb2NrKCZkZi0+bG9jayk7 Cj4gKwlzdGF0dXMgPSBkZi0+bGFzdF9zdGF0dXM7Cj4gKwltdXRleF91bmxvY2soJmRmLT5sb2Nr KTsKPiArCj4gKwlmcmVxID0gc3RhdHVzLmN1cnJlbnRfZnJlcXVlbmN5Owo+ICsKPiAgCWlmIChk ZmMtPnBvd2VyX29wcy0+Z2V0X3JlYWxfcG93ZXIpIHsKPiAgCQkvKiBTY2FsZSBmb3IgcmVzb3Vy Y2UgdXRpbGl6YXRpb24gKi8KPiAgCQllc3RfcG93ZXIgPSBwb3dlciAqIGRmYy0+cmVzX3V0aWw7 Cj4gQEAgLTMzMSw4ICszNjUsOCBAQCBzdGF0aWMgaW50IGRldmZyZXFfY29vbGluZ19wb3dlcjJz dGF0ZShzdHJ1Y3QgdGhlcm1hbF9jb29saW5nX2RldmljZSAqY2RldiwKPiAgCQlkeW5fcG93ZXIg PSBkeW5fcG93ZXIgPiAwID8gZHluX3Bvd2VyIDogMDsKPiAgCj4gIAkJLyogU2NhbGUgZHluYW1p YyBwb3dlciBmb3IgdXRpbGl6YXRpb24gKi8KPiAtCQlidXN5X3RpbWUgPSBzdGF0dXMtPmJ1c3lf dGltZSA/OiAxOwo+IC0JCWVzdF9wb3dlciA9IChkeW5fcG93ZXIgKiBzdGF0dXMtPnRvdGFsX3Rp bWUpIC8gYnVzeV90aW1lOwo+ICsJCWJ1c3lfdGltZSA9IHN0YXR1cy5idXN5X3RpbWUgPzogMTsK PiArCQllc3RfcG93ZXIgPSAoZHluX3Bvd2VyICogc3RhdHVzLnRvdGFsX3RpbWUpIC8gYnVzeV90 aW1lOwo+ICAJfQo+ICAKPiAgCS8qCj4gCgoKLS0gCjxodHRwOi8vd3d3LmxpbmFyby5vcmcvPiBM aW5hcm8ub3JnIOKUgiBPcGVuIHNvdXJjZSBzb2Z0d2FyZSBmb3IgQVJNIFNvQ3MKCkZvbGxvdyBM aW5hcm86ICA8aHR0cDovL3d3dy5mYWNlYm9vay5jb20vcGFnZXMvTGluYXJvPiBGYWNlYm9vayB8 CjxodHRwOi8vdHdpdHRlci5jb20vIyEvbGluYXJvb3JnPiBUd2l0dGVyIHwKPGh0dHA6Ly93d3cu bGluYXJvLm9yZy9saW5hcm8tYmxvZy8+IEJsb2cKX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlz dHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4v bGlzdGluZm8vZHJpLWRldmVsCg==