From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Guenter Roeck <groeck@google.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Randy Dunlap <rdunlap@infradead.org>,
LKML <linux-kernel@vger.kernel.org>,
Guenter Roeck <groeck@chromium.org>,
Wei-Ning Huang <wnhuang@google.com>
Subject: Re: drivers/firmware/google/vpd.c: duplicate sysfs file
Date: Mon, 13 Nov 2017 14:26:36 -0800 [thread overview]
Message-ID: <19B9CA48-C5CC-4EFD-AE6B-527D56F33249@gmail.com> (raw)
In-Reply-To: <CABXOdTfc1wWmjrExpGkpx6ccoiKBadVLCdSexBXqNCfG7apd=w@mail.gmail.com>
On November 13, 2017 2:24:23 PM PST, Guenter Roeck <groeck@google.com> wrote:
>On Mon, Nov 13, 2017 at 2:01 PM, Dmitry Torokhov
><dmitry.torokhov@gmail.com> wrote:
>> On Mon, Nov 13, 2017 at 12:14:41PM -0800, Guenter Roeck wrote:
>>> The sysfs warning, yes. However, after unbinding and rebinding the
>>> driver, "cat /sys/firmware/vpd/rw_raw" will result in a crash.
>>>
>>> Sequence:
>>>
>>> echo vpd > /sys/bus/platform/drivers/vpd/unbind
>>> echo vpd > /sys/bus/platform/drivers/vpd/bind # <-- nasty message
>>>
>>> cat /sys/firmware/vpd/rw_raw # <-- crash
>>
>> I'd disable unbind (.suppress_bind_attrs = true) and commented out
>> unload for now. And then looked into fixing properly.
>>
>
>Fixing properly is easy as long as we retain the platform device; I
>already have a set of patches doing just that. I have no idea how to
>implement the non-platform-device variant, if that is what you mean
>with "properly".
Ah, ok then.
Thanks.
--
Dmitry
prev parent reply other threads:[~2017-11-13 22:26 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-13 6:36 drivers/firmware/google/vpd.c: duplicate sysfs file Randy Dunlap
[not found] ` <CABXOdTfJkdWzqptbqkbJqNtxx5+qeW=+4CZFUG9UxJ6QADAsRw@mail.gmail.com>
2017-11-13 18:18 ` Randy Dunlap
2017-11-13 19:04 ` Dmitry Torokhov
2017-11-13 19:09 ` Guenter Roeck
2017-11-13 19:23 ` Greg Kroah-Hartman
2017-11-13 20:14 ` Guenter Roeck
2017-11-13 22:01 ` Dmitry Torokhov
2017-11-13 22:24 ` Guenter Roeck
2017-11-13 22:26 ` Dmitry Torokhov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=19B9CA48-C5CC-4EFD-AE6B-527D56F33249@gmail.com \
--to=dmitry.torokhov@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=groeck@chromium.org \
--cc=groeck@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rdunlap@infradead.org \
--cc=wnhuang@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.