From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Hiremath, Vaibhav" Subject: RE: [PATCH 1/2] OMAP3EVM: Made backlight GPIO default state to off Date: Tue, 30 Mar 2010 13:40:53 +0530 Message-ID: <19F8576C6E063C45BE387C64729E7394044DEBF3A5@dbde02.ent.ti.com> References: <1269263470-13814-1-git-send-email-hvaibhav@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT Return-path: Received: from arroyo.ext.ti.com ([192.94.94.40]:36928 "EHLO arroyo.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755619Ab0C3ILF convert rfc822-to-8bit (ORCPT ); Tue, 30 Mar 2010 04:11:05 -0400 In-Reply-To: <1269263470-13814-1-git-send-email-hvaibhav@ti.com> Content-Language: en-US Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: "Hiremath, Vaibhav" , "linux-omap@vger.kernel.org" Cc: "tomi.valkeinen@nokia.com" , "tony@atomide.com" > -----Original Message----- > From: Hiremath, Vaibhav > Sent: Monday, March 22, 2010 6:41 PM > To: linux-omap@vger.kernel.org > Cc: tomi.valkeinen@nokia.com; tony@atomide.com; Hiremath, Vaibhav > Subject: [PATCH 1/2] OMAP3EVM: Made backlight GPIO default state to off > > From: Vaibhav Hiremath > > If you choose default output to DVI, the LCD backlight still > gets powered, since panel->disable function never gets called for LCD. > > So, during init put backlight GPIO to off state and the driverr > code will decide which output to enable explicitly. > [Hiremath, Vaibhav] Tony, Do you see any issues with this patch? I think we can merge this patch series. Thanks, Vaibhav > Signed-off-by: Vaibhav Hiremath > --- > arch/arm/mach-omap2/board-omap3evm.c | 5 ++++- > 1 files changed, 4 insertions(+), 1 deletions(-) > > diff --git a/arch/arm/mach-omap2/board-omap3evm.c b/arch/arm/mach- > omap2/board-omap3evm.c > index 74bbdcb..f2a52c3 100644 > --- a/arch/arm/mach-omap2/board-omap3evm.c > +++ b/arch/arm/mach-omap2/board-omap3evm.c > @@ -420,7 +420,10 @@ static int omap3evm_twl_gpio_setup(struct device *dev, > > /* TWL4030_GPIO_MAX + 0 == ledA, LCD Backlight control */ > gpio_request(gpio + TWL4030_GPIO_MAX, "EN_LCD_BKL"); > - gpio_direction_output(gpio + TWL4030_GPIO_MAX, 0); > + if (get_omap3_evm_rev() >= OMAP3EVM_BOARD_GEN_2) > + gpio_direction_output(gpio + TWL4030_GPIO_MAX, 1); > + else > + gpio_direction_output(gpio + TWL4030_GPIO_MAX, 0); > > /* gpio + 7 == DVI Enable */ > gpio_request(gpio + 7, "EN_DVI"); > -- > 1.6.2.4