All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Hiremath, Vaibhav" <hvaibhav@ti.com>
To: Tomi Valkeinen <tomi.valkeinen@nokia.com>
Cc: "linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
	"tony@atomide.com" <tony@atomide.com>
Subject: RE: [PATCH 1/2] OMAP3EVM: Made backlight GPIO default state to off
Date: Thu, 1 Apr 2010 17:41:36 +0530	[thread overview]
Message-ID: <19F8576C6E063C45BE387C64729E7394044DF7EF68@dbde02.ent.ti.com> (raw)
In-Reply-To: <1270122886.2704.100.camel@tubuntu.research.nokia.com>


> -----Original Message-----
> From: Tomi Valkeinen [mailto:tomi.valkeinen@nokia.com]
> Sent: Thursday, April 01, 2010 5:25 PM
> To: Hiremath, Vaibhav
> Cc: linux-omap@vger.kernel.org; tony@atomide.com
> Subject: Re: [PATCH 1/2] OMAP3EVM: Made backlight GPIO default state to off
> 
> Hi,
> 
> On Mon, 2010-03-22 at 14:11 +0100, ext hvaibhav@ti.com wrote:
> > From: Vaibhav Hiremath <hvaibhav@ti.com>
> >
> > If you choose default output to DVI, the LCD backlight still
> > gets powered, since panel->disable function never gets called for LCD.
> >
> > So, during init put backlight GPIO to off state and the driverr
> > code will decide which output to enable explicitly.
> 
> I'm not sure I understand this patch. You talk about choosing default
> output (via kernel boot args, I presume),
[Hiremath, Vaibhav] yes you are correct. I am talking about default output selection using bootargs.

> but the code checks for EVM
> revision. What is the connection between EVM revision and selecting
> display output?
[Hiremath, Vaibhav] Ohh ok, I think you are not aware that we do have 2 version of EVM's. EVM-1 with positive (backlight gpio) polarity and EVM-2 with negative (backlight gpio) polarity. 

The code is doing exactly same.

Thanks,
Vaibhav
> 
>  Tomi
> 


  reply	other threads:[~2010-04-01 12:11 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-03-22 13:11 [PATCH 1/2] OMAP3EVM: Made backlight GPIO default state to off hvaibhav
2010-03-30  8:10 ` Hiremath, Vaibhav
2010-04-01 10:23   ` Tony Lindgren
2010-04-01 11:54 ` Tomi Valkeinen
2010-04-01 12:11   ` Hiremath, Vaibhav [this message]
2010-04-01 13:32     ` Tomi Valkeinen
2010-04-12 11:47       ` Hiremath, Vaibhav

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=19F8576C6E063C45BE387C64729E7394044DF7EF68@dbde02.ent.ti.com \
    --to=hvaibhav@ti.com \
    --cc=linux-omap@vger.kernel.org \
    --cc=tomi.valkeinen@nokia.com \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.