misc/021-image-multi-devices fails on latest btrfs-devel/misc-next

misc/021-image-multi-devices fails on latest btrfs-devel/misc-next

[Lakshmipathi.G]

Hi.

Few days back(Nov14th) this(misc/021-image-multi-devices) test script
used to pass and seems like its failing
now. may be due to recent commits? Logs,screen-casts available here:
https://lakshmipathi.github.io/btrfsqa/

----
Cheers,
Lakshmipathi.G
http://www.giis.co.in http://www.webminal.org

Re: misc/021-image-multi-devices fails on latest btrfs-devel/misc-next

[Lakshmipathi.G]

Quick update: It continues to fail:
https://asciinema.org/a/8HAL3uZ4MG7eb5gXnlgq3jm7q
----
Cheers,
Lakshmipathi.G
http://www.giis.co.in http://www.webminal.org


On Sat, Nov 18, 2017 at 12:59 PM, Lakshmipathi.G
<lakshmipathi.g@gmail.com> wrote:
> Hi.
>
> Few days back(Nov14th) this(misc/021-image-multi-devices) test script
> used to pass and seems like its failing
> now. may be due to recent commits? Logs,screen-casts available here:
> https://lakshmipathi.github.io/btrfsqa/
>
> ----
> Cheers,
> Lakshmipathi.G
> http://www.giis.co.in http://www.webminal.org

Re: misc/021-image-multi-devices fails on latest btrfs-devel/misc-next

[Qu Wenruo]

[-- Attachment #1.1: Type: text/plain, Size: 1160 bytes --]



On 2017年11月23日 11:16, Lakshmipathi.G wrote:
> Quick update: It continues to fail:
> https://asciinema.org/a/8HAL3uZ4MG7eb5gXnlgq3jm7q

Still fails to reproduce it.

All success across my host and VMs.

And according to your misc-test-result, it seems that your testing
system doesn't cleanup loop devices for 021 well.

I think that's the reason why you always get stuck at misc/021.

Thanks,
Qu

> ----
> Cheers,
> Lakshmipathi.G
> http://www.giis.co.in http://www.webminal.org
> 
> 
> On Sat, Nov 18, 2017 at 12:59 PM, Lakshmipathi.G
> <lakshmipathi.g@gmail.com> wrote:
>> Hi.
>>
>> Few days back(Nov14th) this(misc/021-image-multi-devices) test script
>> used to pass and seems like its failing
>> now. may be due to recent commits? Logs,screen-casts available here:
>> https://lakshmipathi.github.io/btrfsqa/
>>
>> ----
>> Cheers,
>> Lakshmipathi.G
>> http://www.giis.co.in http://www.webminal.org
> --
> To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 520 bytes --]

Re: misc/021-image-multi-devices fails on latest btrfs-devel/misc-next

[Lakshmipathi.G]

Hi Qu,

I'm using the same instance. Let me check again with and without the
commits list on Nov-23
(https://github.com/kdave/btrfs-devel/commits/misc-next) and get back
with results.

----
Cheers,
Lakshmipathi.G
http://www.giis.co.in http://www.webminal.org

Re: misc/021-image-multi-devices fails on latest btrfs-devel/misc-next

[Lakshmipathi.G]

Hi Qu,

I'm using btrfs-progs devel branch. mount command is failing with misc/021.
When I tried to manually mount it. dmesg shows  "unrecognized super
flag: 17179869184"
and interestingly "df -h" shows 16E as available!

https://asciinema.org/a/4JGYg7YGQz1PHtdBRJ6AVw0fh

Let me check further.
----
Cheers,
Lakshmipathi.G
http://www.giis.co.in http://www.webminal.org


On Fri, Nov 24, 2017 at 9:55 AM, Lakshmipathi.G
<lakshmipathi.g@gmail.com> wrote:
> Hi Qu,
>
> I'm using the same instance. Let me check again with and without the
> commits list on Nov-23
> (https://github.com/kdave/btrfs-devel/commits/misc-next) and get back
> with results.
>
> ----
> Cheers,
> Lakshmipathi.G
> http://www.giis.co.in http://www.webminal.org

Re: misc/021-image-multi-devices fails on latest btrfs-devel/misc-next

[Qu Wenruo]

[-- Attachment #1.1: Type: text/plain, Size: 1572 bytes --]



On 2017年11月24日 15:47, Lakshmipathi.G wrote:
> Hi Qu,
> 
> I'm using btrfs-progs devel branch. mount command is failing with misc/021.
> When I tried to manually mount it. dmesg shows  "unrecognized super
> flag: 17179869184"
> and interestingly "df -h" shows 16E as available!

That flag is meta dump flag, any image recovered from btrfs-image should
have that flag.

16E may also related to that, but not a big problem as btrfs-image
result should only be used by developers, and all its data is wiped out.
(Maybe one day we will not allow RW mount for such image)


The problem happens when you try to mount the image, there may be some
new commits doing more restrict check for rw mount in devel branch.

Would you please try v4.14 kernel?

Thanks,
Qu

> 
> https://asciinema.org/a/4JGYg7YGQz1PHtdBRJ6AVw0fh
> 
> Let me check further.
> ----
> Cheers,
> Lakshmipathi.G
> http://www.giis.co.in http://www.webminal.org
> 
> 
> On Fri, Nov 24, 2017 at 9:55 AM, Lakshmipathi.G
> <lakshmipathi.g@gmail.com> wrote:
>> Hi Qu,
>>
>> I'm using the same instance. Let me check again with and without the
>> commits list on Nov-23
>> (https://github.com/kdave/btrfs-devel/commits/misc-next) and get back
>> with results.
>>
>> ----
>> Cheers,
>> Lakshmipathi.G
>> http://www.giis.co.in http://www.webminal.org
> --
> To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 520 bytes --]

Re: misc/021-image-multi-devices fails on latest btrfs-devel/misc-next

[Lakshmipathi.G]

Okay thanks for the details on btrfs-image. I was about to try with
previous version of
btrfs-image.

I'll use v4.14 (https://cdn.kernel.org/pub/linux/kernel/v4.x/linux-4.14.tar.xz)
and check
again.

----
Cheers,
Lakshmipathi.G
http://www.giis.co.in http://www.webminal.org


On Fri, Nov 24, 2017 at 1:36 PM, Qu Wenruo <quwenruo.btrfs@gmx.com> wrote:
>
>
> On 2017年11月24日 15:47, Lakshmipathi.G wrote:
>> Hi Qu,
>>
>> I'm using btrfs-progs devel branch. mount command is failing with misc/021.
>> When I tried to manually mount it. dmesg shows  "unrecognized super
>> flag: 17179869184"
>> and interestingly "df -h" shows 16E as available!
>
> That flag is meta dump flag, any image recovered from btrfs-image should
> have that flag.
>
> 16E may also related to that, but not a big problem as btrfs-image
> result should only be used by developers, and all its data is wiped out.
> (Maybe one day we will not allow RW mount for such image)
>
>
> The problem happens when you try to mount the image, there may be some
> new commits doing more restrict check for rw mount in devel branch.
>
> Would you please try v4.14 kernel?
>
> Thanks,
> Qu
>
>>
>> https://asciinema.org/a/4JGYg7YGQz1PHtdBRJ6AVw0fh
>>
>> Let me check further.
>> ----
>> Cheers,
>> Lakshmipathi.G
>> http://www.giis.co.in http://www.webminal.org
>>
>>
>> On Fri, Nov 24, 2017 at 9:55 AM, Lakshmipathi.G
>> <lakshmipathi.g@gmail.com> wrote:
>>> Hi Qu,
>>>
>>> I'm using the same instance. Let me check again with and without the
>>> commits list on Nov-23
>>> (https://github.com/kdave/btrfs-devel/commits/misc-next) and get back
>>> with results.
>>>
>>> ----
>>> Cheers,
>>> Lakshmipathi.G
>>> http://www.giis.co.in http://www.webminal.org
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>>
>

Re: misc/021-image-multi-devices fails on latest btrfs-devel/misc-next

[Qu Wenruo]

[-- Attachment #1.1: Type: text/plain, Size: 2549 bytes --]



On 2017年11月24日 16:20, Lakshmipathi.G wrote:
> Okay thanks for the details on btrfs-image. I was about to try with
> previous version of
> btrfs-image.

No, it's not about btrfs-image itself, the flag is introduced long long
long way ago.

It's about kernel change which doesn't allow image with such flag to be
mounted AFAIK.

Thanks,
Qu

> 
> I'll use v4.14 (https://cdn.kernel.org/pub/linux/kernel/v4.x/linux-4.14.tar.xz)
> and check
> again.
> 
> ----
> Cheers,
> Lakshmipathi.G
> http://www.giis.co.in http://www.webminal.org
> 
> 
> On Fri, Nov 24, 2017 at 1:36 PM, Qu Wenruo <quwenruo.btrfs@gmx.com> wrote:
>>
>>
>> On 2017年11月24日 15:47, Lakshmipathi.G wrote:
>>> Hi Qu,
>>>
>>> I'm using btrfs-progs devel branch. mount command is failing with misc/021.
>>> When I tried to manually mount it. dmesg shows  "unrecognized super
>>> flag: 17179869184"
>>> and interestingly "df -h" shows 16E as available!
>>
>> That flag is meta dump flag, any image recovered from btrfs-image should
>> have that flag.
>>
>> 16E may also related to that, but not a big problem as btrfs-image
>> result should only be used by developers, and all its data is wiped out.
>> (Maybe one day we will not allow RW mount for such image)
>>
>>
>> The problem happens when you try to mount the image, there may be some
>> new commits doing more restrict check for rw mount in devel branch.
>>
>> Would you please try v4.14 kernel?
>>
>> Thanks,
>> Qu
>>
>>>
>>> https://asciinema.org/a/4JGYg7YGQz1PHtdBRJ6AVw0fh
>>>
>>> Let me check further.
>>> ----
>>> Cheers,
>>> Lakshmipathi.G
>>> http://www.giis.co.in http://www.webminal.org
>>>
>>>
>>> On Fri, Nov 24, 2017 at 9:55 AM, Lakshmipathi.G
>>> <lakshmipathi.g@gmail.com> wrote:
>>>> Hi Qu,
>>>>
>>>> I'm using the same instance. Let me check again with and without the
>>>> commits list on Nov-23
>>>> (https://github.com/kdave/btrfs-devel/commits/misc-next) and get back
>>>> with results.
>>>>
>>>> ----
>>>> Cheers,
>>>> Lakshmipathi.G
>>>> http://www.giis.co.in http://www.webminal.org
>>> --
>>> To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
>>> the body of a message to majordomo@vger.kernel.org
>>> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>>>
>>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 520 bytes --]

Re: misc/021-image-multi-devices fails on latest btrfs-devel/misc-next

[Lakshmipathi.G]

>
> No, it's not about btrfs-image itself, the flag is introduced long long
> long way ago.
>
Okay.

> It's about kernel change which doesn't allow image with such flag to be
> mounted AFAIK.

No luck yet! It works on 4.14.0
-----
-bash-4.4$ sudo make TEST=021\* test-misc
    [TEST]   misc-tests.sh
    [TEST/misc]   021-image-multi-devices
-bash-4.4$ sudo dmesg
[  162.635824] BTRFS: device fsid f0c92f1b-c1ba-4576-8a07-8ce4f7b5bacd
devid 1 transid 5 /dev/loop0
[  162.672952] BTRFS: device fsid f0c92f1b-c1ba-4576-8a07-8ce4f7b5bacd
devid 2 transid 5 /dev/loop1
[  162.692848] BTRFS info (device loop1): disk space caching is enabled
[  162.695725] BTRFS info (device loop1): has skinny extents
[  162.698003] BTRFS info (device loop1): flagging fs with big metadata feature
[  162.701643] BTRFS info (device loop1): creating UUID tree
[  163.792851] BTRFS warning (device loop0): unrecognized super flag:
17179869184
[  163.796350] BTRFS info (device loop0): disk space caching is enabled
[  163.807644] BTRFS info (device loop0): has skinny extents
[  163.811613] BTRFS info (device loop0): checking UUID tree
[  163.841625] BTRFS error (device loop0): 1 errors while writing supers
[  163.845457] BTRFS: error (device loop0) in write_all_supers:3709:
errno=-5 IO failure (1 errors while writing supers)
[  163.851520] BTRFS info (device loop0): forced readonly
[  163.855184] BTRFS warning (device loop0): Skipping commit of
aborted transaction.
[  163.859121] BTRFS: error (device loop0) in
cleanup_transaction:1873: errno=-5 IO failure
[  163.862577] BTRFS info (device loop0): delayed_refs has NO entry
[  163.865623] BTRFS error (device loop0): commit super ret -5
[  163.868303] BTRFS error (device loop0): cleaner transaction attach
returned -30
-bash-4.4$ uname -a
Linux ip-172-31-33-196.us-west-2.compute.internal 4.14.0 #1 SMP Fri
Nov 24 09:48:11 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux
-----

Cheers,
Lakshmipathi.G
http://www.giis.co.in http://www.webminal.org

Re: misc/021-image-multi-devices fails on latest btrfs-devel/misc-next

[Qu Wenruo]

[-- Attachment #1.1: Type: text/plain, Size: 2859 bytes --]



On 2017年11月24日 18:15, Lakshmipathi.G wrote:
>>
>> No, it's not about btrfs-image itself, the flag is introduced long long
>> long way ago.
>>
> Okay.
> 
>> It's about kernel change which doesn't allow image with such flag to be
>> mounted AFAIK.
> 
> No luck yet! It works on 4.14.0

The same dmesg result as I, so I didn't see any problem here.

To make it clear, what kernel config and commit are you using when the
test fails?

In my test, if I use the david/for-4.15 branch, it will fails to umount
the fs, due to the known bug if you enabled
CONFIG_BTRFS_FS_CHECK_INTEGRITY (you reported it first).
And for any upstream kernel version like v4.14-rc7 or v4.14, not problem
at all.

BTW, the btrfs-progs version should not affect, since all the problem is
about kernel failing to mount.

Despite that (either disable that option or apply the patch I submitted)
I can't reproduce the bug you reported (which fails to mount the fs).

Thanks,
Qu
> -----
> -bash-4.4$ sudo make TEST=021\* test-misc
>     [TEST]   misc-tests.sh
>     [TEST/misc]   021-image-multi-devices
> -bash-4.4$ sudo dmesg
> [  162.635824] BTRFS: device fsid f0c92f1b-c1ba-4576-8a07-8ce4f7b5bacd
> devid 1 transid 5 /dev/loop0
> [  162.672952] BTRFS: device fsid f0c92f1b-c1ba-4576-8a07-8ce4f7b5bacd
> devid 2 transid 5 /dev/loop1
> [  162.692848] BTRFS info (device loop1): disk space caching is enabled
> [  162.695725] BTRFS info (device loop1): has skinny extents
> [  162.698003] BTRFS info (device loop1): flagging fs with big metadata feature
> [  162.701643] BTRFS info (device loop1): creating UUID tree
> [  163.792851] BTRFS warning (device loop0): unrecognized super flag:
> 17179869184
> [  163.796350] BTRFS info (device loop0): disk space caching is enabled
> [  163.807644] BTRFS info (device loop0): has skinny extents
> [  163.811613] BTRFS info (device loop0): checking UUID tree
> [  163.841625] BTRFS error (device loop0): 1 errors while writing supers
> [  163.845457] BTRFS: error (device loop0) in write_all_supers:3709:
> errno=-5 IO failure (1 errors while writing supers)
> [  163.851520] BTRFS info (device loop0): forced readonly
> [  163.855184] BTRFS warning (device loop0): Skipping commit of
> aborted transaction.
> [  163.859121] BTRFS: error (device loop0) in
> cleanup_transaction:1873: errno=-5 IO failure
> [  163.862577] BTRFS info (device loop0): delayed_refs has NO entry
> [  163.865623] BTRFS error (device loop0): commit super ret -5
> [  163.868303] BTRFS error (device loop0): cleaner transaction attach
> returned -30
> -bash-4.4$ uname -a
> Linux ip-172-31-33-196.us-west-2.compute.internal 4.14.0 #1 SMP Fri
> Nov 24 09:48:11 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux
> -----
> 
> Cheers,
> Lakshmipathi.G
> http://www.giis.co.in http://www.webminal.org
> 


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 520 bytes --]

Re: misc/021-image-multi-devices fails on latest btrfs-devel/misc-next

[Qu Wenruo]

[-- Attachment #1.1: Type: text/plain, Size: 1683 bytes --]



On 2017年11月24日 19:42, Lakshmipathi.G wrote:
>>
>> To make it clear, what kernel config and commit are you using when the
>> test fails?
>>
> When I use attached kernel config along with tar from misc-next branch
> (wget https://github.com/kdave/btrfs-devel/archive/misc-next.zip) this
> issue happens.

BTW, David seems to update his branch more often in his git.kernel.org
branch than github.

So it's possible that the branch from github is out dated.

> 
>> In my test, if I use the david/for-4.15 branch, it will fails to umount
>> the fs, due to the known bug if you enabled
>> CONFIG_BTRFS_FS_CHECK_INTEGRITY (you reported it first).
>> And for any upstream kernel version like v4.14-rc7 or v4.14, not problem
>> at all.
>>
> Here's btrfs related config. I checked with 4.14.2 it worked fine there too.
> 
> The issue happens with v4.14-rc7, can you check with above config
> file and zip file(misc-next.zip)?
> 
> $ cat kernel.config | grep "BTRFS"
> CONFIG_BTRFS_FS=y
> CONFIG_BTRFS_FS_POSIX_ACL=y
> CONFIG_BTRFS_FS_CHECK_INTEGRITY=n
> CONFIG_BTRFS_FS_RUN_SANITY_TESTS=n
> CONFIG_BTRFS_DEBUG=y
> CONFIG_BTRFS_ASSERT=y
> CONFIG_BTRFS_FS_REF_VERIFY=y

For v4.14-rc7, even I enabled all the btrfs related configs, I still
can't reproduce it.
------
$ zcat /proc/config.gz  | grep BTRFS
CONFIG_BTRFS_FS=m
CONFIG_BTRFS_FS_POSIX_ACL=y
CONFIG_BTRFS_FS_CHECK_INTEGRITY=y
CONFIG_BTRFS_FS_RUN_SANITY_TESTS=y
CONFIG_BTRFS_DEBUG=y
CONFIG_BTRFS_ASSERT=y
------

So there is something strange happened.

Thanks,
Qu

> 
> thanks!
> 
> ----
> Cheers,
> Lakshmipathi.G
> http://www.giis.co.in http://www.webminal.org
> 


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 520 bytes --]

Re: misc/021-image-multi-devices fails on latest btrfs-devel/misc-next

[Lakshmipathi.G]

>>>
>>> To make it clear, what kernel config and commit are you using when the
>>> test fails?
>>>
>> When I use attached kernel config along with tar from misc-next branch
>> (wget https://github.com/kdave/btrfs-devel/archive/misc-next.zip) this
>> issue happens.
>
> BTW, David seems to update his branch more often in his git.kernel.org
> branch than github.
>
> So it's possible that the branch from github is out dated.

Okay, I didn't know that one, let me checkout his git.kernel.org branch and
check the results there.

>
> For v4.14-rc7, even I enabled all the btrfs related configs, I still
> can't reproduce it.
> ------
> $ zcat /proc/config.gz  | grep BTRFS
> CONFIG_BTRFS_FS=m
> CONFIG_BTRFS_FS_POSIX_ACL=y
> CONFIG_BTRFS_FS_CHECK_INTEGRITY=y
> CONFIG_BTRFS_FS_RUN_SANITY_TESTS=y
> CONFIG_BTRFS_DEBUG=y
> CONFIG_BTRFS_ASSERT=y
> ------
>
> So there is something strange happened.
>

Yes. something strange going on. I use the same kernel config
for misc-next, 4.14 and 4.14.2 - issue happens only with
misc-next, as you mentioned it may not be up-to-date.


----
Cheers,
Lakshmipathi.G
http://www.giis.co.in http://www.webminal.org

Re: misc/021-image-multi-devices fails on latest btrfs-devel/misc-next

[Lakshmipathi.G]

Hi Qu,

I checked with David, Seems like his github/repo.or.cz repo has latest
dev patches
before pushing them into kernel.org repo.

--
With the help of 'git bisect', managed to debug this issue further.
With this patch[1]
applied we are running into this issue.

https://asciinema.org/a/OMLXpd69iHaej0Xfsrr2ihKiP

[1] btrfs: factor __btrfs_open_devices() to create btrfs_open_one_device()
https://github.com/kdave/btrfs-devel/commit/25908a59bb5c54f896c646ed3a1f73b2727ad9b5

----
Cheers,
Lakshmipathi.G
http://www.giis.co.in http://www.webminal.org


On Fri, Nov 24, 2017 at 5:35 PM, Lakshmipathi.G
<lakshmipathi.g@gmail.com> wrote:
>>>>
>>>> To make it clear, what kernel config and commit are you using when the
>>>> test fails?
>>>>
>>> When I use attached kernel config along with tar from misc-next branch
>>> (wget https://github.com/kdave/btrfs-devel/archive/misc-next.zip) this
>>> issue happens.
>>
>> BTW, David seems to update his branch more often in his git.kernel.org
>> branch than github.
>>
>> So it's possible that the branch from github is out dated.
>
> Okay, I didn't know that one, let me checkout his git.kernel.org branch and
> check the results there.
>
>>
>> For v4.14-rc7, even I enabled all the btrfs related configs, I still
>> can't reproduce it.
>> ------
>> $ zcat /proc/config.gz  | grep BTRFS
>> CONFIG_BTRFS_FS=m
>> CONFIG_BTRFS_FS_POSIX_ACL=y
>> CONFIG_BTRFS_FS_CHECK_INTEGRITY=y
>> CONFIG_BTRFS_FS_RUN_SANITY_TESTS=y
>> CONFIG_BTRFS_DEBUG=y
>> CONFIG_BTRFS_ASSERT=y
>> ------
>>
>> So there is something strange happened.
>>
>
> Yes. something strange going on. I use the same kernel config
> for misc-next, 4.14 and 4.14.2 - issue happens only with
> misc-next, as you mentioned it may not be up-to-date.
>
>
> ----
> Cheers,
> Lakshmipathi.G
> http://www.giis.co.in http://www.webminal.org