From: Mimi Zohar <zohar@linux.ibm.com>
To: James Bottomley <James.Bottomley@HansenPartnership.com>,
linux-integrity@vger.kernel.org, keyrings@vger.kernel.org
Cc: jarkko@kernel.org
Subject: Re: [PATCH] KEYS: trusted: Fix TPM reservation for seal/unseal
Date: Wed, 21 Apr 2021 19:11:59 -0400 [thread overview]
Message-ID: <19b01258a143f0eae421f6500a739ec4a53b702e.camel@linux.ibm.com> (raw)
In-Reply-To: <30acbe05a0569bd3b3a9f968c4863e1f42b6d320.camel@HansenPartnership.com>
On Wed, 2021-04-21 at 15:42 -0700, James Bottomley wrote:
> The original patch 8c657a0590de ("KEYS: trusted: Reserve TPM for seal
> and unseal operations") was correct on the mailing list:
>
> https://lore.kernel.org/linux-integrity/20210128235621.127925-4-jarkko@kernel.org/
>
> But somehow got rebased so that the tpm_try_get_ops() in
> tpm2_seal_trusted() got lost. This causes an imbalanced put of the
> TPM ops and causes oopses on TIS based hardware.
>
> This fix puts back the lost tpm_try_get_ops()
>
> Fixes: 8c657a0590de ("KEYS: trusted: Reserve TPM for seal and unseal operations")
> Reported-by: Mimi Zohar <zohar@linux.ibm.com>
> Signed-off-by: James Bottomley <James.Bottomley@HansenPartnership.com>
Thanks, James!
Acked-by: Mimi Zohar <zohar@linux.ibm.com>
Mimi
prev parent reply other threads:[~2021-04-21 23:12 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-21 22:42 [PATCH] KEYS: trusted: Fix TPM reservation for seal/unseal James Bottomley
2021-04-21 23:11 ` Mimi Zohar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=19b01258a143f0eae421f6500a739ec4a53b702e.camel@linux.ibm.com \
--to=zohar@linux.ibm.com \
--cc=James.Bottomley@HansenPartnership.com \
--cc=jarkko@kernel.org \
--cc=keyrings@vger.kernel.org \
--cc=linux-integrity@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.