From mboxrd@z Thu Jan 1 00:00:00 1970 From: Florian Fainelli Subject: Re: [PATCH net-next v4 0/2] Add mii_bus to ixgbe driver for dsa devs Date: Mon, 3 Dec 2018 12:51:21 -0800 Message-ID: <19b22292-f2b3-ccb8-bb37-0952cfa93135@gmail.com> References: <20181203163227.5107-1-stephend@silicom-usa.com> <20181203201432.18252-1-stephend@silicom-usa.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: "David S. Miller" , "intel-wired-lan@lists.osuosl.org" , "netdev@vger.kernel.org" , Andrew Lunn To: Steve Douthit , Jeff Kirsher Return-path: Received: from mail-pl1-f195.google.com ([209.85.214.195]:36147 "EHLO mail-pl1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725913AbeLCUvb (ORCPT ); Mon, 3 Dec 2018 15:51:31 -0500 Received: by mail-pl1-f195.google.com with SMTP id g9so7084956plo.3 for ; Mon, 03 Dec 2018 12:51:30 -0800 (PST) In-Reply-To: <20181203201432.18252-1-stephend@silicom-usa.com> Content-Language: en-US Sender: netdev-owner@vger.kernel.org List-ID: On 12/3/18 12:14 PM, Steve Douthit wrote: > Changes from v3 -> v4 > * Remove unecessary pointer casts > * Fix copy/paste issues in comments > * Simplify setting of swfw semaphore flags > * Collect Reviewed-by: tags > > Changes from v2 -> v3 > * Added warnings about interactions between this code and PHY polling > unit to the commit messages. > > Changes from v1 -> v2 > [PATCH 1/2] ixgbe: register a mdiobus > * Add intel-wired-lan@lists.osuosl.org to CC list, see > * select MII in Kconfig (thanks to the kbuild bot) > * Only call mdiobus_regsiter for single x500em_a device > * Use readx_poll_timeout() in ixgbe_msca_cmd() > * Register different bus->read/write callbacks in ixgbe_mii_bus_init() > so there's device id check on every access > * Use device pci_name() in bus->id instead of parent bridge's name > > [PATCH 2/2] ixgbe: use mii_bus to handle MII related ioctls > * Only use mdiobus_read/write for adapters that registered a mdiobus Not directly related to this patch series, are you using the legacy or "new" way of passing platform data in order to register the DSA switch? Since you mentioned 6390, I would assume this must be the "new" way of registering DSA devices with mdio_boardinfo etc. In that case, have you found yourself limited by the current dsa_chip_platform_data? > > Stephen Douthit (2): > ixgbe: register a mdiobus > ixgbe: use mii_bus to handle MII related ioctls > > drivers/net/ethernet/intel/Kconfig | 1 + > drivers/net/ethernet/intel/ixgbe/ixgbe.h | 2 + > drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 23 ++ > drivers/net/ethernet/intel/ixgbe/ixgbe_phy.c | 307 ++++++++++++++++++ > drivers/net/ethernet/intel/ixgbe/ixgbe_phy.h | 2 + > 5 files changed, 335 insertions(+) > -- Florian From mboxrd@z Thu Jan 1 00:00:00 1970 From: Florian Fainelli Date: Mon, 3 Dec 2018 12:51:21 -0800 Subject: [Intel-wired-lan] [PATCH net-next v4 0/2] Add mii_bus to ixgbe driver for dsa devs In-Reply-To: <20181203201432.18252-1-stephend@silicom-usa.com> References: <20181203163227.5107-1-stephend@silicom-usa.com> <20181203201432.18252-1-stephend@silicom-usa.com> Message-ID: <19b22292-f2b3-ccb8-bb37-0952cfa93135@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: intel-wired-lan@osuosl.org List-ID: On 12/3/18 12:14 PM, Steve Douthit wrote: > Changes from v3 -> v4 > * Remove unecessary pointer casts > * Fix copy/paste issues in comments > * Simplify setting of swfw semaphore flags > * Collect Reviewed-by: tags > > Changes from v2 -> v3 > * Added warnings about interactions between this code and PHY polling > unit to the commit messages. > > Changes from v1 -> v2 > [PATCH 1/2] ixgbe: register a mdiobus > * Add intel-wired-lan at lists.osuosl.org to CC list, see > * select MII in Kconfig (thanks to the kbuild bot) > * Only call mdiobus_regsiter for single x500em_a device > * Use readx_poll_timeout() in ixgbe_msca_cmd() > * Register different bus->read/write callbacks in ixgbe_mii_bus_init() > so there's device id check on every access > * Use device pci_name() in bus->id instead of parent bridge's name > > [PATCH 2/2] ixgbe: use mii_bus to handle MII related ioctls > * Only use mdiobus_read/write for adapters that registered a mdiobus Not directly related to this patch series, are you using the legacy or "new" way of passing platform data in order to register the DSA switch? Since you mentioned 6390, I would assume this must be the "new" way of registering DSA devices with mdio_boardinfo etc. In that case, have you found yourself limited by the current dsa_chip_platform_data? > > Stephen Douthit (2): > ixgbe: register a mdiobus > ixgbe: use mii_bus to handle MII related ioctls > > drivers/net/ethernet/intel/Kconfig | 1 + > drivers/net/ethernet/intel/ixgbe/ixgbe.h | 2 + > drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 23 ++ > drivers/net/ethernet/intel/ixgbe/ixgbe_phy.c | 307 ++++++++++++++++++ > drivers/net/ethernet/intel/ixgbe/ixgbe_phy.h | 2 + > 5 files changed, 335 insertions(+) > -- Florian