From mboxrd@z Thu Jan 1 00:00:00 1970 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933290AbeAIBTC (ORCPT + 1 other); Mon, 8 Jan 2018 20:19:02 -0500 Received: from mga04.intel.com ([192.55.52.120]:5056 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756017AbeAIBTB (ORCPT ); Mon, 8 Jan 2018 20:19:01 -0500 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.46,333,1511856000"; d="scan'208";a="8540521" Subject: Re: [PATCH v7 3/6] perf util: Create function to parse time percent To: Arnaldo Carvalho de Melo Cc: jolsa@kernel.org, peterz@infradead.org, mingo@redhat.com, alexander.shishkin@linux.intel.com, Linux-kernel@vger.kernel.org, ak@linux.intel.com, kan.liang@intel.com, yao.jin@intel.com References: <1512738826-2628-1-git-send-email-yao.jin@linux.intel.com> <1512738826-2628-4-git-send-email-yao.jin@linux.intel.com> <20180108143149.GB25476@kernel.org> <20180108143859.GC25476@kernel.org> From: "Jin, Yao" Message-ID: <19b7b227-ea8d-344d-e4bb-eaca3e9a8f86@linux.intel.com> Date: Tue, 9 Jan 2018 09:18:57 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.5.2 MIME-Version: 1.0 In-Reply-To: <20180108143859.GC25476@kernel.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: On 1/8/2018 10:38 PM, Arnaldo Carvalho de Melo wrote: > Em Mon, Jan 08, 2018 at 11:31:49AM -0300, Arnaldo Carvalho de Melo escreveu: >> Em Fri, Dec 08, 2017 at 09:13:43PM +0800, Jin Yao escreveu: >>> Current perf report/script/... have a --time option to limit the time >>> range of output. But right now it only supports absolute time. >>> >>> For easy using, now it can support a percent of time usage. >>> >>> For example: >>> >>> 1. Select the second 10% time slice >>> perf report --time 10%/2 >> >> After applying this patch I'm not being able to get any of these >> examples to work: >> >> [root@jouet home]# perf report --header | grep "time of" >> # time of first sample : 22947.909226 >> # time of last sample : 22948.910704 >> [root@jouet home]# >> >> Then, when I try the first example: >> >> [root@jouet home]# perf report --stdio --time 1%-20% >> Invalid time string >> # To display the perf.data header info, please use --header/--header-only options. >> # >> [root@jouet home]# >> >> What am I doing wrong? > > Oh well, the way you worded this cset it looked like after applying it I > would be able to use percents, etc, which is not the case, I'll probably > need to apply the next patches to _then_ this work as advertised in this > cset comment. > > Please try to make it clear in the commit messages these details, to > ease reviewing. > > - Arnaldo > Hi Arnaldo, Sorry about that. I will take care next time to try my best to make the patch description more clear. Thanks Jin Yao