From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.4 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 89B2CC433E0 for ; Tue, 28 Jul 2020 07:27:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 608922070B for ; Tue, 28 Jul 2020 07:27:58 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=st.com header.i=@st.com header.b="z00tIkug" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728017AbgG1H15 (ORCPT ); Tue, 28 Jul 2020 03:27:57 -0400 Received: from mx08-00178001.pphosted.com ([91.207.212.93]:34080 "EHLO mx07-00178001.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726990AbgG1H15 (ORCPT ); Tue, 28 Jul 2020 03:27:57 -0400 Received: from pps.filterd (m0046661.ppops.net [127.0.0.1]) by mx07-00178001.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 06S7I0mM015172; Tue, 28 Jul 2020 09:27:39 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=st.com; h=subject : to : cc : references : from : message-id : date : mime-version : in-reply-to : content-type : content-transfer-encoding; s=STMicroelectronics; bh=L908e2AdQSAptw2MG0+5KEEyg20P0DnrpSzY3TXAojs=; b=z00tIkugcratI9e5e77HQjJo3ixY/oHxNREc9N4lcN5UzKrNzBPI0m9+aTks0zETaszu ydeTDMAExij1wXWKKUz37quocYSk3p4XsbdmC6mjXqaPmDRf3BLHDlIxBJtXbNb6p3g4 MUvyqlAM4iumBCxTPVJCOwPPiE543J63KLul1mzH5kvL2qrE55a1VjH2zUMPiPBbYec3 M4AefGRuV4Gfh6JoBihACujluFq8q3hQEWNIUI7CATa5oSytZj/uI5g6yJZ4gJ6NP2P2 hwk2d5XcOkLrrtoEzd/qxVLNBz6MGGn3XASQ3e6HcM10B7VT9Q7cSqCthJkSl7SYe3Zr vg== Received: from beta.dmz-eu.st.com (beta.dmz-eu.st.com [164.129.1.35]) by mx07-00178001.pphosted.com with ESMTP id 32gbmg4q00-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 28 Jul 2020 09:27:39 +0200 Received: from euls16034.sgp.st.com (euls16034.sgp.st.com [10.75.44.20]) by beta.dmz-eu.st.com (STMicroelectronics) with ESMTP id 8562A100034; Tue, 28 Jul 2020 09:27:38 +0200 (CEST) Received: from Webmail-eu.st.com (sfhdag3node2.st.com [10.75.127.8]) by euls16034.sgp.st.com (STMicroelectronics) with ESMTP id 7063121F0BF; Tue, 28 Jul 2020 09:27:38 +0200 (CEST) Received: from lmecxl0995.lme.st.com (10.75.127.45) by SFHDAG3NODE2.st.com (10.75.127.8) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Tue, 28 Jul 2020 09:27:37 +0200 Subject: Re: [PATCH v4 3/3] usb: dwc2: don't use ID/Vbus detection if usb-role-switch on STM32MP15 SoCs To: Andy Shevchenko , Martin Blumenstingl CC: Minas Harutyunyan , Felipe Balbi , Greg Kroah-Hartman , Rob Herring , Maxime Coquelin , Alexandre TORGUE , USB , devicetree , Linux Kernel Mailing List , linux-arm Mailing List , "linux-stm32@st-md-mailman.stormreply.com" , Fabrice GASNIER References: <20200727092346.19780-1-amelie.delaunay@st.com> <20200727092346.19780-4-amelie.delaunay@st.com> From: Amelie DELAUNAY Message-ID: <19ba2fe3-56d1-32a9-3897-27a36ab58c2c@st.com> Date: Tue, 28 Jul 2020 09:27:37 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-Originating-IP: [10.75.127.45] X-ClientProxiedBy: SFHDAG4NODE2.st.com (10.75.127.11) To SFHDAG3NODE2.st.com (10.75.127.8) X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.235,18.0.687 definitions=2020-07-28_01:2020-07-27,2020-07-28 signatures=0 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On 7/27/20 9:44 PM, Andy Shevchenko wrote: > On Mon, Jul 27, 2020 at 10:04 PM Martin Blumenstingl > wrote: >> On Mon, Jul 27, 2020 at 11:23 AM Amelie Delaunay wrote: > >> > -       p->activate_stm_id_vb_detection = true; >> > +       p->activate_stm_id_vb_detection = >> > +               !of_property_read_bool(np, "usb-role-switch"); >> the rest of params.c uses device_property_read_* instead of of_read_property_* >> I thought I'd mention it so you can decide yourself whether this is >> fine or needs to be changed > > Better to change and leave all on one line. > Thank you both for your review. I'll change it in upcoming v5. I'm still not used to exceed the 80 columns :) Regards, Amelie > -- > With Best Regards, > Andy Shevchenko From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 734DEC433E0 for ; Tue, 28 Jul 2020 07:29:17 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 332932070B for ; Tue, 28 Jul 2020 07:29:17 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="c1s1h73c"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=st.com header.i=@st.com header.b="z00tIkug" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 332932070B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=st.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=JFzEsIsqJj6ZaHQu87RSBGNiL0p0hgcpx0g8OmlrtYU=; b=c1s1h73c/FPS5zfy+Wjqchi6L OrBTEbTKZn4ax7bJkNAwBskmAcD6YtbGpLlbwHWRdZuChpVJRVKuiZ2kgP5z56bYXtXMABQXrodpZ 8I3Tw4u6Oby1RJ6OZmCPAzLtSlhtDlD2oK8G2vCPnoAHJMKTDmIq557W6wUvNBL71xjPO6kSPI4JU Y1H2qiA/GdBi93+UEX8iX62ZdKPaRbKG33tffcvKUZNwWjp/uaL9j9XY0bjRD9TLx0qxkypND2jCW SZcxprx55OPQjuWTro9NStb3IG7tVxthaPBME+kDU0/fSYYBGAR2s6HGXVyhRprxt5LcxBsxtnde7 X575wkWbQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1k0K1h-0000yc-3k; Tue, 28 Jul 2020 07:27:53 +0000 Received: from mx08-00178001.pphosted.com ([91.207.212.93] helo=mx07-00178001.pphosted.com) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1k0K1e-0000xg-ET for linux-arm-kernel@lists.infradead.org; Tue, 28 Jul 2020 07:27:51 +0000 Received: from pps.filterd (m0046661.ppops.net [127.0.0.1]) by mx07-00178001.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 06S7I0mM015172; Tue, 28 Jul 2020 09:27:39 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=st.com; h=subject : to : cc : references : from : message-id : date : mime-version : in-reply-to : content-type : content-transfer-encoding; s=STMicroelectronics; bh=L908e2AdQSAptw2MG0+5KEEyg20P0DnrpSzY3TXAojs=; b=z00tIkugcratI9e5e77HQjJo3ixY/oHxNREc9N4lcN5UzKrNzBPI0m9+aTks0zETaszu ydeTDMAExij1wXWKKUz37quocYSk3p4XsbdmC6mjXqaPmDRf3BLHDlIxBJtXbNb6p3g4 MUvyqlAM4iumBCxTPVJCOwPPiE543J63KLul1mzH5kvL2qrE55a1VjH2zUMPiPBbYec3 M4AefGRuV4Gfh6JoBihACujluFq8q3hQEWNIUI7CATa5oSytZj/uI5g6yJZ4gJ6NP2P2 hwk2d5XcOkLrrtoEzd/qxVLNBz6MGGn3XASQ3e6HcM10B7VT9Q7cSqCthJkSl7SYe3Zr vg== Received: from beta.dmz-eu.st.com (beta.dmz-eu.st.com [164.129.1.35]) by mx07-00178001.pphosted.com with ESMTP id 32gbmg4q00-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 28 Jul 2020 09:27:39 +0200 Received: from euls16034.sgp.st.com (euls16034.sgp.st.com [10.75.44.20]) by beta.dmz-eu.st.com (STMicroelectronics) with ESMTP id 8562A100034; Tue, 28 Jul 2020 09:27:38 +0200 (CEST) Received: from Webmail-eu.st.com (sfhdag3node2.st.com [10.75.127.8]) by euls16034.sgp.st.com (STMicroelectronics) with ESMTP id 7063121F0BF; Tue, 28 Jul 2020 09:27:38 +0200 (CEST) Received: from lmecxl0995.lme.st.com (10.75.127.45) by SFHDAG3NODE2.st.com (10.75.127.8) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Tue, 28 Jul 2020 09:27:37 +0200 Subject: Re: [PATCH v4 3/3] usb: dwc2: don't use ID/Vbus detection if usb-role-switch on STM32MP15 SoCs To: Andy Shevchenko , Martin Blumenstingl References: <20200727092346.19780-1-amelie.delaunay@st.com> <20200727092346.19780-4-amelie.delaunay@st.com> From: Amelie DELAUNAY Message-ID: <19ba2fe3-56d1-32a9-3897-27a36ab58c2c@st.com> Date: Tue, 28 Jul 2020 09:27:37 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US X-Originating-IP: [10.75.127.45] X-ClientProxiedBy: SFHDAG4NODE2.st.com (10.75.127.11) To SFHDAG3NODE2.st.com (10.75.127.8) X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.235, 18.0.687 definitions=2020-07-28_01:2020-07-27, 2020-07-28 signatures=0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200728_032750_715763_890B211A X-CRM114-Status: GOOD ( 21.00 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Felipe Balbi , Alexandre TORGUE , devicetree , Greg Kroah-Hartman , USB , Linux Kernel Mailing List , Rob Herring , Maxime Coquelin , Minas Harutyunyan , Fabrice GASNIER , "linux-stm32@st-md-mailman.stormreply.com" , linux-arm Mailing List Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org SGksCgpPbiA3LzI3LzIwIDk6NDQgUE0sIEFuZHkgU2hldmNoZW5rbyB3cm90ZToKPiBPbiBNb24s IEp1bCAyNywgMjAyMCBhdCAxMDowNCBQTSBNYXJ0aW4gQmx1bWVuc3RpbmdsCj4gPG1hcnRpbi5i bHVtZW5zdGluZ2xAZ29vZ2xlbWFpbC5jb20+IHdyb3RlOgo+PiBPbiBNb24sIEp1bCAyNywgMjAy MCBhdCAxMToyMyBBTSBBbWVsaWUgRGVsYXVuYXkgPGFtZWxpZS5kZWxhdW5heUBzdC5jb20+IHdy b3RlOgo+IAo+PiA+IC3CoMKgwqDCoMKgwqAgcC0+YWN0aXZhdGVfc3RtX2lkX3ZiX2RldGVjdGlv biA9IHRydWU7Cj4+ID4gK8KgwqDCoMKgwqDCoCBwLT5hY3RpdmF0ZV9zdG1faWRfdmJfZGV0ZWN0 aW9uID0KPj4gPiArwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCAhb2ZfcHJvcGVydHlfcmVh ZF9ib29sKG5wLCAidXNiLXJvbGUtc3dpdGNoIik7Cj4+IHRoZSByZXN0IG9mIHBhcmFtcy5jIHVz ZXMgZGV2aWNlX3Byb3BlcnR5X3JlYWRfKiBpbnN0ZWFkIG9mIG9mX3JlYWRfcHJvcGVydHlfKgo+ PiBJIHRob3VnaHQgSSdkIG1lbnRpb24gaXQgc28geW91IGNhbiBkZWNpZGUgeW91cnNlbGYgd2hl dGhlciB0aGlzIGlzCj4+IGZpbmUgb3IgbmVlZHMgdG8gYmUgY2hhbmdlZAo+IAo+IEJldHRlciB0 byBjaGFuZ2UgYW5kIGxlYXZlIGFsbCBvbiBvbmUgbGluZS4KPiAKClRoYW5rIHlvdSBib3RoIGZv ciB5b3VyIHJldmlldy4gSSdsbCBjaGFuZ2UgaXQgaW4gdXBjb21pbmcgdjUuIEknbSBzdGlsbCAK bm90IHVzZWQgdG8gZXhjZWVkIHRoZSA4MCBjb2x1bW5zIDopCgpSZWdhcmRzLApBbWVsaWUKCj4g LS0gCj4gV2l0aCBCZXN0IFJlZ2FyZHMsCj4gQW5keSBTaGV2Y2hlbmtvCgpfX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpsaW51eC1hcm0ta2VybmVsIG1haWxp bmcgbGlzdApsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3Rz LmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1hcm0ta2VybmVsCg==