From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 707A6C433E2 for ; Wed, 31 Mar 2021 02:33:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3A82D619DA for ; Wed, 31 Mar 2021 02:33:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233378AbhCaCdL (ORCPT ); Tue, 30 Mar 2021 22:33:11 -0400 Received: from szxga07-in.huawei.com ([45.249.212.35]:15830 "EHLO szxga07-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233401AbhCaCcw (ORCPT ); Tue, 30 Mar 2021 22:32:52 -0400 Received: from DGGEMS405-HUB.china.huawei.com (unknown [172.30.72.60]) by szxga07-in.huawei.com (SkyGuard) with ESMTP id 4F99KH0y9Gz9v1q; Wed, 31 Mar 2021 10:30:43 +0800 (CST) Received: from [10.174.178.154] (10.174.178.154) by smtp.huawei.com (10.3.19.205) with Microsoft SMTP Server (TLS) id 14.3.498.0; Wed, 31 Mar 2021 10:32:39 +0800 Subject: Re: [PATCH] afs: fix no return statement in function returning non-void To: , , CC: References: <20210327121624.194639-1-zhengzengkai@huawei.com> From: Zheng Zengkai Message-ID: <19cc788d-2c14-99ef-1162-ed919364dcfd@huawei.com> Date: Wed, 31 Mar 2021 10:32:38 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <20210327121624.194639-1-zhengzengkai@huawei.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.174.178.154] X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi David and Reviewers, > Add missing return to fix following compilation issue: > > fs/afs/dir.c: In function ‘afs_dir_set_page_dirty’: > fs/afs/dir.c:51:1: error: no return statement in function > returning non-void [-Werror=return-type] > > Fixes: f3ddee8dc4e2 ("afs: Fix directory handling") > Reported-by: Hulk Robot > Signed-off-by: Zheng Zengkai > --- > fs/afs/dir.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/fs/afs/dir.c b/fs/afs/dir.c > index 17548c1faf02..1795a05b7cb7 100644 > --- a/fs/afs/dir.c > +++ b/fs/afs/dir.c > @@ -48,6 +48,7 @@ static void afs_dir_invalidatepage(struct page *page, unsigned int offset, > static int afs_dir_set_page_dirty(struct page *page) > { > BUG(); /* This should never happen. */ > + return 0; > } > > const struct file_operations afs_dir_file_operations = { Is there anyone who can take a look?  ;-) Thanks!