From mboxrd@z Thu Jan 1 00:00:00 1970 From: Maarten Lankhorst Subject: Re: [PATCH 3/5] drm/i915: Call i915_pipe_update_start with uncore.lock held. Date: Mon, 12 Feb 2018 17:41:53 +0100 Message-ID: <19d4b695-e2ee-d06a-4ee6-689e97e54e92@linux.intel.com> References: <20180209095404.76418-1-maarten.lankhorst@linux.intel.com> <20180209095404.76418-4-maarten.lankhorst@linux.intel.com> <151844879607.18923.15930170017428937869@mail.alporthouse.com> <75c049c5-64ce-ae65-32b8-560a3e3e182d@linux.intel.com> <151845028749.18923.17946119254067208206@mail.alporthouse.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by gabe.freedesktop.org (Postfix) with ESMTPS id 002816E159 for ; Mon, 12 Feb 2018 16:41:55 +0000 (UTC) In-Reply-To: <151845028749.18923.17946119254067208206@mail.alporthouse.com> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T3AgMTItMDItMTggb20gMTY6NDQgc2NocmVlZiBDaHJpcyBXaWxzb246Cj4gUXVvdGluZyBNYWFy dGVuIExhbmtob3JzdCAoMjAxOC0wMi0xMiAxNTozOToxNikKPj4gT3AgMTItMDItMTggb20gMTY6 MTkgc2NocmVlZiBDaHJpcyBXaWxzb246Cj4+PiBRdW90aW5nIE1hYXJ0ZW4gTGFua2hvcnN0ICgy MDE4LTAyLTA5IDA5OjU0OjAyKQo+Pj4+IFRoaXMgcmVxdWlyZXMgYmVpbmcgYWJsZSB0byByZWFk IHRoZSB2YmxhbmsgY291bnRlciB3aXRoIHRoZQo+Pj4+IHVuY29yZS5sb2NrIGFscmVhZHkgaGVs ZC4gVGhpcyBpcyBhbHNvIGEgcHJlcGFyYXRpb24gZm9yCj4+Pj4gYmVpbmcgYWJsZSB0byBydW4g dGhlIGVudGlyZSB2YmxhbmsgdXBkYXRlIHNlcXVlbmNlIHdpdGgKPj4+PiB0aGUgdW5jb3JlIGxv Y2sgaGVsZC4KPj4+Pgo+Pj4+IFNpZ25lZC1vZmYtYnk6IE1hYXJ0ZW4gTGFua2hvcnN0IDxtYWFy dGVuLmxhbmtob3JzdEBsaW51eC5pbnRlbC5jb20+Cj4+Pj4gLS0tCj4+Pj4gIGRyaXZlcnMvZ3B1 L2RybS9pOTE1L2k5MTVfaXJxLmMgICAgIHwgNjYgKysrKysrKysrKysrKysrKysrKysrKysrKysr KysrLS0tLS0tLQo+Pj4+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X3RyYWNlLmggICB8ICA1 ICsrLQo+Pj4+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kcnYuaCAgICB8ICAxICsKPj4+ PiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfc3ByaXRlLmMgfCAgMyArLQo+Pj4+ICA0IGZp bGVzIGNoYW5nZWQsIDYwIGluc2VydGlvbnMoKyksIDE1IGRlbGV0aW9ucygtKQo+Pj4+Cj4+Pj4g ZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfaXJxLmMgYi9kcml2ZXJzL2dw dS9kcm0vaTkxNS9pOTE1X2lycS5jCj4+Pj4gaW5kZXggZWRhOTU0M2EwMTk5Li42YzQ5MWU2M2Uw N2MgMTAwNjQ0Cj4+Pj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9pcnEuYwo+Pj4+ ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfaXJxLmMKPj4+PiBAQCAtNzM2LDEzICs3 MzYsMTIgQEAgc3RhdGljIHZvaWQgaTkxNV9lbmFibGVfYXNsZV9waXBlc3RhdChzdHJ1Y3QgZHJt X2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYpCj4+Pj4gIC8qIENhbGxlZCBmcm9tIGRybSBnZW5lcmlj IGNvZGUsIHBhc3NlZCBhICdjcnRjJywgd2hpY2gKPj4+PiAgICogd2UgdXNlIGFzIGEgcGlwZSBp bmRleAo+Pj4+ICAgKi8KPj4+PiAtc3RhdGljIHUzMiBpOTE1X2dldF92YmxhbmtfY291bnRlcihz dHJ1Y3QgZHJtX2RldmljZSAqZGV2LCB1bnNpZ25lZCBpbnQgcGlwZSkKPj4+PiArc3RhdGljIHUz MiBfX2k5MTVfZ2V0X3ZibGFua19jb3VudGVyKHN0cnVjdCBpbnRlbF9jcnRjICpjcnRjKQo+Pj4+ ICB7Cj4+Pj4gLSAgICAgICBzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYgPSB0b19p OTE1KGRldik7Cj4+Pj4gKyAgICAgICBzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYg PSB0b19pOTE1KGNydGMtPmJhc2UuZGV2KTsKPj4+PiAgICAgICAgIGk5MTVfcmVnX3QgaGlnaF9m cmFtZSwgbG93X2ZyYW1lOwo+Pj4+ICAgICAgICAgdTMyIGhpZ2gxLCBoaWdoMiwgbG93LCBwaXhl bCwgdmJsX3N0YXJ0LCBoc3luY19zdGFydCwgaHRvdGFsOwo+Pj4+IC0gICAgICAgY29uc3Qgc3Ry dWN0IGRybV9kaXNwbGF5X21vZGUgKm1vZGUgPSAmZGV2LT52YmxhbmtbcGlwZV0uaHdtb2RlOwo+ Pj4+IC0gICAgICAgdW5zaWduZWQgbG9uZyBpcnFmbGFnczsKPj4+PiArICAgICAgIGNvbnN0IHN0 cnVjdCBkcm1fZGlzcGxheV9tb2RlICptb2RlID0gJmNydGMtPmJhc2UuZGV2LT52YmxhbmtbY3J0 Yy0+cGlwZV0uaHdtb2RlOwo+Pj4gbG9ja2RlcF9hc3NlcnRfaGVsZCgmZGV2X3ByaXYtPnVuY29y ZS5sb2NrKTsKPj4+Cj4+Pj4gIAo+Pj4+ICAgICAgICAgaHRvdGFsID0gbW9kZS0+Y3J0Y19odG90 YWw7Cj4+Pj4gICAgICAgICBoc3luY19zdGFydCA9IG1vZGUtPmNydGNfaHN5bmNfc3RhcnQ7Cj4+ Pj4gQEAgLTc1NiwxMCArNzU1LDggQEAgc3RhdGljIHUzMiBpOTE1X2dldF92YmxhbmtfY291bnRl cihzdHJ1Y3QgZHJtX2RldmljZSAqZGV2LCB1bnNpZ25lZCBpbnQgcGlwZSkKPj4+PiAgICAgICAg IC8qIFN0YXJ0IG9mIHZibGFuayBldmVudCBvY2N1cnMgYXQgc3RhcnQgb2YgaHN5bmMgKi8KPj4+ PiAgICAgICAgIHZibF9zdGFydCAtPSBodG90YWwgLSBoc3luY19zdGFydDsKPj4+PiAgCj4+Pj4g LSAgICAgICBoaWdoX2ZyYW1lID0gUElQRUZSQU1FKHBpcGUpOwo+Pj4+IC0gICAgICAgbG93X2Zy YW1lID0gUElQRUZSQU1FUElYRUwocGlwZSk7Cj4+Pj4gLQo+Pj4+IC0gICAgICAgc3Bpbl9sb2Nr X2lycXNhdmUoJmRldl9wcml2LT51bmNvcmUubG9jaywgaXJxZmxhZ3MpOwo+Pj4+ICsgICAgICAg aGlnaF9mcmFtZSA9IFBJUEVGUkFNRShjcnRjLT5waXBlKTsKPj4+PiArICAgICAgIGxvd19mcmFt ZSA9IFBJUEVGUkFNRVBJWEVMKGNydGMtPnBpcGUpOwo+Pj4+ICAKPj4+PiAgICAgICAgIC8qCj4+ Pj4gICAgICAgICAgKiBIaWdoICYgbG93IHJlZ2lzdGVyIGZpZWxkcyBhcmVuJ3Qgc3luY2hyb25p emVkLCBzbyBtYWtlIHN1cmUKPj4+PiBAQCAtNzcyLDggKzc2OSw2IEBAIHN0YXRpYyB1MzIgaTkx NV9nZXRfdmJsYW5rX2NvdW50ZXIoc3RydWN0IGRybV9kZXZpY2UgKmRldiwgdW5zaWduZWQgaW50 IHBpcGUpCj4+Pj4gICAgICAgICAgICAgICAgIGhpZ2gyID0gSTkxNV9SRUFEX0ZXKGhpZ2hfZnJh bWUpICYgUElQRV9GUkFNRV9ISUdIX01BU0s7Cj4+Pj4gICAgICAgICB9IHdoaWxlIChoaWdoMSAh PSBoaWdoMik7Cj4+Pj4gIAo+Pj4+IC0gICAgICAgc3Bpbl91bmxvY2tfaXJxcmVzdG9yZSgmZGV2 X3ByaXYtPnVuY29yZS5sb2NrLCBpcnFmbGFncyk7Cj4+Pj4gLQo+Pj4+ICAgICAgICAgaGlnaDEg Pj49IFBJUEVfRlJBTUVfSElHSF9TSElGVDsKPj4+PiAgICAgICAgIHBpeGVsID0gbG93ICYgUElQ RV9QSVhFTF9NQVNLOwo+Pj4+ICAgICAgICAgbG93ID4+PSBQSVBFX0ZSQU1FX0xPV19TSElGVDsK Pj4+PiBAQCAtNzg2LDExICs3ODEsNjAgQEAgc3RhdGljIHUzMiBpOTE1X2dldF92YmxhbmtfY291 bnRlcihzdHJ1Y3QgZHJtX2RldmljZSAqZGV2LCB1bnNpZ25lZCBpbnQgcGlwZSkKPj4+PiAgICAg ICAgIHJldHVybiAoKChoaWdoMSA8PCA4KSB8IGxvdykgKyAocGl4ZWwgPj0gdmJsX3N0YXJ0KSkg JiAweGZmZmZmZjsKPj4+PiAgfQo+Pj4+ICAKPj4+PiArc3RhdGljIHUzMiBpOTE1X2dldF92Ymxh bmtfY291bnRlcihzdHJ1Y3QgZHJtX2RldmljZSAqZGV2LCB1bnNpZ25lZCBpbnQgcGlwZSkKPj4+ PiArewo+Pj4+ICsgICAgICAgc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2ID0gdG9f aTkxNShkZXYpOwo+Pj4+ICsgICAgICAgdW5zaWduZWQgbG9uZyBpcnFmbGFnczsKPj4+PiArICAg ICAgIHUzMiByZXQ7Cj4+Pj4gKwo+Pj4+ICsgICAgICAgc3Bpbl9sb2NrX2lycXNhdmUoJmRldl9w cml2LT51bmNvcmUubG9jaywgaXJxZmxhZ3MpOwo+Pj4+ICsgICAgICAgcmV0ID0gaTkxNV9nZXRf dmJsYW5rX2NvdW50ZXIoZGV2LCBwaXBlKTsKPj4+PiArICAgICAgIHNwaW5fdW5sb2NrX2lycXJl c3RvcmUoJmRldl9wcml2LT51bmNvcmUubG9jaywgaXJxZmxhZ3MpOwo+Pj4+ICsKPj4+PiArICAg ICAgIHJldHVybiByZXQ7Cj4+Pj4gK30KPj4+PiArCj4+Pj4gK3N0YXRpYyB1MzIgX19nNHhfZ2V0 X3ZibGFua19jb3VudGVyKHN0cnVjdCBpbnRlbF9jcnRjICpjcnRjKQo+Pj4+ICt7Cj4+Pj4gKyAg ICAgICBzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYgPSB0b19pOTE1KGNydGMtPmJh c2UuZGV2KTsKPj4+IGxvY2tkZXBfYXNzZXJ0X2hlbGQoJmRldl9wcml2LT51bmNvcmUubG9jayk7 ID8KPj4+Cj4+PiBPaywgd2h5IGRvIHdlIG5lZWQgdW5jb3JlLmxvY2sgaGVsZCBoZXJlIGF0IGFs bD8gU2VyaWFsaXNhdGlvbiBvZiBtbWlvCj4+PiBhY2Nlc3MgdG8gdGhlIHNhbWUgY2FjaGVsaW5l IGlzIHRoZSBhZ2Ugb2xkIHJlYXNvbiwgY2FuIHdlIGd1YXJhbnRlZQo+Pj4gdGhhdCBkb2Vzbid0 IGhhcHBlbiBhbnl3YXk/IChQcm9iYWJseSBub3QsIGJ1dCByZWFsbHkgbW9zdCBjYWxsZXJzIGRv Cj4+PiBub3QgbmVlZCB0aGUgbW1pbyB3L2EuKQo+PiBJcyB0aGUgc2VyaWFsaXphdGlvbiBvbmx5 IG5lZWRlZCBmb3Igd3JpdGluZz8KPiBObywgc2FkbHkgbm90LiBDb25jdXJyZW50IGFjY2VzcyBv ZiBhbnkgdHlwZSB0byB0aGUgc2FtZSBjYWNoZWxpbmUgaXMKPiB0aGUgdHJpZ2dlci4gKFN1cHBv c2VkIHRvIGJlIGl2Yi1vbmx5LikKSXQncyBnb25uYSBiZSBhIHBhaW4gdG8gZmluZCBhbGwgdXNl cnMsIHNvIEkgdGhpbmsga2VlcGluZyB0aGUgdW5jb3JlIGxvY2sgaXMgZ29vZCBlbm91Z2ggZm9y IG5vdywgb3Igd2UgbmVlZCB0byBzcGxpdCBvZmYgdGhlIGRpc3BsYXkgZW5naW5lIGxvY2suLgoK PiAgCj4+IFRoZSBvbmx5IHRoaW5nIHRoYXQgY2FuIHJhY2Ugd2l0aCBub25ibG9ja2luZyBhdG9t aWMgY29tbWl0cyBhcmUgbGVnYWN5Cj4+IGN1cnNvciB1cGRhdGVzLCBidXQgdGhvc2UgY2FuIG9u bHkgaGFwcGVuIGlmIHRoZSBjdXJzb3IgcGxhbmUgYXJlIG5vdCBwYXJ0Cj4+IG9mIHRoZSBwcmV2 aW91cyBhdG9taWMgY29tbWl0LiBUaG9zZSBhcmUgYWxzbyBwcm90ZWN0ZWQgYnkgcGxhbmUtPm11 dGV4LAo+PiBzbyBpbiB0aGVvcnkgc2FtZSBjYWNoZSBsaW5lcyBvbiB0aGUgc2FtZSBwaXBlcyBw cm9iYWJseSBjYW4ndCByYWNlLi4KPiBBdCB3b3JzdCwgd2UgY291bGQganVzdCB1c2UgYSB2Ymxh bmstPnNwaW5sb2NrPwpQZXJoYXBzLCBidXQgdGhlIGFtb3VudCBvZiByZWdpc3RlcnMgaXNuJ3Qg ZXhhY3RseSBzbWFsbCwgc28gSSBmZWVsIGJldHRlciBpZiB3ZSB1c2UgdGhlIHNhbWUgbG9jayBj b25zaXN0ZW50bHkuLgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5v cmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1n ZngK