From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Price Date: Tue, 20 Apr 2021 10:47:31 +0100 Subject: [Cluster-devel] [PATCH 1/8] Import linux/gfs2_ondisk.h In-Reply-To: References: <20210419191117.297653-1-anprice@redhat.com> <20210419191117.297653-2-anprice@redhat.com> <9472a989-1265-65d2-292b-5110176c15c6@redhat.com> <8ac4383c-c510-203a-8a47-834c218b1d97@redhat.com> Message-ID: <19d7d492-4cee-9d7c-994a-0830253abd2b@redhat.com> List-Id: To: cluster-devel.redhat.com MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On 20/04/2021 10:07, Andreas Gruenbacher wrote: > On Tue, Apr 20, 2021 at 10:34 AM Andrew Price wrote: >> On 20/04/2021 07:00, Andreas Gruenbacher wrote: >>> On Mon, Apr 19, 2021 at 10:47 PM Andrew Price wrote: >>>> On 19/04/2021 20:35, Andreas Gruenbacher wrote: >>>>> Andy, >>>>> >>>>> On Mon, Apr 19, 2021 at 9:11 PM Andrew Price wrote: >>>>>> diff --git a/gfs2/include/gfs2_ondisk.h b/gfs2/include/gfs2_ondisk.h >>>>>> new file mode 100644 >>>>>> index 00000000..fc948f89 >>>>>> --- /dev/null >>>>>> +++ b/gfs2/include/gfs2_ondisk.h >>>>> >>>>> any reason why this file shouldn't be at gfs2/include/linux/gfs2_ondisk.h? >>>> >>>> I didn't feel it was needed, but it does have the benefit of making sure >>>> we're not picking up the system linux/gfs2_ondisk.h when we #include >>>> and it shows clearly that we're not trying to. >>> >>> Well, we have "-I$(top_srcdir)/gfs2/include" in CPPFLAGS so >>> gfs2/include/linux/types.h is picked up by . We already >>> rely on that working. So gfs2/include/linux/gfs2_ondisk.h would be >>> picked up by already anyway. >> >> So, what would be the advantage of having gfs2_ondisk.h in >> gfs2/include/linux/? I put types.h in that directory because I didn't >> want to change the #include statement, but I didn't see a reason to put >> gfs2_ondisk.h in there. > > It's more consistent if the definitions are always included as > by the kernel and by all user-space programs. Hmm, I guess. I've moved it into gfs2/include/linux/ in my local branch and I'll push it with that change later, barring objections. Andy