From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56148) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c6KbJ-0007jP-1y for qemu-devel@nongnu.org; Mon, 14 Nov 2016 11:59:22 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1c6KbI-0004GD-3F for qemu-devel@nongnu.org; Mon, 14 Nov 2016 11:59:21 -0500 References: <8b945cd9-a601-4c81-495f-c1837f8d8231@redhat.com> <20161114095007.GA4755@noname.str.redhat.com> <62d2eccd-6399-a23a-cb82-4ceae58228d8@redhat.com> <20161114155428.GA9518@noname.str.redhat.com> From: Eric Blake Message-ID: <19dc5096-a0c0-5d6a-84a6-a1066fbac52e@redhat.com> Date: Mon, 14 Nov 2016 10:59:10 -0600 MIME-Version: 1.0 In-Reply-To: <20161114155428.GA9518@noname.str.redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="EgWQrc3XBo82qqoSk9FAOMWGOJEgilqSA" Subject: Re: [Qemu-devel] Assertion failure on qcow2 disk with cluster_size != 64k List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf Cc: Ed Swierk , qemu-block@nongnu.org, qemu-devel@nongnu.org, "Denis V. Lunev" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --EgWQrc3XBo82qqoSk9FAOMWGOJEgilqSA From: Eric Blake To: Kevin Wolf Cc: Ed Swierk , qemu-block@nongnu.org, qemu-devel@nongnu.org, "Denis V. Lunev" Message-ID: <19dc5096-a0c0-5d6a-84a6-a1066fbac52e@redhat.com> Subject: Re: [Qemu-devel] Assertion failure on qcow2 disk with cluster_size != 64k References: <8b945cd9-a601-4c81-495f-c1837f8d8231@redhat.com> <20161114095007.GA4755@noname.str.redhat.com> <62d2eccd-6399-a23a-cb82-4ceae58228d8@redhat.com> <20161114155428.GA9518@noname.str.redhat.com> In-Reply-To: <20161114155428.GA9518@noname.str.redhat.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 11/14/2016 09:54 AM, Kevin Wolf wrote: >>>> Our qcow2 support is currently limited to a maximum of 2M clusters; >>>> while MAX_WRITE_ZEROES_BOUNCE_BUFFER is 32k * 512, or 16M. The >>>> maximum-size bounce buffer should not be the problem here; but for s= ome >>>> reason, it looks like alignment is larger than max_transfer which sh= ould >>>> not normally be possible. I'm still playing with what should be the= >>>> right patch, but hope to have something posted soon. >>> >>> Are you still playing with it? >> >> Patch was posted here: >> >> https://lists.gnu.org/archive/html/qemu-devel/2016-11/msg01603.html >=20 > Ah, yes, sorry. I didn't make the connection today because this one had= > qcow2 in the subject line and the patch doesn't. >=20 > Are you going to add a qemu-iotests case then, or do you want us to > merge the patch as it is? I think the patch is ready to merge as-is; I'm still adding a qemu-iotests addition, but the addition requires enhancing blkdebug which is a bit extreme to be doing after soft freeze (so the tests are probably 2.9 material, while the bug fix is still for 2.8) --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --EgWQrc3XBo82qqoSk9FAOMWGOJEgilqSA Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJYKe1fAAoJEKeha0olJ0NqZ98IAIZzY/qESUyJUs3q+VGmiZCU 87gNpx9XwC7y21acPnhWh+1fW612LW310X4bfqyd1eqm94VwxyGPe4RpBMvsCMjH uwJwUNYfa8EAoqRZrduGec+bXWecfzH+BLkrDfWNKQGATvvJS8wR2N1Y8wm4Ci7S jmbDPE6wJIoLtIIHYR1rdlWxXjFnR0kKVe1nIXJOzjMw5uqVK4XUe+ZAToIPOPR+ w2kGV0N1tIzH4B/HAS7fF/cK0QZvmW+vhICv4Cp6Rs+sA/PJAyFlD4A8ohmZG473 fJUvsvp2jAeul4C+ASO9QP1YUKCOEvHHM9c0jdxrrKTTG1BJveaXleSu4G1n3DY= =gfdn -----END PGP SIGNATURE----- --EgWQrc3XBo82qqoSk9FAOMWGOJEgilqSA--