From: Julien Grall <julien@xen.org>
To: Penny Zheng <Penny.Zheng@arm.com>, xen-devel@lists.xenproject.org
Cc: wei.chen@arm.com, Andrew Cooper <andrew.cooper3@citrix.com>,
George Dunlap <george.dunlap@citrix.com>,
Jan Beulich <jbeulich@suse.com>,
Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>,
Julien Grall <jgrall@amazon.com>
Subject: Re: [PATCH v4 2/6] xen: do not merge reserved pages in free_heap_pages()
Date: Mon, 16 May 2022 18:36:34 +0100 [thread overview]
Message-ID: <19de9898-59ca-5ccc-42cb-ae6f355ae24e@xen.org> (raw)
In-Reply-To: <20220510022733.2422581-3-Penny.Zheng@arm.com>
Hi Penny,
On 10/05/2022 03:27, Penny Zheng wrote:
> The code in free_heap_pages() will try to merge pages with the
> successor/predecessor if pages are suitably aligned. So if the pages
> reserved are right next to the pages given to the heap allocator,
> free_heap_pages() will merge them, and give the reserved pages to heap
> allocator accidently as a result.
>
> So in order to avoid the above scenario, this commit updates free_heap_pages()
> to check whether the predecessor and/or successor has PGC_reserved set,
> when trying to merge the about-to-be-freed chunk with the predecessor
> and/or successor.
>
> Signed-off-by: Penny Zheng <penny.zheng@arm.com>
> Suggested-by: Julien Grall <jgrall@amazon.com>
NIT: In general, the tags are historically ordered. I.e I first sugested
and then you wrote the patch. So the two tags should be inverted.
This can be done on commit:
Reviewed-by: Julien Grall <jgrall@amazon.com>
Cheers,
--
Julien Grall
next prev parent reply other threads:[~2022-05-16 17:36 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-10 2:27 [PATCH V4 0/6] populate/unpopulate memory when domain on static Penny Zheng
2022-05-10 2:27 ` [PATCH v4 1/6] xen: do not free reserved memory into heap Penny Zheng
2022-05-16 18:01 ` Julien Grall
2022-05-17 8:21 ` Penny Zheng
2022-05-17 9:28 ` Julien Grall
2022-05-17 16:07 ` Jan Beulich
2022-05-18 6:06 ` Penny Zheng
2022-05-17 16:11 ` Jan Beulich
2022-05-18 2:29 ` Penny Zheng
2022-05-18 6:30 ` Jan Beulich
2022-05-10 2:27 ` [PATCH v4 2/6] xen: do not merge reserved pages in free_heap_pages() Penny Zheng
2022-05-16 17:36 ` Julien Grall [this message]
2022-05-10 2:27 ` [PATCH v4 3/6] xen: add field "flags" to cover all internal CDF_XXX Penny Zheng
2022-05-10 2:27 ` [PATCH v4 4/6] xen/arm: introduce CDF_staticmem Penny Zheng
2022-05-10 2:27 ` [PATCH v4 5/6] xen/arm: unpopulate memory when domain is static Penny Zheng
2022-05-10 2:27 ` [PATCH v4 6/6] xen: retrieve reserved pages on populate_physmap Penny Zheng
2022-05-16 18:29 ` Julien Grall
2022-05-17 6:24 ` Penny Zheng
2022-05-17 8:48 ` Julien Grall
2022-05-17 16:16 ` Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=19de9898-59ca-5ccc-42cb-ae6f355ae24e@xen.org \
--to=julien@xen.org \
--cc=Penny.Zheng@arm.com \
--cc=andrew.cooper3@citrix.com \
--cc=george.dunlap@citrix.com \
--cc=jbeulich@suse.com \
--cc=jgrall@amazon.com \
--cc=sstabellini@kernel.org \
--cc=wei.chen@arm.com \
--cc=wl@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.