From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 248D8C433F5 for ; Fri, 17 Sep 2021 12:38:55 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CB95C610C9 for ; Fri, 17 Sep 2021 12:38:54 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org CB95C610C9 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=nongnu.org Received: from localhost ([::1]:47698 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mRD8n-0006fS-VQ for qemu-devel@archiver.kernel.org; Fri, 17 Sep 2021 08:38:53 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:41474) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mRD6l-000589-RU for qemu-devel@nongnu.org; Fri, 17 Sep 2021 08:36:47 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:39477) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mRD6h-0004UB-HU for qemu-devel@nongnu.org; Fri, 17 Sep 2021 08:36:46 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1631882200; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=CaoOzV3ClwXcIjBUc4Qk1fBprm3Qyt/HQEFXy1KxM+k=; b=WQvmoxByiVCjDNxsb7YqSqXHpJYqu6xpWgfq7tcp5kqwMANlLkHHOrLbeNQgAZrO8BvCpX AkQJK4U0SU7jsv1vdk9fVR3wEGVVrPKIBVm+JwAjH2QRHDy5IxEIKEH3NT0QpGwrQNTK+E ydUkBFkBFkZhqjImYkkLMQf9RuYN3AU= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-145-6loau_M5OuCrkym5z0uELg-1; Fri, 17 Sep 2021 08:36:37 -0400 X-MC-Unique: 6loau_M5OuCrkym5z0uELg-1 Received: by mail-wm1-f69.google.com with SMTP id c2-20020a7bc8420000b0290238db573ab7so3681007wml.5 for ; Fri, 17 Sep 2021 05:36:37 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=CaoOzV3ClwXcIjBUc4Qk1fBprm3Qyt/HQEFXy1KxM+k=; b=aK9SpD/wKm7faikv5qJE/rAVfs0fL7q6sXLXWuVshVPTzowqyHRMUi3bVMBH4g/IF8 a9Tt1J85mzdLjbHJCIJPdwnSkkfTF6orU7lxa4yHkZBMyPhMAaSrGPKhePMxJQ8XA9cP V+f82slY1byLrBXRbaUZV5WAi5KPpq82PFkeS8aNUQgWyY+AnyN1ACi2EVFTv7Bmg+Ek EAEbQj2KIRngThwByjhHyFs4VlHLN4W8Lczpt1woubEEiGejZoUCnF5Ch+72cCxga/I9 yFAYdjYICXyoE7lY/InJyCqQlnvY/kQoi2qKRZLIR7uj0y+9NbXdGCijE14U+zocUSKa ntAQ== X-Gm-Message-State: AOAM532td/nGF3UXWRX5KWg2oXFc890Lr/BTb+AlQQe0YBRWMpw3M+LH oU1gOA2COl80szz1ceJfBaty5vESqxx7ORzqvPeRsspPQobQIzx+6Z4sFP8e1qWLjIDcNLjcG0I lfbB10Y+2xMZWRGw= X-Received: by 2002:adf:e806:: with SMTP id o6mr11422339wrm.239.1631882196532; Fri, 17 Sep 2021 05:36:36 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzaMPFccj/Fal440q8Vwjfz+tKhrsWrg8tfX8YMYBQ8nJA6V7A0EL2DGetlDwZJoS5VwZVI6g== X-Received: by 2002:adf:e806:: with SMTP id o6mr11422322wrm.239.1631882196314; Fri, 17 Sep 2021 05:36:36 -0700 (PDT) Received: from dresden.str.redhat.com ([2a02:908:1e48:3780:4451:9a65:d4e9:9bb6]) by smtp.gmail.com with ESMTPSA id h15sm6403208wrc.19.2021.09.17.05.36.35 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 17 Sep 2021 05:36:36 -0700 (PDT) Subject: Re: [PATCH 03/15] python/aqmp: Return cleared events from EventListener.clear() To: John Snow , qemu-devel@nongnu.org References: <20210917054047.2042843-1-jsnow@redhat.com> <20210917054047.2042843-4-jsnow@redhat.com> From: Hanna Reitz Message-ID: <19e00805-83cc-f0bf-beea-1ac6ca0472d8@redhat.com> Date: Fri, 17 Sep 2021 14:36:35 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <20210917054047.2042843-4-jsnow@redhat.com> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=hreitz@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US Received-SPF: pass client-ip=216.205.24.124; envelope-from=hreitz@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -46 X-Spam_score: -4.7 X-Spam_bar: ---- X-Spam_report: (-4.7 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.392, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-1.488, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , Vladimir Sementsov-Ogievskiy , Eduardo Habkost , qemu-block@nongnu.org, Cleber Rosa Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 17.09.21 07:40, John Snow wrote: > This serves two purposes: > > (1) It is now possible to discern whether or not clear() removed any > event(s) from the queue with absolute certainty, and > > (2) It is now very easy to get a List of all pending events in one > chunk, which is useful for the sync bridge. > > Signed-off-by: John Snow > --- > python/qemu/aqmp/events.py | 9 +++++++-- > 1 file changed, 7 insertions(+), 2 deletions(-) Not sure if `clear` is an ideal name then, but `drain` sounds like something that would block, and `drop` is really much different from `clear`.  Also, doesn’t matter, having Collection.delete return the deleted element is a common thing in any language’s standard library, so why not have `clear` do the same. Reviewed-by: Hanna Reitz