From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([209.51.188.92]:44329) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hJZ3P-0003WY-At for qemu-devel@nongnu.org; Thu, 25 Apr 2019 03:44:24 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hJZ3N-0007OB-VS for qemu-devel@nongnu.org; Thu, 25 Apr 2019 03:44:23 -0400 References: <20190424103747.10173-1-thuth@redhat.com> <20190424103747.10173-3-thuth@redhat.com> <20190424112537.GF31388@redhat.com> <20190424125046.GJ31388@redhat.com> From: Thomas Huth Message-ID: <19e0671e-bb83-8696-0111-804612fa1d12@redhat.com> Date: Thu, 25 Apr 2019 09:44:07 +0200 MIME-Version: 1.0 In-Reply-To: <20190424125046.GJ31388@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 2/6] tests/qemu-iotests/group: Introduce a new "ci" group for CI pipelines List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?UTF-8?Q?Daniel_P=2e_Berrang=c3=a9?= Cc: qemu-devel@nongnu.org, Fam Zheng , Kevin Wolf , Ed Maste , qemu-block@nongnu.org, =?UTF-8?Q?Alex_Benn=c3=a9e?= , Max Reitz , =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , Li-Wen Hsu On 24/04/2019 14.50, Daniel P. Berrang=C3=A9 wrote: > On Wed, Apr 24, 2019 at 02:37:02PM +0200, Thomas Huth wrote: >> On 24/04/2019 13.25, Daniel P. Berrang=C3=A9 wrote: >>> On Wed, Apr 24, 2019 at 12:37:43PM +0200, Thomas Huth wrote: >>>> Tests in this group are supposed to run in every possible QEMU confi= guration. >>>> That means they should run with every QEMU binary (also non-x86), wi= thout >>>> dependencies on an optional features, they must work at least with t= he qcow2 >>>> image format and be able to run on all kind of host filesystems and = users >>>> (i.e. also as "nobody" or "root"). >>>> >>>> The initial list has been created as a subset of the "quick" group, = where >>>> I've disabled all tests that are failing with qemu-system-aarch64 or >>>> qemu-system-tricore or in one of our CI pipelines. >>>> >>>> Signed-off-by: Thomas Huth >>>> --- >>>> tests/qemu-iotests/group | 194 ++++++++++++++++++++----------------= --- >>>> 1 file changed, 102 insertions(+), 92 deletions(-) >>>> >>>> diff --git a/tests/qemu-iotests/group b/tests/qemu-iotests/group >>>> index bae7718380..2ed42dcc14 100644 >>>> --- a/tests/qemu-iotests/group >>>> +++ b/tests/qemu-iotests/group >>>> @@ -4,63 +4,73 @@ >>>> # - do not start group names with a digit >>>> # >>>> =20 >>>> +# >>>> +# Some notes about the groups: >>>> +# - Tests in the "quick" group should finish within some few second= s >>>> +# - Tests in the "ci" group are suitable for running in CI systems.= That >>>> +# means they should run with every QEMU binary (also non-x86), wi= th >>>> +# every QEMU configuration (i.e. no dependency on an optional fea= ture), >>>> +# at least with the qcow2 image format and all kind of host files= ystems >>>> +# and users (i.e. also as "nobody" or "root"). >>> >>> No dependancy on optional features feels a bit restrictive from my PO= V. >>> >>> We have quite alot of testing coverage of stuff that depends on the >>> crypto libraries that is important for us to run in "CI". This includ= es >>> LUKS block drivers, qcow2 with LUKS, NBD with TLS. Personally I expe= ct >>> all of those to be tested by CI systems. >>> >>> IOW for a "CI" group, the bar should be higher than "no optional feat= ures" >> >> Ok, I think I just did not write it properly. What I meant was: the te= st >> should not *fail* because of a missing feature (what some tests are >> unfortunately doing). It's fine if the test detects the missing featur= e >> and then marks the test as *skip*. >=20 > Ok, this brings back the topic I don't think we ever resolved around ho= w > to best "detect" features in the iotests. eg if we want to know whether > we can use TLS features, how do we decide this ? >=20 > One option is to do a dummy launch of QEMU using TLS & check if it fail= s, > but that's kind of fragile for CI. A genuine bug in QEMU might cause th= is > dummy launch to fail, and thus mistakenly skip all the tests instead of > failing. Maybe we need a "--dump-features" option for QEMU (or a QMP command)? (somewhat similar to "gcc -dumpspecs" for example?) Thomas From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 47AA4C10F03 for ; Thu, 25 Apr 2019 07:45:44 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 08D9F217D7 for ; Thu, 25 Apr 2019 07:45:43 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 08D9F217D7 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([127.0.0.1]:53356 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hJZ4h-0004Jk-5d for qemu-devel@archiver.kernel.org; Thu, 25 Apr 2019 03:45:43 -0400 Received: from eggs.gnu.org ([209.51.188.92]:44329) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hJZ3P-0003WY-At for qemu-devel@nongnu.org; Thu, 25 Apr 2019 03:44:24 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hJZ3N-0007OB-VS for qemu-devel@nongnu.org; Thu, 25 Apr 2019 03:44:23 -0400 Received: from mx1.redhat.com ([209.132.183.28]:48566) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hJZ3J-0007GY-KF; Thu, 25 Apr 2019 03:44:17 -0400 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id A46FC30944F2; Thu, 25 Apr 2019 07:44:16 +0000 (UTC) Received: from thuth.remote.csb (ovpn-116-68.ams2.redhat.com [10.36.116.68]) by smtp.corp.redhat.com (Postfix) with ESMTP id F310318512; Thu, 25 Apr 2019 07:44:08 +0000 (UTC) To: =?UTF-8?Q?Daniel_P=2e_Berrang=c3=a9?= References: <20190424103747.10173-1-thuth@redhat.com> <20190424103747.10173-3-thuth@redhat.com> <20190424112537.GF31388@redhat.com> <20190424125046.GJ31388@redhat.com> From: Thomas Huth Openpgp: preference=signencrypt Autocrypt: addr=thuth@redhat.com; keydata= xsFNBFH7eUwBEACzyOXKU+5Pcs6wNpKzrlJwzRl3VGZt95VCdb+FgoU9g11m7FWcOafrVRwU yYkTm9+7zBUc0sW5AuPGR/dp3pSLX/yFWsA/UB4nJsHqgDvDU7BImSeiTrnpMOTXb7Arw2a2 4CflIyFqjCpfDM4MuTmzTjXq4Uov1giGE9X6viNo1pxyEpd7PanlKNnf4PqEQp06X4IgUacW tSGj6Gcns1bCuHV8OPWLkf4hkRnu8hdL6i60Yxz4E6TqlrpxsfYwLXgEeswPHOA6Mn4Cso9O 0lewVYfFfsmokfAVMKWzOl1Sr0KGI5T9CpmRfAiSHpthhHWnECcJFwl72NTi6kUcUzG4se81 O6n9d/kTj7pzTmBdfwuOZ0YUSqcqs0W+l1NcASSYZQaDoD3/SLk+nqVeCBB4OnYOGhgmIHNW 0CwMRO/GK+20alxzk//V9GmIM2ACElbfF8+Uug3pqiHkVnKqM7W9/S1NH2qmxB6zMiJUHlTH gnVeZX0dgH27mzstcF786uPcdEqS0KJuxh2kk5IvUSL3Qn3ZgmgdxBMyCPciD/1cb7/Ahazr 3ThHQXSHXkH/aDXdfLsKVuwDzHLVSkdSnZdt5HHh75/NFHxwaTlydgfHmFFwodK8y/TjyiGZ zg2Kje38xnz8zKn9iesFBCcONXS7txENTzX0z80WKBhK+XSFJwARAQABzRxUaG9tYXMgSHV0 aCA8dGguaHV0aEBnbXguZGU+wsF7BBMBAgAlAhsDBgsJCAcDAgYVCAIJCgsEFgIDAQIeAQIX gAUCUfuWKwIZAQAKCRAu2dd0/nAttbe/EACb9hafyOb2FmhUqeAiBORSsUifFacQ7laVjcgR I4um8CSHvxijYftpkM2EdAtmXIKgbNDpQoXcWLXB9lu9mLgTO4DVT00TRR65ikn3FCWcyT74 ENTOzRKyKLsDCjhXKPblTPIQbYAUCOWElcyAPm0ERd62fA/rKNxgIiNo/l4UODOMoOJm2/Ox ZoTckW68Eqv7k9L7m7j+Hn3hoDTjAmcCBJt+j7pOhzWvCbqoNOIH8C8qvPaNlrba+R/K6jkO 6jZkTbYQpGIofEQJ/TNn38IsNGpI1ALTHWFtoMxp3j2Imz0REO6dRE2fHRN8sVlHgkoeGhmY NbDsDE1jFQOEObFnu0euk//7BXU7tGOHckVAZ8T1smiRPHfQU7UEH2a/grndxJ+PNeM5w7n2 l+FN3cf2KgPotCK2s9MjSdZA7C5e3rFYO8lqiqTJKvc62vqp3e7B0Kjyy5/QtzSOejBij2QL xkKSFNtxIz4MtuxN8e3IDQNxsKry3nF7R4MDvouXlMo6wP9KuyNWb+vFJt9GtbgfDMIFVamp ZfhEWzWRJH4VgksENA4K/BzjEHCcbTUb1TFsiB1VRnBPJ0SqlvifnfKk6HcpkDk6Pg8Q5FOJ gbNHrdgXsm+m/9GF2zUUr+rOlhVbK23TUqKqPfwnD7uxjpakVcJnsVCFqJpZi1F/ga9IN87B TQRR+3lMARAAtp831HniPHb9AuKq3wj83ujZK8lH5RLrfVsB4X1wi47bwo56BqhXpR/zxPTR eOFT0gnbw9UkphVc7uk/alnXMDEmgvnuxv89PwIQX6k3qLABeV7ykJQG/WT5HQ6+2DdGtVw3 2vjYAPiWQeETsgWRRQMDR0/hwp8s8tL/UodwYCScH6Vxx9pdy353L1fK4Bb9G73a+9FPjp9l x+WwKTsltVqSBuSjyZQ3c3EE8qbTidXZxB38JwARH8yN3TX+t65cbBqLl/zRUUUTapHQpUEd yoAsHIml32e4q+3xdLtTdlLi7FgPBItSazcqZPjEcYW73UAuLcmQmfJlQ5PkDiuqcitn+KzH /1pqsTU7QFZjbmSMJyXY0TDErOFuMOjf20b6arcpEqse1V3IKrb+nqqA2azboRm3pEANLAJw iVTwK3qwGRgK5ut6N/Znv20VEHkFUsRAZoOusrIRfR5HFDxlXguAdEz8M/hxXFYYXqOoaCYy 6pJxTjy0Y/tIfmS/g9Bnp8qg9wsrsnk0+XRnDVPak++G3Uq9tJPwpJbyO0vcqEI3vAXkAB7X VXLzvFwi66RrsPUoDkuzj+aCNumtOePDOCpXQGPpKl+l1aYRMN/+lNSk3+1sVuc2C07WnYyE gV/cbEVklPmKrNwu6DeUyD0qI/bVzKMWZAiB1r56hsGeyYcAEQEAAcLBXwQYAQIACQUCUft5 TAIbDAAKCRAu2dd0/nAttYTwEACLAS/THRqXRKb17PQmKwZHerUvZm2klo+lwQ3wNQBHUJAT p2R9ULexyXrJPqjUpy7+voz+FcKiuQBTKyieiIxO46oMxsbXGZ70o3gxjxdYdgimUD6U8PPd JH8tfAL4BR5FZNjspcnscN2jgbF4OrpDeOLyBaj6HPmElNPtECHWCaf1xbIFsZxSDGMA6cUh 0uX3Q8VI7JN1AR2cfiIRY7NrIlWYucJxyKjO3ivWm69nCtsHiJ0wcF8KlVo7F2eLaufo0K8A ynL8SHMF3VEyxsXOP2f1UR9T2Ur30MXcTBpjUxml1TX3RWY5uH89Js/jlIugBwuAmacJ7JYh lTg6sF/GNc4nPb4kk2yktNWTade+TzsllYlJPaorD2Qe8qX0iFUhFC6y9+O6mP4ZvWoYapp9 ezYNuebMgEr93ob1+4sFg3812wNP01WqsGtWCJHnPv/JoonFdMzD/bIkXGEJMk6ks2kxQQZq g6Ik/s/vxOfao/xCn8nHt7GwvVy41795hzK6tbSl+BuyCRp0vfPRP34OnK7+jR2nvQpJu/pU rCELuGwT9hsYkUPjVd4lfylN3mzEc6iAv/wwjsc0DRTSQCpXT3v2ymTAsRKrVaEZLibTXaf+ WslxWek3xNYRiqwwWAJuL652eAlxUgQ5ZS+fXBRTiQpJ+F26I/2lccScRd9G5w== Organization: Red Hat Message-ID: <19e0671e-bb83-8696-0111-804612fa1d12@redhat.com> Date: Thu, 25 Apr 2019 09:44:07 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <20190424125046.GJ31388@redhat.com> Content-Type: text/plain; charset="UTF-8" Content-Language: en-US X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.40]); Thu, 25 Apr 2019 07:44:16 +0000 (UTC) Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: Re: [Qemu-devel] [PATCH 2/6] tests/qemu-iotests/group: Introduce a new "ci" group for CI pipelines X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Fam Zheng , Kevin Wolf , Ed Maste , qemu-block@nongnu.org, =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , qemu-devel@nongnu.org, Max Reitz , =?UTF-8?Q?Alex_Benn=c3=a9e?= , Li-Wen Hsu Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Message-ID: <20190425074407.a-DWCrdesR7cLFhpHcBuSMrU1cKCePSDqHkPvQLcsWA@z> On 24/04/2019 14.50, Daniel P. Berrang=C3=A9 wrote: > On Wed, Apr 24, 2019 at 02:37:02PM +0200, Thomas Huth wrote: >> On 24/04/2019 13.25, Daniel P. Berrang=C3=A9 wrote: >>> On Wed, Apr 24, 2019 at 12:37:43PM +0200, Thomas Huth wrote: >>>> Tests in this group are supposed to run in every possible QEMU confi= guration. >>>> That means they should run with every QEMU binary (also non-x86), wi= thout >>>> dependencies on an optional features, they must work at least with t= he qcow2 >>>> image format and be able to run on all kind of host filesystems and = users >>>> (i.e. also as "nobody" or "root"). >>>> >>>> The initial list has been created as a subset of the "quick" group, = where >>>> I've disabled all tests that are failing with qemu-system-aarch64 or >>>> qemu-system-tricore or in one of our CI pipelines. >>>> >>>> Signed-off-by: Thomas Huth >>>> --- >>>> tests/qemu-iotests/group | 194 ++++++++++++++++++++----------------= --- >>>> 1 file changed, 102 insertions(+), 92 deletions(-) >>>> >>>> diff --git a/tests/qemu-iotests/group b/tests/qemu-iotests/group >>>> index bae7718380..2ed42dcc14 100644 >>>> --- a/tests/qemu-iotests/group >>>> +++ b/tests/qemu-iotests/group >>>> @@ -4,63 +4,73 @@ >>>> # - do not start group names with a digit >>>> # >>>> =20 >>>> +# >>>> +# Some notes about the groups: >>>> +# - Tests in the "quick" group should finish within some few second= s >>>> +# - Tests in the "ci" group are suitable for running in CI systems.= That >>>> +# means they should run with every QEMU binary (also non-x86), wi= th >>>> +# every QEMU configuration (i.e. no dependency on an optional fea= ture), >>>> +# at least with the qcow2 image format and all kind of host files= ystems >>>> +# and users (i.e. also as "nobody" or "root"). >>> >>> No dependancy on optional features feels a bit restrictive from my PO= V. >>> >>> We have quite alot of testing coverage of stuff that depends on the >>> crypto libraries that is important for us to run in "CI". This includ= es >>> LUKS block drivers, qcow2 with LUKS, NBD with TLS. Personally I expe= ct >>> all of those to be tested by CI systems. >>> >>> IOW for a "CI" group, the bar should be higher than "no optional feat= ures" >> >> Ok, I think I just did not write it properly. What I meant was: the te= st >> should not *fail* because of a missing feature (what some tests are >> unfortunately doing). It's fine if the test detects the missing featur= e >> and then marks the test as *skip*. >=20 > Ok, this brings back the topic I don't think we ever resolved around ho= w > to best "detect" features in the iotests. eg if we want to know whether > we can use TLS features, how do we decide this ? >=20 > One option is to do a dummy launch of QEMU using TLS & check if it fail= s, > but that's kind of fragile for CI. A genuine bug in QEMU might cause th= is > dummy launch to fail, and thus mistakenly skip all the tests instead of > failing. Maybe we need a "--dump-features" option for QEMU (or a QMP command)? (somewhat similar to "gcc -dumpspecs" for example?) Thomas