All of lore.kernel.org
 help / color / mirror / Atom feed
From: Davide Caratti <dcaratti at redhat.com>
To: mptcp at lists.01.org
Subject: [MPTCP] Re: [PATCH net-next 6/6] mptcp: use mptcp backlog.
Date: Wed, 11 Nov 2020 10:02:09 +0100	[thread overview]
Message-ID: <19e6933468367fc79a905ec5359a4283debae324.camel@redhat.com> (raw)
In-Reply-To: daab240341b66f74b998b16c4af4a51171bf1064.1605006569.git.pabeni@redhat.com

[-- Attachment #1: Type: text/plain, Size: 1839 bytes --]

hello,

On Tue, 2020-11-10 at 12:25 +0100, Paolo Abeni wrote:
> We have some tasks triggered by the subflow receive path
> which require to access the msk socket status, specifically:
> mptcp_clean_una() and mptcp_push_pending()
> 
> We have almost everything in place to use the msk backlog
> and a standard !owned by user schema for that.
> 
> Introduce a dummy per msk sk_buff to trigger into the backlog
> as needed.
> 
> Since the worker is no more used to clean the acked data,
> for fallback sockets we need to explicitly call flush them.
> 
> As added bonus we can simplify a lot mptcp_poll() and
> move the timer update under the data lock
> 
> Signed-off-by: Paolo Abeni <pabeni(a)redhat.com>
> --
> rfc v3-> v2:
>  - dfrag_release is always invoked under sock spin lock,
>    must use mem_release
>  - move the mem_reclaim in mptcp_clean_una
>  - cleanup poll, leveraging the previous patch
> ---
>  net/mptcp/options.c  |  18 +++--
>  net/mptcp/protocol.c | 183 +++++++++++++++++++++++++++----------------
>  net/mptcp/protocol.h |   8 ++
>  3 files changed, 134 insertions(+), 75 deletions(-)
> 
> diff --git a/net/mptcp/options.c b/net/mptcp/options.c
> index 3986454a0340..48dd6622a04c 100644
> --- a/net/mptcp/options.c
> +++ b/net/mptcp/options.c
> @@ -189,7 +189,7 @@ static void mptcp_parse_option(const struct sk_buff *skb,
>  				ptr += 4;
>  			}
> 
> -			pr_debug("data_ack=%llu", mp_opt->data_ack);
> +			pr_debug("64=%d data_ack=%llx", mp_opt->ack64, mp_opt->data_ack);

why are you changing (here and in hunks below) the format specifier of
DACKs from decimal to hex format? tcpdump and wireshark print it as
decimal, and we use to compare it with TCP sequence numbers, that are in
decimal format too: I'd prefer to keep it %llu.

WDYT?
-- 
davide


             reply	other threads:[~2020-11-11  9:02 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-11  9:02 Davide Caratti [this message]
2020-11-11  9:26 [MPTCP] Re: [PATCH net-next 6/6] mptcp: use mptcp backlog Paolo Abeni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=19e6933468367fc79a905ec5359a4283debae324.camel@redhat.com \
    --to=unknown@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.