All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paolo Abeni <pabeni@redhat.com>
To: Harini Katakam <harini.katakam@xilinx.com>,
	nicolas.ferre@microchip.com, davem@davemloft.net,
	claudiu.beznea@microchip.com, kuba@kernel.org,
	dumazet@google.com
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
	michal.simek@xilinx.com, harinikatakamlinux@gmail.com,
	radhey.shyam.pandey@xilinx.com
Subject: Re: [PATCH] net: macb: Increment rx bd head after allocating skb and buffer
Date: Tue, 10 May 2022 15:24:45 +0200	[thread overview]
Message-ID: <19e704ace63483a765a3298610218c5d110bb0e4.camel@redhat.com> (raw)
In-Reply-To: <20220509121958.3976-1-harini.katakam@xilinx.com>

Hello,

On Mon, 2022-05-09 at 17:49 +0530, Harini Katakam wrote:
> In gem_rx_refill rx_prepared_head is incremented at the beginning of
> the while loop preparing the skb and data buffers. If the skb or data
> buffer allocation fails, this BD will be unusable BDs until the head
> loops back to the same BD (and obviously buffer allocation succeeds).
> In the unlikely event that there's a string of allocation failures,
> there will be an equal number of unusable BDs and an inconsistent RX
> BD chain. Hence increment the head at the end of the while loop to be
> clean.
> 
> Signed-off-by: Harini Katakam <harini.katakam@xilinx.com>
> Signed-off-by: Michal Simek <michal.simek@xilinx.com>
> Signed-off-by: Radhey Shyam Pandey <radhey.shyam.pandey@xilinx.com>

This looks like targeting the "net" tree, please repost adding a
suitable Fixes tag.

Thanks,

Paolo


  parent reply	other threads:[~2022-05-10 13:48 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-09 12:19 [PATCH] net: macb: Increment rx bd head after allocating skb and buffer Harini Katakam
2022-05-10 10:11 ` Claudiu.Beznea
2022-05-10 13:24 ` Paolo Abeni [this message]
2022-05-10 13:57   ` Harini Katakam

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=19e704ace63483a765a3298610218c5d110bb0e4.camel@redhat.com \
    --to=pabeni@redhat.com \
    --cc=claudiu.beznea@microchip.com \
    --cc=davem@davemloft.net \
    --cc=dumazet@google.com \
    --cc=harini.katakam@xilinx.com \
    --cc=harinikatakamlinux@gmail.com \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=michal.simek@xilinx.com \
    --cc=netdev@vger.kernel.org \
    --cc=nicolas.ferre@microchip.com \
    --cc=radhey.shyam.pandey@xilinx.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.